diff --git a/lucene/src/java/org/apache/lucene/index/DirectoryReader.java b/lucene/src/java/org/apache/lucene/index/DirectoryReader.java index 0009a5f9322..06c4d4009be 100644 --- a/lucene/src/java/org/apache/lucene/index/DirectoryReader.java +++ b/lucene/src/java/org/apache/lucene/index/DirectoryReader.java @@ -27,6 +27,7 @@ import java.util.HashSet; import java.util.List; import java.util.Map; import java.util.Set; +import java.util.concurrent.ConcurrentHashMap; import org.apache.lucene.document.Document; import org.apache.lucene.document.FieldSelector; @@ -36,6 +37,7 @@ import org.apache.lucene.store.LockObtainFailedException; import org.apache.lucene.index.codecs.CodecProvider; import org.apache.lucene.util.Bits; import org.apache.lucene.util.BytesRef; +import org.apache.lucene.util.MapBackedSet; /** * An IndexReader which reads indexes with multiple segments. @@ -104,7 +106,7 @@ class DirectoryReader extends IndexReader implements Cloneable { } else { this.codecs = codecs; } - readerFinishedListeners = Collections.synchronizedSet(new HashSet()); + readerFinishedListeners = new MapBackedSet(new ConcurrentHashMap()); // To reduce the chance of hitting FileNotFound // (and having to retry), we open segments in diff --git a/lucene/src/java/org/apache/lucene/index/FilterIndexReader.java b/lucene/src/java/org/apache/lucene/index/FilterIndexReader.java index 6dc2f48227e..d922a48da7e 100644 --- a/lucene/src/java/org/apache/lucene/index/FilterIndexReader.java +++ b/lucene/src/java/org/apache/lucene/index/FilterIndexReader.java @@ -23,13 +23,13 @@ import org.apache.lucene.index.IndexReader.ReaderContext; import org.apache.lucene.store.Directory; import org.apache.lucene.util.Bits; import org.apache.lucene.util.BytesRef; +import org.apache.lucene.util.MapBackedSet; import java.io.IOException; import java.util.Collection; import java.util.Map; import java.util.Comparator; -import java.util.HashSet; -import java.util.Collections; +import java.util.concurrent.ConcurrentHashMap; /** A FilterIndexReader contains another IndexReader, which it * uses as its basic source of data, possibly transforming the data along the @@ -287,7 +287,7 @@ public class FilterIndexReader extends IndexReader { public FilterIndexReader(IndexReader in) { super(); this.in = in; - readerFinishedListeners = Collections.synchronizedSet(new HashSet()); + readerFinishedListeners = new MapBackedSet(new ConcurrentHashMap()); } @Override diff --git a/lucene/src/java/org/apache/lucene/index/IndexReader.java b/lucene/src/java/org/apache/lucene/index/IndexReader.java index 7688884bb19..684c14e628b 100644 --- a/lucene/src/java/org/apache/lucene/index/IndexReader.java +++ b/lucene/src/java/org/apache/lucene/index/IndexReader.java @@ -34,7 +34,6 @@ import java.io.IOException; import java.io.Closeable; import java.util.Collection; import java.util.List; -import java.util.HashSet; import java.util.Map; import java.util.concurrent.atomic.AtomicInteger; @@ -128,10 +127,7 @@ public abstract class IndexReader implements Cloneable,Closeable { // Defensive (should never be null -- all impls must set // this): if (readerFinishedListeners != null) { - - // Clone the set so that we don't have to sync on - // readerFinishedListeners while invoking them: - for(ReaderFinishedListener listener : new HashSet(readerFinishedListeners)) { + for(ReaderFinishedListener listener : readerFinishedListeners) { listener.finished(this); } } diff --git a/lucene/src/java/org/apache/lucene/index/IndexWriter.java b/lucene/src/java/org/apache/lucene/index/IndexWriter.java index d4fd1a0f630..321daa0aa2b 100644 --- a/lucene/src/java/org/apache/lucene/index/IndexWriter.java +++ b/lucene/src/java/org/apache/lucene/index/IndexWriter.java @@ -30,8 +30,8 @@ import java.util.LinkedList; import java.util.List; import java.util.Map; import java.util.Set; -import java.util.Collections; import java.util.concurrent.atomic.AtomicInteger; +import java.util.concurrent.ConcurrentHashMap; import org.apache.lucene.analysis.Analyzer; import org.apache.lucene.document.Document; @@ -48,6 +48,7 @@ import org.apache.lucene.store.LockObtainFailedException; import org.apache.lucene.util.Bits; import org.apache.lucene.util.Constants; import org.apache.lucene.util.ThreadInterruptedException; +import org.apache.lucene.util.MapBackedSet; /** An IndexWriter creates and maintains an index. @@ -366,7 +367,7 @@ public class IndexWriter implements Closeable { } // Used for all SegmentReaders we open - private final Collection readerFinishedListeners = Collections.synchronizedSet(new HashSet()); + private final Collection readerFinishedListeners = new MapBackedSet(new ConcurrentHashMap()); Collection getReaderFinishedListeners() throws IOException { return readerFinishedListeners; diff --git a/lucene/src/java/org/apache/lucene/index/MultiReader.java b/lucene/src/java/org/apache/lucene/index/MultiReader.java index 1e95cb272d9..0d3a082567b 100644 --- a/lucene/src/java/org/apache/lucene/index/MultiReader.java +++ b/lucene/src/java/org/apache/lucene/index/MultiReader.java @@ -20,14 +20,14 @@ package org.apache.lucene.index; import java.io.IOException; import java.util.Collection; import java.util.Map; -import java.util.HashSet; -import java.util.Collections; +import java.util.concurrent.ConcurrentHashMap; import org.apache.lucene.document.Document; import org.apache.lucene.document.FieldSelector; import org.apache.lucene.util.Bits; import org.apache.lucene.util.BytesRef; import org.apache.lucene.util.ReaderUtil; +import org.apache.lucene.util.MapBackedSet; /** An IndexReader which reads multiple indexes, appending * their content. */ @@ -83,7 +83,7 @@ public class MultiReader extends IndexReader implements Cloneable { } } starts[subReaders.length] = maxDoc; - readerFinishedListeners = Collections.synchronizedSet(new HashSet()); + readerFinishedListeners = new MapBackedSet(new ConcurrentHashMap()); return ReaderUtil.buildReaderContext(this); } diff --git a/lucene/src/java/org/apache/lucene/index/ParallelReader.java b/lucene/src/java/org/apache/lucene/index/ParallelReader.java index 8b789e02058..004066c4daa 100644 --- a/lucene/src/java/org/apache/lucene/index/ParallelReader.java +++ b/lucene/src/java/org/apache/lucene/index/ParallelReader.java @@ -23,9 +23,11 @@ import org.apache.lucene.document.FieldSelectorResult; import org.apache.lucene.document.Fieldable; import org.apache.lucene.util.Bits; import org.apache.lucene.util.BytesRef; +import org.apache.lucene.util.MapBackedSet; import java.io.IOException; import java.util.*; +import java.util.concurrent.ConcurrentHashMap; /** An IndexReader which reads multiple, parallel indexes. Each index added @@ -72,7 +74,7 @@ public class ParallelReader extends IndexReader { public ParallelReader(boolean closeSubReaders) throws IOException { super(); this.incRefReaders = !closeSubReaders; - readerFinishedListeners = Collections.synchronizedSet(new HashSet()); + readerFinishedListeners = new MapBackedSet(new ConcurrentHashMap()); } /** {@inheritDoc} */ diff --git a/lucene/src/java/org/apache/lucene/util/MapBackedSet.java b/lucene/src/java/org/apache/lucene/util/MapBackedSet.java new file mode 100644 index 00000000000..7b0c42c8ae3 --- /dev/null +++ b/lucene/src/java/org/apache/lucene/util/MapBackedSet.java @@ -0,0 +1,73 @@ +package org.apache.lucene.util; + +/** + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +import java.io.Serializable; +import java.util.AbstractSet; +import java.util.Iterator; +import java.util.Map; + +/** + * A Set implementation that wraps an actual Map based + * implementation. + * + * @lucene.internal + */ +public class MapBackedSet extends AbstractSet implements Serializable { + + private static final long serialVersionUID = -6761513279741915432L; + + private final Map map; + + /** + * Creates a new instance which wraps the specified {@code map}. + */ + public MapBackedSet(Map map) { + this.map = map; + } + + @Override + public int size() { + return map.size(); + } + + @Override + public boolean contains(Object o) { + return map.containsKey(o); + } + + @Override + public boolean add(E o) { + return map.put(o, Boolean.TRUE) == null; + } + + @Override + public boolean remove(Object o) { + return map.remove(o) != null; + } + + @Override + public void clear() { + map.clear(); + } + + @Override + public Iterator iterator() { + return map.keySet().iterator(); + } +}