Apache
/
lucene
mirror of https://github.com/apache/lucene.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

LUCENE-8427: Fix bug in BlockMaxConjunctionScorer. 

In case a scorer would return information about a block that doesn't contain
any matches, BlockMaxConjunctionScorer could use invalid score bounds. This
would never occur when building a conjunction of term queries but possibly when
building a conjunction of phrase queries for instance.
This commit is contained in:
Adrien Grand 2018-07-25 10:57:11 +02:00
parent 35fa0b4f55
commit 65f6e6c150
1 changed files with 14 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
lucene/core/src/java/org/apache/lucene/search/BlockMaxConjunctionScorer.java
View File

@ -145,6 +145,20 @@ final class BlockMaxConjunctionScorer extends Scorer {
return NO_MORE_DOCS;
}
if (doc > upTo) {
// This check is useful when scorers return information about blocks
// that do not actually have any matches. Otherwise `doc` will always
// be in the current block already since it is always the result of
// lead.advance(advanceTarget(some_doc_id))
final int nextTarget = advanceTarget(doc);
if (nextTarget != doc) {
doc = lead.advance(nextTarget);
continue;
}
}
assert doc <= upTo;
if (minScore > 0) {
score = leadScorer.score();
if (score < minScores[0]) {