Apache
/
lucene
mirror of https://github.com/apache/lucene.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

SOLR-12145: ConcurrentModificationException in SimNodeStateProvider.getReplicaInfo.

This commit is contained in:
Andrzej Bialecki 2018-03-29 13:42:19 +02:00
parent d7197b2565
commit 668b81721f
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
solr/core/src/test/org/apache/solr/cloud/autoscaling/sim/SimClusterStateProvider.java
View File

@ -20,6 +20,7 @@ package org.apache.solr.cloud.autoscaling.sim;
import java.io.IOException; import java.io.IOException;
import java.lang.invoke.MethodHandles; import java.lang.invoke.MethodHandles;
import java.util.ArrayList; import java.util.ArrayList;
import java.util.Arrays;
import java.util.Collection; import java.util.Collection;
import java.util.Collections; import java.util.Collections;
import java.util.HashMap; import java.util.HashMap;
@ -1155,14 +1156,15 @@ public class SimClusterStateProvider implements ClusterStateProvider {
/** /**
* Return all replica infos for a node. * Return all replica infos for a node.
* @param node node id * @param node node id
* @return list of replicas on that node, or empty list if none * @return copy of the list of replicas on that node, or empty list if none
*/ */
public List<ReplicaInfo> simGetReplicaInfos(String node) { public List<ReplicaInfo> simGetReplicaInfos(String node) {
List<ReplicaInfo> replicas = nodeReplicaMap.get(node); List<ReplicaInfo> replicas = nodeReplicaMap.get(node);
if (replicas == null) { if (replicas == null) {
return Collections.emptyList(); return Collections.emptyList();
} else { } else {
return replicas; // make a defensive copy to avoid ConcurrentModificationException
return Arrays.asList(replicas.toArray(new ReplicaInfo[0]));
} }
} }