From 68a9e8fc97b6268a4ce045fb06438591743d3635 Mon Sep 17 00:00:00 2001 From: Christine Poerschke Date: Fri, 26 Jun 2020 17:42:56 +0100 Subject: [PATCH] SOLR-14376: remove no-longer-needed 'not no filter queries' check in SolrFeatureWeight --- .../src/java/org/apache/solr/ltr/feature/SolrFeature.java | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/solr/contrib/ltr/src/java/org/apache/solr/ltr/feature/SolrFeature.java b/solr/contrib/ltr/src/java/org/apache/solr/ltr/feature/SolrFeature.java index 3d32f374e12..c46a84ca0c3 100644 --- a/solr/contrib/ltr/src/java/org/apache/solr/ltr/feature/SolrFeature.java +++ b/solr/contrib/ltr/src/java/org/apache/solr/ltr/feature/SolrFeature.java @@ -173,11 +173,9 @@ public class SolrFeature extends Feature { } } - if (filterQueries.isEmpty() == false) { // TODO optimize getDocSet to make this check unnecessary SOLR-14376 - DocSet filtersDocSet = searcher.getDocSet(filterQueries); // execute - if (filtersDocSet != searcher.getLiveDocSet()) { - filterDocSetQuery = filtersDocSet.getTopFilter(); - } + DocSet filtersDocSet = searcher.getDocSet(filterQueries); // execute + if (filtersDocSet != searcher.getLiveDocSet()) { + filterDocSetQuery = filtersDocSet.getTopFilter(); } }