Apache
/
lucene
mirror of https://github.com/apache/lucene.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

LUCENE-9147: Make sure temporary files get deleted on all code paths.

This commit is contained in:
Adrien Grand 2020-02-06 17:12:49 +01:00
parent aa916bac3c
commit 6a380798a2
1 changed files with 2 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
lucene/core/src/java/org/apache/lucene/codecs/compressing/FieldsIndexWriter.java
View File

@ -80,21 +80,15 @@ public final class FieldsIndexWriter implements Closeable {
this.blockShift = blockShift; this.blockShift = blockShift;
this.ioContext = ioContext; this.ioContext = ioContext;
this.docsOut = dir.createTempOutput(name, codecName + "-doc_ids", ioContext); this.docsOut = dir.createTempOutput(name, codecName + "-doc_ids", ioContext);
IndexOutput filePointersOut = null;
boolean success = false; boolean success = false;
try { try {
CodecUtil.writeHeader(docsOut, codecName + "Docs", VERSION_CURRENT); CodecUtil.writeHeader(docsOut, codecName + "Docs", VERSION_CURRENT);
this.filePointersOut = filePointersOut = dir.createTempOutput(name, codecName + "file_pointers", ioContext); filePointersOut = dir.createTempOutput(name, codecName + "file_pointers", ioContext);
CodecUtil.writeHeader(filePointersOut, codecName + "FilePointers", VERSION_CURRENT); CodecUtil.writeHeader(filePointersOut, codecName + "FilePointers", VERSION_CURRENT);
success = true; success = true;
} finally { } finally {
if (success == false) { if (success == false) {
docsOut.close(); close();
dir.deleteFile(docsOut.getName());
if (filePointersOut != null) {
filePointersOut.close();
dir.deleteFile(filePointersOut.getName());
}
} }
} }
} }