Apache
/
lucene
mirror of https://github.com/apache/lucene.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

SOLR-12028: BadApple and AwaitsFix annotations usage

This commit is contained in:
Erick Erickson 2018-10-14 21:13:33 -04:00
parent e14bacfac4
commit 6c5df58b5a
38 changed files with 53 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
lucene/core/src/test/org/apache/lucene/index/TestIndexWriterOnVMError.java
View File

@ -275,6 +275,7 @@ public class TestIndexWriterOnVMError extends LuceneTestCase {
} }
@Nightly @Nightly
@BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // 14-Oct-2018
public void testCheckpoint() throws Exception { public void testCheckpoint() throws Exception {
final Random r = new Random(random().nextLong()); final Random r = new Random(random().nextLong());
doTest(new Failure() { doTest(new Failure() {

1
solr/contrib/ltr/src/test/org/apache/solr/ltr/TestLTROnSolrCloud.java
View File

@ -74,6 +74,7 @@ public class TestLTROnSolrCloud extends TestRerankBase {
@Test @Test
// commented 4-Sep-2018 @LuceneTestCase.BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // 2-Aug-2018 // commented 4-Sep-2018 @LuceneTestCase.BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // 2-Aug-2018
@BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // 14-Oct-2018
public void testSimpleQuery() throws Exception { public void testSimpleQuery() throws Exception {
// will randomly pick a configuration with [1..5] shards and [1..3] replicas // will randomly pick a configuration with [1..5] shards and [1..3] replicas

1
solr/core/src/test/org/apache/solr/cloud/BasicDistributedZkTest.java
View File

@ -150,6 +150,7 @@ public class BasicDistributedZkTest extends AbstractFullDistribZkTestBase {
@Test @Test
@ShardsFixed(num = 4) @ShardsFixed(num = 4)
//DO NOT ENABLE @BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // 12-Jun-2018 //DO NOT ENABLE @BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // 12-Jun-2018
@BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // 14-Oct-2018
public void test() throws Exception { public void test() throws Exception {
// setLoggingLevel(null); // setLoggingLevel(null);

1
solr/core/src/test/org/apache/solr/cloud/DeleteReplicaTest.java
View File

@ -168,6 +168,7 @@ public class DeleteReplicaTest extends SolrCloudTestCase {
@Test @Test
//commented 2-Aug-2018 @BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // 28-June-2018 //commented 2-Aug-2018 @BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // 28-June-2018
@BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // 14-Oct-2018
public void deleteReplicaFromClusterState() throws Exception { public void deleteReplicaFromClusterState() throws Exception {
deleteReplicaFromClusterState("true"); deleteReplicaFromClusterState("true");
deleteReplicaFromClusterState("false"); deleteReplicaFromClusterState("false");

2
solr/core/src/test/org/apache/solr/cloud/LegacyCloudClusterPropTest.java
View File

@ -66,7 +66,7 @@ public class LegacyCloudClusterPropTest extends SolrCloudTestCase {
@Test @Test
//2018-06-18 (commented) @BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") //2018-06-18 (commented) @BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028")
@BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // added 17-Aug-2018 //Commented 14-Oct-2018 @BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // added 17-Aug-2018
public void testCreateCollectionSwitchLegacyCloud() throws Exception { public void testCreateCollectionSwitchLegacyCloud() throws Exception {
createAndTest("legacyTrue", true); createAndTest("legacyTrue", true);
createAndTest("legacyFalse", false); createAndTest("legacyFalse", false);

3
solr/core/src/test/org/apache/solr/cloud/MoveReplicaHDFSTest.java
View File

@ -70,7 +70,8 @@ public class MoveReplicaHDFSTest extends MoveReplicaTest {
//commented 23-AUG-2018 @BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // added 17-Aug-2018 //commented 23-AUG-2018 @BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // added 17-Aug-2018
// commented 4-Sep-2018 @BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // added 23-Aug-2018 // commented 4-Sep-2018 @BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // added 23-Aug-2018
//commented 20-Sep-2018 @BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // 6-Sep-2018 //commented 20-Sep-2018 @BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // 6-Sep-2018
@BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // added 20-Sep-2018 //Commented 14-Oct-2018 @BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // added 20-Sep-2018
@BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // 14-Oct-2018
public void testNormalFailedMove() throws Exception { public void testNormalFailedMove() throws Exception {
inPlaceMove = false; inPlaceMove = false;
testFailedMove(); testFailedMove();

2
solr/core/src/test/org/apache/solr/cloud/OverseerRolesTest.java
View File

@ -86,7 +86,7 @@ public class OverseerRolesTest extends SolrCloudTestCase {
@Test @Test
//commented 2-Aug-2018 @BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // 04-May-2018 //commented 2-Aug-2018 @BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // 04-May-2018
@BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // 6-Sep-2018 //Commented 14-Oct-2018 @BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // 6-Sep-2018
public void testOverseerRole() throws Exception { public void testOverseerRole() throws Exception {
logOverseerState(); logOverseerState();

2
solr/core/src/test/org/apache/solr/cloud/RestartWhileUpdatingTest.java
View File

@ -76,7 +76,7 @@ public class RestartWhileUpdatingTest extends AbstractFullDistribZkTestBase {
} }
@Test @Test
@BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // 21-May-2018 //Commented 14-Oct-2018 @BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // 21-May-2018
public void test() throws Exception { public void test() throws Exception {
handle.clear(); handle.clear();
handle.put("timestamp", SKIPVAL); handle.put("timestamp", SKIPVAL);

1
solr/core/src/test/org/apache/solr/cloud/TestCloudRecovery.java
View File

@ -145,6 +145,7 @@ public class TestCloudRecovery extends SolrCloudTestCase {
} }
@Test @Test
@BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // 14-Oct-2018
public void corruptedLogTest() throws Exception { public void corruptedLogTest() throws Exception {
AtomicInteger countReplayLog = new AtomicInteger(0); AtomicInteger countReplayLog = new AtomicInteger(0);
DirectUpdateHandler2.commitOnClose = false; DirectUpdateHandler2.commitOnClose = false;

4
solr/core/src/test/org/apache/solr/cloud/TestWithCollection.java
View File

@ -176,7 +176,7 @@ public class TestWithCollection extends SolrCloudTestCase {
} }
@Test @Test
@BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // added 23-Aug-2018 //Commented 14-Oct-2018 @BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // added 23-Aug-2018
public void testDeleteWithCollection() throws IOException, SolrServerException, InterruptedException { public void testDeleteWithCollection() throws IOException, SolrServerException, InterruptedException {
String prefix = "testDeleteWithCollection"; String prefix = "testDeleteWithCollection";
String xyz = prefix + "_xyz"; String xyz = prefix + "_xyz";
@ -351,7 +351,7 @@ public class TestWithCollection extends SolrCloudTestCase {
} }
@Test @Test
@BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // added 23-Aug-2018 //Commented 14-Oct-2018 @BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // added 23-Aug-2018
public void testMoveReplicaWithCollection() throws Exception { public void testMoveReplicaWithCollection() throws Exception {
String prefix = "testMoveReplicaWithCollection"; String prefix = "testMoveReplicaWithCollection";
String xyz = prefix + "_xyz"; String xyz = prefix + "_xyz";

1
solr/core/src/test/org/apache/solr/cloud/api/collections/CollectionsAPIAsyncDistributedZkTest.java
View File

@ -192,6 +192,7 @@ public class CollectionsAPIAsyncDistributedZkTest extends SolrCloudTestCase {
assertSame("DeleteCollection did not complete", RequestStatusState.COMPLETED, state); assertSame("DeleteCollection did not complete", RequestStatusState.COMPLETED, state);
} }
// commented 4-Sep-2018 @LuceneTestCase.BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // 2-Aug-2018 // commented 4-Sep-2018 @LuceneTestCase.BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // 2-Aug-2018
@BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // 14-Oct-2018
public void testAsyncIdRaceCondition() throws Exception { public void testAsyncIdRaceCondition() throws Exception {
SolrClient[] clients = new SolrClient[cluster.getJettySolrRunners().size()]; SolrClient[] clients = new SolrClient[cluster.getJettySolrRunners().size()];
int j = 0; int j = 0;

1
solr/core/src/test/org/apache/solr/cloud/api/collections/ShardSplitTest.java
View File

@ -337,6 +337,7 @@ public class ShardSplitTest extends AbstractFullDistribZkTestBase {
} }
@Test @Test
@BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // 14-Oct-2018
public void testSplitMixedReplicaTypesLink() throws Exception { public void testSplitMixedReplicaTypesLink() throws Exception {
doSplitMixedReplicaTypes(SolrIndexSplitter.SplitMethod.LINK); doSplitMixedReplicaTypes(SolrIndexSplitter.SplitMethod.LINK);
} }

2
solr/core/src/test/org/apache/solr/cloud/api/collections/TestLocalFSCloudBackupRestore.java
View File

@ -59,7 +59,7 @@ public class TestLocalFSCloudBackupRestore extends AbstractCloudBackupRestoreTes
@Override @Override
@Test @Test
@BadApple(bugUrl = "https://issues.apache.org/jira/browse/SOLR-12028") // added 09-Aug-2018 //Commented 14-Oct-2018 @BadApple(bugUrl = "https://issues.apache.org/jira/browse/SOLR-12028") // added 09-Aug-2018
public void test() throws Exception { public void test() throws Exception {
super.test(); super.test();
} }

3
solr/core/src/test/org/apache/solr/cloud/autoscaling/ComputePlanActionTest.java
View File

@ -325,6 +325,7 @@ public class ComputePlanActionTest extends SolrCloudTestCase {
} }
@Test @Test
@BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // 14-Oct-2018
public void testNodeAdded() throws Exception { public void testNodeAdded() throws Exception {
CloudSolrClient solrClient = cluster.getSolrClient(); CloudSolrClient solrClient = cluster.getSolrClient();
String setTriggerCommand = "{" + String setTriggerCommand = "{" +
@ -516,6 +517,7 @@ public class ComputePlanActionTest extends SolrCloudTestCase {
} }
@Test @Test
@BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // 14-Oct-2018
public void testNodeAddedTriggerWithAddReplicaPreferredOp_2Shard() throws Exception { public void testNodeAddedTriggerWithAddReplicaPreferredOp_2Shard() throws Exception {
String collectionNamePrefix = "testNodeAddedTriggerWithAddReplicaPreferredOp_2Shard"; String collectionNamePrefix = "testNodeAddedTriggerWithAddReplicaPreferredOp_2Shard";
int numShards = 2; int numShards = 2;
@ -613,6 +615,7 @@ public class ComputePlanActionTest extends SolrCloudTestCase {
} }
@Test @Test
@BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // 14-Oct-2018
public void testNodeLostTriggerWithDeleteNodePreferredOp() throws Exception { public void testNodeLostTriggerWithDeleteNodePreferredOp() throws Exception {
String collectionNamePrefix = "testNodeLostTriggerWithDeleteNodePreferredOp"; String collectionNamePrefix = "testNodeLostTriggerWithDeleteNodePreferredOp";
int numCollections = 1 + random().nextInt(3), numShards = 1 + random().nextInt(3); int numCollections = 1 + random().nextInt(3), numShards = 1 + random().nextInt(3);

1
solr/core/src/test/org/apache/solr/cloud/autoscaling/MetricTriggerIntegrationTest.java
View File

@ -82,6 +82,7 @@ public class MetricTriggerIntegrationTest extends SolrCloudTestCase {
@Test @Test
// commented 4-Sep-2018 @LuceneTestCase.BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // 2-Aug-2018 // commented 4-Sep-2018 @LuceneTestCase.BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // 2-Aug-2018
@BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // 14-Oct-2018
public void testMetricTrigger() throws Exception { public void testMetricTrigger() throws Exception {
cluster.waitForAllNodes(5); cluster.waitForAllNodes(5);

1
solr/core/src/test/org/apache/solr/cloud/autoscaling/ScheduledTriggerIntegrationTest.java
View File

@ -73,6 +73,7 @@ public class ScheduledTriggerIntegrationTest extends SolrCloudTestCase {
@Test @Test
// commented 15-Sep-2018 @LuceneTestCase.BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // 2-Aug-2018 // commented 15-Sep-2018 @LuceneTestCase.BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // 2-Aug-2018
@BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // 14-Oct-2018
public void testScheduledTrigger() throws Exception { public void testScheduledTrigger() throws Exception {
CloudSolrClient solrClient = cluster.getSolrClient(); CloudSolrClient solrClient = cluster.getSolrClient();

2
solr/core/src/test/org/apache/solr/cloud/autoscaling/sim/TestSimComputePlanAction.java
View File

@ -122,6 +122,7 @@ public class TestSimComputePlanAction extends SimSolrCloudTestCase {
} }
@Test @Test
@BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // 14-Oct-2018
public void testNodeLost() throws Exception { public void testNodeLost() throws Exception {
// let's start a node so that we have at least two // let's start a node so that we have at least two
String node = cluster.simAddNode(); String node = cluster.simAddNode();
@ -254,6 +255,7 @@ public class TestSimComputePlanAction extends SimSolrCloudTestCase {
@Test @Test
//17-Aug-2018 commented @LuceneTestCase.BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // 28-June-2018 //17-Aug-2018 commented @LuceneTestCase.BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // 28-June-2018
@BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // 14-Oct-2018
public void testNodeAdded() throws Exception { public void testNodeAdded() throws Exception {
AssertingTriggerAction.expectedNode = null; AssertingTriggerAction.expectedNode = null;
SolrClient solrClient = cluster.simGetSolrClient(); SolrClient solrClient = cluster.simGetSolrClient();

1
solr/core/src/test/org/apache/solr/cloud/autoscaling/sim/TestSimExecutePlanAction.java
View File

@ -156,6 +156,7 @@ public class TestSimExecutePlanAction extends SimSolrCloudTestCase {
} }
@Test @Test
@BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // 14-Oct-2018
public void testIntegration() throws Exception { public void testIntegration() throws Exception {
SolrClient solrClient = cluster.simGetSolrClient(); SolrClient solrClient = cluster.simGetSolrClient();

1
solr/core/src/test/org/apache/solr/cloud/autoscaling/sim/TestSimGenericDistributedQueue.java
View File

@ -32,6 +32,7 @@ public class TestSimGenericDistributedQueue extends TestSimDistributedQueue {
} }
// commented 4-Sep-2018 @BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // added 09-Aug-2018 // commented 4-Sep-2018 @BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // added 09-Aug-2018
@BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // 14-Oct-2018
public void testDistributedQueue() throws Exception { public void testDistributedQueue() throws Exception {
super.testDistributedQueue(); super.testDistributedQueue();
} }

2
solr/core/src/test/org/apache/solr/cloud/autoscaling/sim/TestSimLargeCluster.java
View File

@ -390,6 +390,7 @@ public class TestSimLargeCluster extends SimSolrCloudTestCase {
@Test @Test
// commented 4-Sep-2018 @LuceneTestCase.BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // 2018-06-18 // commented 4-Sep-2018 @LuceneTestCase.BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // 2018-06-18
@BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // 14-Oct-2018
public void testNodeLost() throws Exception { public void testNodeLost() throws Exception {
doTestNodeLost(waitForSeconds, 5000, 0); doTestNodeLost(waitForSeconds, 5000, 0);
} }
@ -634,6 +635,7 @@ public class TestSimLargeCluster extends SimSolrCloudTestCase {
@Test @Test
//commented 2-Aug-2018 @LuceneTestCase.BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // 2018-06-18 //commented 2-Aug-2018 @LuceneTestCase.BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // 2018-06-18
@BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // 14-Oct-2018
public void testSearchRate() throws Exception { public void testSearchRate() throws Exception {
SolrClient solrClient = cluster.simGetSolrClient(); SolrClient solrClient = cluster.simGetSolrClient();
String collectionName = "testSearchRate"; String collectionName = "testSearchRate";

2
solr/core/src/test/org/apache/solr/cloud/autoscaling/sim/TestSimPolicyCloud.java
View File

@ -290,7 +290,7 @@ public class TestSimPolicyCloud extends SimSolrCloudTestCase {
assertEquals(3, coll.getSlice("s3").getReplicas().size()); assertEquals(3, coll.getSlice("s3").getReplicas().size());
coll.forEachReplica(verifyReplicas); coll.forEachReplica(verifyReplicas);
} }
@BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // 14-Oct-2018
public void testCreateCollectionAddShardUsingPolicy() throws Exception { public void testCreateCollectionAddShardUsingPolicy() throws Exception {
SolrClient solrClient = cluster.simGetSolrClient(); SolrClient solrClient = cluster.simGetSolrClient();
String nodeId = cluster.getSimClusterStateProvider().simGetRandomNode(); String nodeId = cluster.getSimClusterStateProvider().simGetRandomNode();

5
solr/core/src/test/org/apache/solr/cloud/autoscaling/sim/TestSimTriggerIntegration.java
View File

@ -290,6 +290,7 @@ public class TestSimTriggerIntegration extends SimSolrCloudTestCase {
@Test @Test
// commented 20-July-2018 @BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // commented 20-July-2018 @BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028")
// commented 4-Sep-2018 @BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // added 09-Aug-2018 // commented 4-Sep-2018 @BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // added 09-Aug-2018
@BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // 14-Oct-2018
public void testNodeLostTriggerRestoreState() throws Exception { public void testNodeLostTriggerRestoreState() throws Exception {
// for this test we want to update the trigger so we must assert that the actions were created twice // for this test we want to update the trigger so we must assert that the actions were created twice
TestSimTriggerIntegration.actionInitCalled = new CountDownLatch(2); TestSimTriggerIntegration.actionInitCalled = new CountDownLatch(2);
@ -464,6 +465,7 @@ public class TestSimTriggerIntegration extends SimSolrCloudTestCase {
@Test @Test
// commented 4-Sep-2018 @BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // 26-Mar-2018 // commented 4-Sep-2018 @BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // 26-Mar-2018
@BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // 14-Oct-2018
public void testNodeLostTrigger() throws Exception { public void testNodeLostTrigger() throws Exception {
SolrClient solrClient = cluster.simGetSolrClient(); SolrClient solrClient = cluster.simGetSolrClient();
String setTriggerCommand = "{" + String setTriggerCommand = "{" +
@ -638,6 +640,7 @@ public class TestSimTriggerIntegration extends SimSolrCloudTestCase {
@Test @Test
// commented 4-Sep-2018 @BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // 16-Apr-2018 // commented 4-Sep-2018 @BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // 16-Apr-2018
@BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // 14-Oct-2018
public void testEventQueue() throws Exception { public void testEventQueue() throws Exception {
waitForSeconds = 1; waitForSeconds = 1;
SolrClient solrClient = cluster.simGetSolrClient(); SolrClient solrClient = cluster.simGetSolrClient();
@ -694,6 +697,7 @@ public class TestSimTriggerIntegration extends SimSolrCloudTestCase {
@Test @Test
// commented 4-Sep-2018 @BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") //2018-03-10 // commented 4-Sep-2018 @BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") //2018-03-10
@BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // 14-Oct-2018
public void testEventFromRestoredState() throws Exception { public void testEventFromRestoredState() throws Exception {
SolrClient solrClient = cluster.simGetSolrClient(); SolrClient solrClient = cluster.simGetSolrClient();
String setTriggerCommand = "{" + String setTriggerCommand = "{" +
@ -1215,6 +1219,7 @@ public class TestSimTriggerIntegration extends SimSolrCloudTestCase {
@Test @Test
//@BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") //@BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028")
@BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // 14-Oct-2018
public void testSearchRate() throws Exception { public void testSearchRate() throws Exception {
SolrClient solrClient = cluster.simGetSolrClient(); SolrClient solrClient = cluster.simGetSolrClient();
String COLL1 = "collection1"; String COLL1 = "collection1";

1
solr/core/src/test/org/apache/solr/cloud/cdcr/CdcrBootstrapTest.java
View File

@ -58,6 +58,7 @@ public class CdcrBootstrapTest extends SolrTestCaseJ4 {
*/ */
@Test @Test
// commented 4-Sep-2018 @LuceneTestCase.BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // 2-Aug-2018 // commented 4-Sep-2018 @LuceneTestCase.BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // 2-Aug-2018
@BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // 14-Oct-2018
public void testConvertClusterToCdcrAndBootstrap() throws Exception { public void testConvertClusterToCdcrAndBootstrap() throws Exception {
// start the target first so that we know its zkhost // start the target first so that we know its zkhost
MiniSolrCloudCluster target = new MiniSolrCloudCluster(1, createTempDir("cdcr-target"), buildJettyConfig("/solr")); MiniSolrCloudCluster target = new MiniSolrCloudCluster(1, createTempDir("cdcr-target"), buildJettyConfig("/solr"));

1
solr/core/src/test/org/apache/solr/cloud/cdcr/CdcrOpsAndBoundariesTest.java
View File

@ -63,6 +63,7 @@ public class CdcrOpsAndBoundariesTest extends SolrTestCaseJ4 {
* Check the ops statistics. * Check the ops statistics.
*/ */
@Test @Test
@BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // 14-Oct-2018
public void testOps() throws Exception { public void testOps() throws Exception {
createCollections(); createCollections();

1
solr/core/src/test/org/apache/solr/cloud/cdcr/CdcrWithNodesRestartsTest.java
View File

@ -195,6 +195,7 @@ public class CdcrWithNodesRestartsTest extends SolrTestCaseJ4 {
} }
@Test @Test
@BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // 14-Oct-2018
public void testReplicationAfterLeaderChange() throws Exception { public void testReplicationAfterLeaderChange() throws Exception {
createCollections(); createCollections();
CdcrTestsUtil.cdcrStart(sourceSolrClient); CdcrTestsUtil.cdcrStart(sourceSolrClient);

3
solr/core/src/test/org/apache/solr/cloud/hdfs/HdfsUnloadDistributedZkTest.java
View File

@ -19,7 +19,6 @@ package org.apache.solr.cloud.hdfs;
import java.io.IOException; import java.io.IOException;
import org.apache.hadoop.hdfs.MiniDFSCluster; import org.apache.hadoop.hdfs.MiniDFSCluster;
import org.apache.lucene.util.LuceneTestCase;
import org.apache.lucene.util.LuceneTestCase.Slow; import org.apache.lucene.util.LuceneTestCase.Slow;
import org.apache.solr.cloud.UnloadDistributedZkTest; import org.apache.solr.cloud.UnloadDistributedZkTest;
import org.apache.solr.util.BadHdfsThreadsFilter; import org.apache.solr.util.BadHdfsThreadsFilter;
@ -34,7 +33,7 @@ import com.carrotsearch.randomizedtesting.annotations.ThreadLeakFilters;
@ThreadLeakFilters(defaultFilters = true, filters = { @ThreadLeakFilters(defaultFilters = true, filters = {
BadHdfsThreadsFilter.class // hdfs currently leaks thread(s) BadHdfsThreadsFilter.class // hdfs currently leaks thread(s)
}) })
@LuceneTestCase.BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // 21-May-2018 //Commented 4-Oct-2018 @LuceneTestCase.BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // 21-May-2018
public class HdfsUnloadDistributedZkTest extends UnloadDistributedZkTest { public class HdfsUnloadDistributedZkTest extends UnloadDistributedZkTest {
private static MiniDFSCluster dfsCluster; private static MiniDFSCluster dfsCluster;

3
solr/core/src/test/org/apache/solr/cloud/hdfs/HdfsWriteToMultipleCollectionsTest.java
View File

@ -31,7 +31,6 @@ import org.apache.lucene.index.IndexWriter;
import org.apache.lucene.store.Directory; import org.apache.lucene.store.Directory;
import org.apache.lucene.store.NRTCachingDirectory; import org.apache.lucene.store.NRTCachingDirectory;
import org.apache.lucene.util.IOUtils; import org.apache.lucene.util.IOUtils;
import org.apache.lucene.util.LuceneTestCase;
import org.apache.lucene.util.LuceneTestCase.Nightly; import org.apache.lucene.util.LuceneTestCase.Nightly;
import org.apache.lucene.util.LuceneTestCase.Slow; import org.apache.lucene.util.LuceneTestCase.Slow;
import org.apache.solr.client.solrj.SolrQuery; import org.apache.solr.client.solrj.SolrQuery;
@ -58,7 +57,7 @@ import org.junit.Test;
@ThreadLeakFilters(defaultFilters = true, filters = { @ThreadLeakFilters(defaultFilters = true, filters = {
BadHdfsThreadsFilter.class // hdfs currently leaks thread(s) BadHdfsThreadsFilter.class // hdfs currently leaks thread(s)
}) })
@LuceneTestCase.BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // 12-Jun-2018 //Commented 4-Oct-2018 @LuceneTestCase.BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // 12-Jun-2018
public class HdfsWriteToMultipleCollectionsTest extends BasicDistributedZkTest { public class HdfsWriteToMultipleCollectionsTest extends BasicDistributedZkTest {
private static final String SOLR_HDFS_HOME = "solr.hdfs.home"; private static final String SOLR_HDFS_HOME = "solr.hdfs.home";
private static final String SOLR_HDFS_BLOCKCACHE_GLOBAL = "solr.hdfs.blockcache.global"; private static final String SOLR_HDFS_BLOCKCACHE_GLOBAL = "solr.hdfs.blockcache.global";

2
solr/core/src/test/org/apache/solr/handler/admin/MetricsHistoryHandlerTest.java
View File

@ -110,7 +110,7 @@ public class MetricsHistoryHandlerTest extends SolrCloudTestCase {
} }
@Test @Test
@BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // added 15-Sep-2018 //Commented 14-Oct-2018 @BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // added 15-Sep-2018
public void testBasic() throws Exception { public void testBasic() throws Exception {
timeSource.sleep(10000); timeSource.sleep(10000);
List<Pair<String, Long>> list = handler.getFactory().list(100); List<Pair<String, Long>> list = handler.getFactory().list(100);

1
solr/core/src/test/org/apache/solr/handler/component/CustomHighlightComponentTest.java
View File

@ -126,6 +126,7 @@ public class CustomHighlightComponentTest extends SolrCloudTestCase {
} }
@Test @Test
@BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // 14-Oct-2018
public void test() throws Exception { public void test() throws Exception {
// determine custom search handler name (the exact name should not matter) // determine custom search handler name (the exact name should not matter)

2
solr/core/src/test/org/apache/solr/handler/component/TestDistributedStatsComponentCardinality.java
View File

@ -101,7 +101,7 @@ public class TestDistributedStatsComponentCardinality extends BaseDistributedSea
} }
@BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // 14-Oct-2018
public void test() throws Exception { public void test() throws Exception {
buildIndex(); buildIndex();

3
solr/core/src/test/org/apache/solr/metrics/reporters/SolrJmxReporterCloudTest.java
View File

@ -26,7 +26,6 @@ import java.util.HashSet;
import java.util.Map; import java.util.Map;
import java.util.Set; import java.util.Set;
import org.apache.lucene.util.LuceneTestCase;
import org.apache.solr.client.solrj.embedded.JettySolrRunner; import org.apache.solr.client.solrj.embedded.JettySolrRunner;
import org.apache.solr.client.solrj.impl.CloudSolrClient; import org.apache.solr.client.solrj.impl.CloudSolrClient;
import org.apache.solr.client.solrj.request.CollectionAdminRequest; import org.apache.solr.client.solrj.request.CollectionAdminRequest;
@ -63,7 +62,7 @@ public class SolrJmxReporterCloudTest extends SolrCloudTestCase {
} }
@Test @Test
@LuceneTestCase.BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // 2-Aug-2018 //Commented 14-Oct-2018 @LuceneTestCase.BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // 2-Aug-2018
public void testJmxReporter() throws Exception { public void testJmxReporter() throws Exception {
CollectionAdminRequest.reloadCollection(COLLECTION).processAndWait(cluster.getSolrClient(), 60); CollectionAdminRequest.reloadCollection(COLLECTION).processAndWait(cluster.getSolrClient(), 60);
CloudSolrClient solrClient = cluster.getSolrClient(); CloudSolrClient solrClient = cluster.getSolrClient();

1
solr/core/src/test/org/apache/solr/search/stats/TestDistribIDF.java
View File

@ -142,6 +142,7 @@ public class TestDistribIDF extends SolrTestCaseJ4 {
@Test @Test
// commented 4-Sep-2018 @LuceneTestCase.BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // 2-Aug-2018 // commented 4-Sep-2018 @LuceneTestCase.BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // 2-Aug-2018
@BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // 14-Oct-2018
public void testMultiCollectionQuery() throws Exception { public void testMultiCollectionQuery() throws Exception {
// collection1 and collection2 are collections which have distributed idf enabled // collection1 and collection2 are collections which have distributed idf enabled
// collection1_local and collection2_local don't have distributed idf available // collection1_local and collection2_local don't have distributed idf available

1
solr/core/src/test/org/apache/solr/uninverting/TestDocTermOrdsUninvertLimit.java
View File

@ -39,6 +39,7 @@ public class TestDocTermOrdsUninvertLimit extends LuceneTestCase {
@SuppressWarnings({"ConstantConditions", "PointlessBooleanExpression"}) @SuppressWarnings({"ConstantConditions", "PointlessBooleanExpression"})
@Nightly @Nightly
// commented 4-Sep-2018 @LuceneTestCase.BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // 12-Jun-2018 // commented 4-Sep-2018 @LuceneTestCase.BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // 12-Jun-2018
@BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // 14-Oct-2018
public void testTriggerUnInvertLimit() throws IOException { public void testTriggerUnInvertLimit() throws IOException {
final boolean SHOULD_TRIGGER = false; // Set this to true to use the test with the old implementation final boolean SHOULD_TRIGGER = false; // Set this to true to use the test with the old implementation

1
solr/core/src/test/org/apache/solr/update/processor/TimeRoutedAliasUpdateProcessorTest.java
View File

@ -115,6 +115,7 @@ public class TimeRoutedAliasUpdateProcessorTest extends SolrCloudTestCase {
@Slow @Slow
@Test @Test
@LogLevel("org.apache.solr.update.processor.TimeRoutedAlias=DEBUG;org.apache.solr.cloud=DEBUG") @LogLevel("org.apache.solr.update.processor.TimeRoutedAlias=DEBUG;org.apache.solr.cloud=DEBUG")
@BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // 14-Oct-2018
public void test() throws Exception { public void test() throws Exception {
String configName = TimeRoutedAliasUpdateProcessorTest.configName + getTestName(); String configName = TimeRoutedAliasUpdateProcessorTest.configName + getTestName();
createConfigSet(configName); createConfigSet(configName);

2
solr/solrj/src/test/org/apache/solr/client/solrj/embedded/LargeVolumeBinaryJettyTest.java
View File

@ -16,6 +16,7 @@
*/ */
package org.apache.solr.client.solrj.embedded; package org.apache.solr.client.solrj.embedded;
import org.apache.lucene.util.LuceneTestCase;
import org.apache.solr.client.solrj.LargeVolumeTestBase; import org.apache.solr.client.solrj.LargeVolumeTestBase;
import org.junit.BeforeClass; import org.junit.BeforeClass;
@ -23,6 +24,7 @@ import org.junit.BeforeClass;
* @see org.apache.solr.client.solrj.impl.BinaryRequestWriter * @see org.apache.solr.client.solrj.impl.BinaryRequestWriter
* @see org.apache.solr.client.solrj.request.JavaBinUpdateRequestCodec * @see org.apache.solr.client.solrj.request.JavaBinUpdateRequestCodec
*/ */
@LuceneTestCase.BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // 14-Oct-2018
public class LargeVolumeBinaryJettyTest extends LargeVolumeTestBase { public class LargeVolumeBinaryJettyTest extends LargeVolumeTestBase {
@BeforeClass @BeforeClass
public static void beforeTest() throws Exception { public static void beforeTest() throws Exception {

2
solr/solrj/src/test/org/apache/solr/client/solrj/embedded/LargeVolumeJettyTest.java
View File

@ -16,10 +16,12 @@
*/ */
package org.apache.solr.client.solrj.embedded; package org.apache.solr.client.solrj.embedded;
import org.apache.lucene.util.LuceneTestCase;
import org.apache.solr.client.solrj.LargeVolumeTestBase; import org.apache.solr.client.solrj.LargeVolumeTestBase;
import org.junit.BeforeClass; import org.junit.BeforeClass;
// commented 4-Sep-2018 @LuceneTestCase.BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // 2-Aug-2018 // commented 4-Sep-2018 @LuceneTestCase.BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // 2-Aug-2018
@LuceneTestCase.BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // 14-Oct-2018
public class LargeVolumeJettyTest extends LargeVolumeTestBase { public class LargeVolumeJettyTest extends LargeVolumeTestBase {
@BeforeClass @BeforeClass
public static void beforeTest() throws Exception { public static void beforeTest() throws Exception {

3
solr/solrj/src/test/org/apache/solr/client/solrj/io/stream/StreamDecoratorTest.java
View File

@ -1565,6 +1565,7 @@ public class StreamDecoratorTest extends SolrCloudTestCase {
} }
@Test @Test
@BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // 14-Oct-2018
public void testParallelRollupStream() throws Exception { public void testParallelRollupStream() throws Exception {
new UpdateRequest() new UpdateRequest()
@ -3296,7 +3297,7 @@ public class StreamDecoratorTest extends SolrCloudTestCase {
} }
@Test @Test
@LuceneTestCase.BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // 2-Aug-2018 //Commented 14-Oct-2018 @LuceneTestCase.BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // 2-Aug-2018
public void testClassifyStream() throws Exception { public void testClassifyStream() throws Exception {
Assume.assumeTrue(!useAlias); Assume.assumeTrue(!useAlias);

7
solr/solrj/src/test/org/apache/solr/common/cloud/TestCollectionStateWatchers.java
View File

@ -26,7 +26,6 @@ import java.util.concurrent.Future;
import java.util.concurrent.TimeUnit; import java.util.concurrent.TimeUnit;
import java.util.concurrent.TimeoutException; import java.util.concurrent.TimeoutException;
import org.apache.lucene.util.LuceneTestCase;
import org.apache.solr.client.solrj.embedded.JettySolrRunner; import org.apache.solr.client.solrj.embedded.JettySolrRunner;
import org.apache.solr.client.solrj.impl.CloudSolrClient; import org.apache.solr.client.solrj.impl.CloudSolrClient;
import org.apache.solr.client.solrj.request.CollectionAdminRequest; import org.apache.solr.client.solrj.request.CollectionAdminRequest;
@ -109,7 +108,7 @@ public class TestCollectionStateWatchers extends SolrCloudTestCase {
} }
@Test @Test
@LuceneTestCase.BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // 12-Jun-2018 //Commented 14-Oct-2018 @LuceneTestCase.BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // 12-Jun-2018
public void testSimpleCollectionWatch() throws Exception { public void testSimpleCollectionWatch() throws Exception {
CloudSolrClient client = cluster.getSolrClient(); CloudSolrClient client = cluster.getSolrClient();
@ -224,7 +223,7 @@ public class TestCollectionStateWatchers extends SolrCloudTestCase {
} }
@Test @Test
@LuceneTestCase.BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // 12-Jun-2018 //Commented 14-Oct-2018 @LuceneTestCase.BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // 12-Jun-2018
public void testWaitForStateWatcherIsRetainedOnPredicateFailure() throws Exception { public void testWaitForStateWatcherIsRetainedOnPredicateFailure() throws Exception {
CloudSolrClient client = cluster.getSolrClient(); CloudSolrClient client = cluster.getSolrClient();
@ -286,7 +285,7 @@ public class TestCollectionStateWatchers extends SolrCloudTestCase {
} }
@Test @Test
@LuceneTestCase.BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // 12-Jun-2018 //Commented 14-Oct-2018 @LuceneTestCase.BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // 12-Jun-2018
public void testWatchesWorkForStateFormat1() throws Exception { public void testWatchesWorkForStateFormat1() throws Exception {
final CloudSolrClient client = cluster.getSolrClient(); final CloudSolrClient client = cluster.getSolrClient();