Apache
/
lucene
mirror of https://github.com/apache/lucene.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix TestPostingsUtil#testIntegerOverflow failure. (#13979) 

The group vint logic is mistakenly using the long->int conversion logic for the
case when integers are being written rather than longs.

Closes #13978
This commit is contained in:
Adrien Grand 2024-11-06 11:34:27 +01:00
parent 8ed71b3e1c
commit 6e78f379d9
2 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lucene/core/src/java/org/apache/lucene/util/GroupVIntUtil.java
View File

@ -292,7 +292,7 @@ public final class GroupVIntUtil {
// tail vints // tail vints
for (; readPos < limit; readPos++) { for (; readPos < limit; readPos++) {
out.writeVInt(toInt(values[readPos])); out.writeVInt(values[readPos]);
} }
} }
} }

10
lucene/core/src/test/org/apache/lucene/codecs/lucene101/TestPostingsUtil.java
View File

@ -27,7 +27,15 @@ public class TestPostingsUtil extends LuceneTestCase {
// checks for bug described in https://github.com/apache/lucene/issues/13373 // checks for bug described in https://github.com/apache/lucene/issues/13373
public void testIntegerOverflow() throws IOException { public void testIntegerOverflow() throws IOException {
final int size = random().nextInt(1, ForUtil.BLOCK_SIZE); // Size that writes the first value as a regular vint
int randomSize1 = random().nextInt(1, 3);
// Size that writes the first value as a group vint
int randomSize2 = random().nextInt(4, ForUtil.BLOCK_SIZE);
doTestIntegerOverflow(randomSize1);
doTestIntegerOverflow(randomSize2);
}
private void doTestIntegerOverflow(int size) throws IOException {
final int[] docDeltaBuffer = new int[size]; final int[] docDeltaBuffer = new int[size];
final int[] freqBuffer = new int[size]; final int[] freqBuffer = new int[size];