From 7006ab73a0fb6cd37ddc15729da1704d81e87a36 Mon Sep 17 00:00:00 2001
From: Uwe Schindler <uschindler@apache.org>
Date: Fri, 5 Sep 2014 17:30:32 +0000
Subject: [PATCH] Better way to pass properties down to Maven: Append them to
 command line as real Maven properties, not as sysprops! Maven-Ant-Tasks
 should have support for that. By that it is now possible to override
 tests.multiplier, which was not possible before (pom.xml defines it so
 sysprop is ignored).

git-svn-id: https://svn.apache.org/repos/asf/lucene/dev/trunk@1622743 13f79535-47bb-0310-9956-ffa450edef68
---
 extra-targets.xml | 32 ++++++++++++++++++++++----------
 1 file changed, 22 insertions(+), 10 deletions(-)

diff --git a/extra-targets.xml b/extra-targets.xml
index add16a4eb78..a10d2b05fd7 100644
--- a/extra-targets.xml
+++ b/extra-targets.xml
@@ -73,24 +73,36 @@
     <echo>You can find the merged Lucene/Solr Clover report in '${clover.report.dir}'.</echo>
   </target>
 
-  <target name="-run-maven-build" depends="install-maven-tasks">
+  <target name="-run-maven-build" depends="install-maven-tasks,resolve-groovy">
     <!-- we load all user properties from files again using a prefix, to only pass those down, not all of Ant: -->
     <property file="${user.home}/lucene.build.properties" prefix="m2userprop."/>
     <property file="${user.home}/build.properties" prefix="m2userprop."/>
     <property file="${common.dir}/build.properties" prefix="m2userprop."/>
-    <mvn xmlns="antlib:org.apache.maven.artifact.ant" pom="${maven-build-dir}/pom.xml"
-      mavenVersion="${maven-version}" failonerror="true" fork="true">
-      <arg value="-fae"/>
-      <arg value="install"/>
-      <syspropertyset>
+    <propertyset id="maven.exec.properties">
+      <propertyset>
         <propertyref prefix="m2userprop."/>
         <mapper type="glob" from="m2userprop.*" to="*"/>
-      </syspropertyset>
+      </propertyset>
       <!-- order is important: later ones override previous ones (against common Ant behaviour): -->
-      <syspropertyset>
+      <propertyset>
         <propertyref builtin="commandline"/>
-      </syspropertyset>
-    </mvn>
+      </propertyset>
+    </propertyset>
+    <!-- execute Maven using maven-ant-tasks, passing all collected properties as -D args: -->
+    <groovy><![CDATA[
+      import groovy.xml.NamespaceBuilder;
+      def pomFile = properties['maven-build-dir']+'/pom.xml';
+      def artifact = NamespaceBuilder.newInstance(ant, 'antlib:org.apache.maven.artifact.ant');
+      artifact.mvn(pom:pomFile, mavenVersion:properties['maven-version'], failonerror:true, fork:true) {
+        project.getReference('maven.exec.properties').properties.each { k, v ->
+          if (!k.startsWith('ant.')) { // filter internal ant properties
+            arg(value: '-D' + k + '=' + v);
+          }
+        };
+        arg(value:'-fae');
+        arg(value:'install');
+      };
+    ]]></groovy>
   </target>
 
   <target name="-check-svn-working-copy" depends="ivy-availability-check,ivy-fail,ivy-configure,resolve-groovy">