diff --git a/solr/CHANGES.txt b/solr/CHANGES.txt index 32c8ae2e7fa..bb8f86d3f24 100644 --- a/solr/CHANGES.txt +++ b/solr/CHANGES.txt @@ -178,6 +178,8 @@ Other Changes * SOLR-12423: Upgrade to Tika 1.19.1 when available (Tim Allison via Erick Erickson) +* SOLR-12793: Move TestCloudJSONFacetJoinDomain amd TestCloudJSONFacetSKG to the facet test package (Varun Thacker) + Bug Fixes ---------------------- diff --git a/solr/core/src/test/org/apache/solr/search/facet/DebugAgg.java b/solr/core/src/test/org/apache/solr/search/facet/DebugAgg.java index 9de0d121f9e..a6611984c49 100644 --- a/solr/core/src/test/org/apache/solr/search/facet/DebugAgg.java +++ b/solr/core/src/test/org/apache/solr/search/facet/DebugAgg.java @@ -32,7 +32,7 @@ import org.apache.solr.search.SyntaxError; import org.apache.solr.search.ValueSourceParser; -public class DebugAgg extends AggValueSource { +class DebugAgg extends AggValueSource { public static AtomicLong parses = new AtomicLong(0); public static class Parser extends ValueSourceParser { diff --git a/solr/core/src/test/org/apache/solr/cloud/TestCloudJSONFacetJoinDomain.java b/solr/core/src/test/org/apache/solr/search/facet/TestCloudJSONFacetJoinDomain.java similarity index 99% rename from solr/core/src/test/org/apache/solr/cloud/TestCloudJSONFacetJoinDomain.java rename to solr/core/src/test/org/apache/solr/search/facet/TestCloudJSONFacetJoinDomain.java index 150a08d9367..91b912f7fd4 100644 --- a/solr/core/src/test/org/apache/solr/cloud/TestCloudJSONFacetJoinDomain.java +++ b/solr/core/src/test/org/apache/solr/search/facet/TestCloudJSONFacetJoinDomain.java @@ -14,7 +14,7 @@ * See the License for the specific language governing permissions and * limitations under the License. */ -package org.apache.solr.cloud; +package org.apache.solr.search.facet; import java.io.IOException; import java.lang.invoke.MethodHandles; @@ -39,12 +39,14 @@ import org.apache.solr.client.solrj.impl.HttpSolrClient; import org.apache.solr.client.solrj.request.CollectionAdminRequest; import org.apache.solr.client.solrj.request.QueryRequest; import org.apache.solr.client.solrj.response.QueryResponse; +import org.apache.solr.cloud.AbstractDistribZkTestBase; +import org.apache.solr.cloud.SolrCloudTestCase; +import org.apache.solr.cloud.TestCloudPivotFacet; import org.apache.solr.common.SolrException; import org.apache.solr.common.SolrInputDocument; import org.apache.solr.common.params.ModifiableSolrParams; import org.apache.solr.common.params.SolrParams; import org.apache.solr.common.util.NamedList; -import org.apache.solr.search.facet.FacetField; import org.junit.AfterClass; import org.junit.BeforeClass; import org.slf4j.Logger; diff --git a/solr/core/src/test/org/apache/solr/cloud/TestCloudJSONFacetSKG.java b/solr/core/src/test/org/apache/solr/search/facet/TestCloudJSONFacetSKG.java similarity index 99% rename from solr/core/src/test/org/apache/solr/cloud/TestCloudJSONFacetSKG.java rename to solr/core/src/test/org/apache/solr/search/facet/TestCloudJSONFacetSKG.java index 24384cc42e5..e2129935adb 100644 --- a/solr/core/src/test/org/apache/solr/cloud/TestCloudJSONFacetSKG.java +++ b/solr/core/src/test/org/apache/solr/search/facet/TestCloudJSONFacetSKG.java @@ -14,7 +14,7 @@ * See the License for the specific language governing permissions and * limitations under the License. */ -package org.apache.solr.cloud; +package org.apache.solr.search.facet; import java.io.IOException; import java.lang.invoke.MethodHandles; @@ -40,10 +40,11 @@ import org.apache.solr.client.solrj.impl.HttpSolrClient; import org.apache.solr.client.solrj.request.CollectionAdminRequest; import org.apache.solr.client.solrj.request.QueryRequest; import org.apache.solr.client.solrj.response.QueryResponse; +import org.apache.solr.cloud.AbstractDistribZkTestBase; +import org.apache.solr.cloud.SolrCloudTestCase; import org.apache.solr.common.SolrInputDocument; import org.apache.solr.common.params.SolrParams; import org.apache.solr.common.util.NamedList; -import org.apache.solr.search.facet.FacetField; import static org.apache.solr.search.facet.RelatednessAgg.computeRelatedness; import static org.apache.solr.search.facet.RelatednessAgg.roundTo5Digits; @@ -91,7 +92,7 @@ public class TestCloudJSONFacetSKG extends SolrCloudTestCase { private static final String[] STR_FIELD_SUFFIXES = new String[] { "_ss", "_sds", "_sdsS" }; /** Multivalued int field suffixes that can be randomized for testing diff facet/join code paths */ private static final String[] INT_FIELD_SUFFIXES = new String[] { "_is", "_ids", "_idsS" }; - + /** A basic client for operations at the cloud level, default collection will be set */ private static CloudSolrClient CLOUD_CLIENT; /** One client per node */