mirror of https://github.com/apache/lucene.git
Fix points writing with no values (#13378)
This commit updates the writer to handle the case where there are no values. Previously (before #13369), there was a check that there were some points values before trying to write, this is no longer the case. The code in writeFieldNDims has an assumption that the values is not empty - an empty values will result in calculating a negative number of splits, and a negate array size to hold the splits. The fix is trivial, return null when values is empty - null is an allowable return value from this method. Note: writeField1Dim is able to handle an empty values.
This commit is contained in:
parent
b1d3c08619
commit
731cecf730
|
@ -370,6 +370,8 @@ Bug Fixes
|
||||||
* GITHUB#13369: Fix NRT opening failure when soft deletes are enabled and the document fails to index before a point
|
* GITHUB#13369: Fix NRT opening failure when soft deletes are enabled and the document fails to index before a point
|
||||||
field is written (Ben Trent)
|
field is written (Ben Trent)
|
||||||
|
|
||||||
|
* GITHUB#13378: Fix points writing with no values (Chris Hegarty)
|
||||||
|
|
||||||
Build
|
Build
|
||||||
---------------------
|
---------------------
|
||||||
|
|
||||||
|
|
|
@ -513,6 +513,10 @@ public class BKDWriter implements Closeable {
|
||||||
|
|
||||||
pointCount = values.size();
|
pointCount = values.size();
|
||||||
|
|
||||||
|
if (pointCount == 0) {
|
||||||
|
return null;
|
||||||
|
}
|
||||||
|
|
||||||
final int numLeaves =
|
final int numLeaves =
|
||||||
Math.toIntExact((pointCount + config.maxPointsInLeafNode - 1) / config.maxPointsInLeafNode);
|
Math.toIntExact((pointCount + config.maxPointsInLeafNode - 1) / config.maxPointsInLeafNode);
|
||||||
final int numSplits = numLeaves - 1;
|
final int numSplits = numLeaves - 1;
|
||||||
|
|
|
@ -2338,6 +2338,8 @@ public class TestIndexWriterExceptions extends LuceneTestCase {
|
||||||
LeafReader onlyReader = getOnlyLeafReader(r);
|
LeafReader onlyReader = getOnlyLeafReader(r);
|
||||||
// we mark the failed doc as deleted
|
// we mark the failed doc as deleted
|
||||||
assertEquals(onlyReader.numDeletedDocs(), 1);
|
assertEquals(onlyReader.numDeletedDocs(), 1);
|
||||||
|
// there are not points values (rather than an empty set of values)
|
||||||
|
assertNull(onlyReader.getPointValues("field"));
|
||||||
onlyReader.close();
|
onlyReader.close();
|
||||||
w.close();
|
w.close();
|
||||||
dir.close();
|
dir.close();
|
||||||
|
|
Loading…
Reference in New Issue