Apache/lucene
1
0
Fork 0
mirror of https://github.com/apache/lucene.git synced 2025-02-24 03:05:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

SOLR-14523: Enhance gradle logging calls validation: eliminate getMessage(). Added Gradle validation check.

Browse Source
This commit is contained in:
Erick Erickson 2020-07-04 09:38:41 -04:00
parent c3d6a8bf7a
commit 743234ed83
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
gradle/validation/validate-log-calls.gradle
View File

@ -134,7 +134,10 @@ class ValidateLogCallsTask extends DefaultTask {
violation = true
}
}
if (stripped.contains("getMessage()") || stripped.contains("getCause()")) {
cause = "getMessage or getCause in log line";
violation = true;
}
if (violation) {
reportViolation(String.format("cause: '%s' Suspicious logging call, Parameterize and possibly surround with 'if (log.is*Enabled) {..}'. Help at: 'gradlew helpValidateLogCalls' %s %s:%d"
, cause , System.lineSeparator, file.getAbsolutePath(), lineNumber))