Apache
/
lucene
mirror of https://github.com/apache/lucene.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

SOLR-13783: Add space after comma in NamedList.toString() (#979)

This commit is contained in:
Chris Hennick 2019-10-28 17:09:08 -07:00 committed by Tomas Fernandez Lobbe
parent ee82e4567f
commit 74333c3af2
3 changed files with 15 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
solr/CHANGES.txt
View File

@ -31,6 +31,10 @@ Jetty 9.4.19.v20190610
Upgrade Notes
----------------------
* SOLR-13783: In situations where a NamedList must be output as plain text, commas between key-value pairs will now be
followed by a space (e.g. {shape=square, color=yellow} rather than {shape=square,color=yellow}) for consistency with
other java.util.Map implementations based on AbstractMap (Chris Hennick).
* LUCENE-8738: Move to Java 11 as minimum Java version.
(Adrien Grand, Uwe Schindler)

2
solr/solrj/src/java/org/apache/solr/common/util/NamedList.java
View File

@ -401,7 +401,7 @@ public class NamedList<T> implements Cloneable, Serializable, Iterable<Map.Entry
sb.append('{');
int sz = size();
for (int i=0; i<sz; i++) {
if (i != 0) sb.append(',');
if (i != 0) sb.append(", ");
sb.append(getName(i));
sb.append('=');
sb.append(getVal(i));

10
solr/solrj/src/test/org/apache/solr/common/util/NamedListTest.java
View File

@ -26,6 +26,16 @@ import org.junit.Test;
public class NamedListTest extends SolrTestCase {
@Test
public void testToString() {
NamedList<String> nl = new NamedList<>();
assertEquals("{}", nl.toString());
nl.add("key1", "value1");
assertEquals("{key1=value1}", nl.toString());
nl.add("key2", "value2");
assertEquals("{key1=value1, key2=value2}", nl.toString());
}
public void testRemove() {
NamedList<String> nl = new NamedList<>();
nl.add("key1", "value1");