diff --git a/solr/CHANGES.txt b/solr/CHANGES.txt index 4e4a34b4e32..911834ee74a 100644 --- a/solr/CHANGES.txt +++ b/solr/CHANGES.txt @@ -207,6 +207,9 @@ Other Changes * SOLR-14641: PeerSync, remove canHandleVersionRanges check (Cao Manh Dat) +* SOLR-14731: Rename @SolrSingleThreaded to @SolrThreadUnsafe, mark DistribPackageStore with the annotation + (marcussorealheis) + ================== 8.6.1 ================== Bug Fixes diff --git a/solr/core/src/java/org/apache/solr/filestore/DistribPackageStore.java b/solr/core/src/java/org/apache/solr/filestore/DistribPackageStore.java index 021729feaeb..37aaeb2b050 100644 --- a/solr/core/src/java/org/apache/solr/filestore/DistribPackageStore.java +++ b/solr/core/src/java/org/apache/solr/filestore/DistribPackageStore.java @@ -47,6 +47,7 @@ import org.apache.solr.common.cloud.SolrZkClient; import org.apache.solr.common.cloud.ZkStateReader; import org.apache.solr.common.params.CommonParams; import org.apache.solr.common.util.Utils; +import org.apache.solr.common.annotation.SolrThreadUnsafe; import org.apache.solr.core.CoreContainer; import org.apache.solr.filestore.PackageStoreAPI.MetaData; import org.apache.solr.util.SimplePostTool; @@ -60,7 +61,7 @@ import static java.nio.charset.StandardCharsets.UTF_8; import static org.apache.solr.common.SolrException.ErrorCode.BAD_REQUEST; import static org.apache.solr.common.SolrException.ErrorCode.SERVER_ERROR; - +@SolrThreadUnsafe public class DistribPackageStore implements PackageStore { static final long MAX_PKG_SIZE = Long.parseLong(System.getProperty("max.file.store.size", String.valueOf(100 * 1024 * 1024))); /** @@ -636,4 +637,4 @@ public class DistribPackageStore implements PackageStore { log.error("", e); } } -} \ No newline at end of file +} diff --git a/solr/core/src/java/org/apache/solr/handler/component/HttpShardHandler.java b/solr/core/src/java/org/apache/solr/handler/component/HttpShardHandler.java index f33b783dc72..5aa80120ab0 100644 --- a/solr/core/src/java/org/apache/solr/handler/component/HttpShardHandler.java +++ b/solr/core/src/java/org/apache/solr/handler/component/HttpShardHandler.java @@ -38,7 +38,7 @@ import org.apache.solr.client.solrj.util.AsyncListener; import org.apache.solr.cloud.CloudDescriptor; import org.apache.solr.cloud.ZkController; import org.apache.solr.common.SolrException; -import org.apache.solr.common.annotation.SolrSingleThreaded; +import org.apache.solr.common.annotation.SolrThreadUnsafe; import org.apache.solr.common.cloud.Replica; import org.apache.solr.common.cloud.ZkCoreNodeProps; import org.apache.solr.common.params.CommonParams; @@ -52,7 +52,7 @@ import org.apache.solr.request.SolrRequestInfo; import org.apache.solr.util.tracing.GlobalTracer; import org.apache.solr.util.tracing.SolrRequestCarrier; -@SolrSingleThreaded +@SolrThreadUnsafe public class HttpShardHandler extends ShardHandler { /** * If the request context map has an entry with this key and Boolean.TRUE as value, diff --git a/solr/solrj/src/java/org/apache/solr/common/annotation/SolrSingleThreaded.java b/solr/solrj/src/java/org/apache/solr/common/annotation/SolrThreadUnsafe.java similarity index 96% rename from solr/solrj/src/java/org/apache/solr/common/annotation/SolrSingleThreaded.java rename to solr/solrj/src/java/org/apache/solr/common/annotation/SolrThreadUnsafe.java index 3845468ef4d..7316237b615 100644 --- a/solr/solrj/src/java/org/apache/solr/common/annotation/SolrSingleThreaded.java +++ b/solr/solrj/src/java/org/apache/solr/common/annotation/SolrThreadUnsafe.java @@ -29,6 +29,6 @@ import java.lang.annotation.Target; @Documented @Retention(SOURCE) @Target(TYPE) -public @interface SolrSingleThreaded { +public @interface SolrThreadUnsafe { }