Apache
/
lucene
mirror of https://github.com/apache/lucene.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix edge case in TestJoinUtil 

TestJoinUtil.checkBoost() needs to check to see if there are
any results to validate, otherwise we can get an array-out-of-bounds
exception
This commit is contained in:
Alan Woodward 2023-06-26 13:16:55 +01:00
parent 4fec812cc5
commit 79e8c9c8b9
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
lucene/join/src/test/org/apache/lucene/search/join/TestJoinUtil.java
View File

@ -540,6 +540,7 @@ public class TestJoinUtil extends LuceneTestCase {
String id = searcher.storedFields().document(scoreDoc.doc).get("id");
assertEquals(lowestScoresPerParent.get(id), scoreDoc.score, 0f);
}
checkBoost(joinQuery, searcher);
joinQuery =
JoinUtil.createJoinQuery(
@ -551,6 +552,7 @@ public class TestJoinUtil extends LuceneTestCase {
String id = searcher.storedFields().document(scoreDoc.doc).get("id");
assertEquals(highestScoresPerParent.get(id), scoreDoc.score, 0f);
}
checkBoost(joinQuery, searcher);
searcher.getIndexReader().close();
dir.close();
@ -1052,6 +1054,9 @@ public class TestJoinUtil extends LuceneTestCase {
private void checkBoost(Query query, IndexSearcher searcher) throws IOException {
TopDocs result = searcher.search(query, 10);
if (result.scoreDocs.length == 0) {
return;
}
Query boostedQuery = new BoostQuery(query, 10);
TopDocs boostedResult = searcher.search(boostedQuery, 10);
assertEquals(result.scoreDocs[0].score * 10, boostedResult.scoreDocs[0].score, 0.000001f);