From 7a43dc743292caed082ba994b6c9fa1fa6994273 Mon Sep 17 00:00:00 2001 From: Uwe Schindler Date: Sun, 25 Mar 2012 15:30:53 +0000 Subject: [PATCH] Move DocSetBase to a separate Java file to prevent compile failures on partially updated source files git-svn-id: https://svn.apache.org/repos/asf/lucene/dev/trunk@1305061 13f79535-47bb-0310-9956-ffa450edef68 --- .../java/org/apache/solr/search/DocSet.java | 194 +---------------- .../org/apache/solr/search/DocSetBase.java | 206 ++++++++++++++++++ 2 files changed, 208 insertions(+), 192 deletions(-) create mode 100644 solr/core/src/java/org/apache/solr/search/DocSetBase.java diff --git a/solr/core/src/java/org/apache/solr/search/DocSet.java b/solr/core/src/java/org/apache/solr/search/DocSet.java index d15e14b2979..bc47b3868a4 100644 --- a/solr/core/src/java/org/apache/solr/search/DocSet.java +++ b/solr/core/src/java/org/apache/solr/search/DocSet.java @@ -17,18 +17,9 @@ package org.apache.solr.search; -import org.apache.lucene.index.AtomicReader; -import org.apache.solr.common.SolrException; -import org.apache.lucene.util.Bits; -import org.apache.lucene.util.OpenBitSet; -import org.apache.lucene.search.DocIdSet; import org.apache.lucene.search.Filter; -import org.apache.lucene.search.DocIdSetIterator; -import org.apache.lucene.search.BitsFilteredDocIdSet; -import org.apache.lucene.index.IndexReader; -import org.apache.lucene.index.AtomicReaderContext; - -import java.io.IOException; +import org.apache.lucene.util.OpenBitSet; +import org.apache.solr.common.SolrException; /** * DocSet represents an unordered set of Lucene Document Ids. @@ -161,184 +152,3 @@ public interface DocSet /* extends Collection */ { public static DocSet EMPTY = new SortedIntDocSet(new int[0], 0); } - -/** A base class that may be usefull for implementing DocSets */ -abstract class DocSetBase implements DocSet { - - // Not implemented efficiently... for testing purposes only - @Override - public boolean equals(Object obj) { - if (!(obj instanceof DocSet)) return false; - DocSet other = (DocSet)obj; - if (this.size() != other.size()) return false; - - if (this instanceof DocList && other instanceof DocList) { - // compare ordering - DocIterator i1=this.iterator(); - DocIterator i2=other.iterator(); - while(i1.hasNext() && i2.hasNext()) { - if (i1.nextDoc() != i2.nextDoc()) return false; - } - return true; - // don't compare matches - } - - // if (this.size() != other.size()) return false; - return this.getBits().equals(other.getBits()); - } - - /** - * @throws SolrException Base implementation does not allow modifications - */ - public void add(int doc) { - throw new SolrException( SolrException.ErrorCode.SERVER_ERROR,"Unsupported Operation"); - } - - /** - * @throws SolrException Base implementation does not allow modifications - */ - public void addUnique(int doc) { - throw new SolrException( SolrException.ErrorCode.SERVER_ERROR,"Unsupported Operation"); - } - - /** - * Inefficient base implementation. - * - * @see BitDocSet#getBits - */ - public OpenBitSet getBits() { - OpenBitSet bits = new OpenBitSet(); - for (DocIterator iter = iterator(); iter.hasNext();) { - bits.set(iter.nextDoc()); - } - return bits; - }; - - public DocSet intersection(DocSet other) { - // intersection is overloaded in the smaller DocSets to be more - // efficient, so dispatch off of it instead. - if (!(other instanceof BitDocSet)) { - return other.intersection(this); - } - - // Default... handle with bitsets. - OpenBitSet newbits = (OpenBitSet)(this.getBits().clone()); - newbits.and(other.getBits()); - return new BitDocSet(newbits); - } - - public boolean intersects(DocSet other) { - // intersection is overloaded in the smaller DocSets to be more - // efficient, so dispatch off of it instead. - if (!(other instanceof BitDocSet)) { - return other.intersects(this); - } - // less efficient way: get the intersection size - return intersectionSize(other) > 0; - } - - - public DocSet union(DocSet other) { - OpenBitSet newbits = (OpenBitSet)(this.getBits().clone()); - newbits.or(other.getBits()); - return new BitDocSet(newbits); - } - - public int intersectionSize(DocSet other) { - // intersection is overloaded in the smaller DocSets to be more - // efficient, so dispatch off of it instead. - if (!(other instanceof BitDocSet)) { - return other.intersectionSize(this); - } - // less efficient way: do the intersection then get it's size - return intersection(other).size(); - } - - public int unionSize(DocSet other) { - return this.size() + other.size() - this.intersectionSize(other); - } - - public DocSet andNot(DocSet other) { - OpenBitSet newbits = (OpenBitSet)(this.getBits().clone()); - newbits.andNot(other.getBits()); - return new BitDocSet(newbits); - } - - public int andNotSize(DocSet other) { - return this.size() - this.intersectionSize(other); - } - - public Filter getTopFilter() { - final OpenBitSet bs = getBits(); - - return new Filter() { - @Override - public DocIdSet getDocIdSet(final AtomicReaderContext context, Bits acceptDocs) throws IOException { - AtomicReader reader = context.reader(); - // all Solr DocSets that are used as filters only include live docs - final Bits acceptDocs2 = acceptDocs == null ? null : (reader.getLiveDocs() == acceptDocs ? null : acceptDocs); - - if (context.isTopLevel) { - return BitsFilteredDocIdSet.wrap(bs, acceptDocs); - } - - final int base = context.docBase; - final int maxDoc = reader.maxDoc(); - final int max = base + maxDoc; // one past the max doc in this segment. - - return BitsFilteredDocIdSet.wrap(new DocIdSet() { - @Override - public DocIdSetIterator iterator() throws IOException { - return new DocIdSetIterator() { - int pos=base-1; - int adjustedDoc=-1; - - @Override - public int docID() { - return adjustedDoc; - } - - @Override - public int nextDoc() throws IOException { - pos = bs.nextSetBit(pos+1); - return adjustedDoc = (pos>=0 && pos=0 && pos 0; + } + + + public DocSet union(DocSet other) { + OpenBitSet newbits = (OpenBitSet)(this.getBits().clone()); + newbits.or(other.getBits()); + return new BitDocSet(newbits); + } + + public int intersectionSize(DocSet other) { + // intersection is overloaded in the smaller DocSets to be more + // efficient, so dispatch off of it instead. + if (!(other instanceof BitDocSet)) { + return other.intersectionSize(this); + } + // less efficient way: do the intersection then get it's size + return intersection(other).size(); + } + + public int unionSize(DocSet other) { + return this.size() + other.size() - this.intersectionSize(other); + } + + public DocSet andNot(DocSet other) { + OpenBitSet newbits = (OpenBitSet)(this.getBits().clone()); + newbits.andNot(other.getBits()); + return new BitDocSet(newbits); + } + + public int andNotSize(DocSet other) { + return this.size() - this.intersectionSize(other); + } + + public Filter getTopFilter() { + final OpenBitSet bs = getBits(); + + return new Filter() { + @Override + public DocIdSet getDocIdSet(final AtomicReaderContext context, Bits acceptDocs) throws IOException { + AtomicReader reader = context.reader(); + // all Solr DocSets that are used as filters only include live docs + final Bits acceptDocs2 = acceptDocs == null ? null : (reader.getLiveDocs() == acceptDocs ? null : acceptDocs); + + if (context.isTopLevel) { + return BitsFilteredDocIdSet.wrap(bs, acceptDocs); + } + + final int base = context.docBase; + final int maxDoc = reader.maxDoc(); + final int max = base + maxDoc; // one past the max doc in this segment. + + return BitsFilteredDocIdSet.wrap(new DocIdSet() { + @Override + public DocIdSetIterator iterator() throws IOException { + return new DocIdSetIterator() { + int pos=base-1; + int adjustedDoc=-1; + + @Override + public int docID() { + return adjustedDoc; + } + + @Override + public int nextDoc() throws IOException { + pos = bs.nextSetBit(pos+1); + return adjustedDoc = (pos>=0 && pos=0 && pos