From 7af83c486b50ceb13d58e79dd65c158bc96130dc Mon Sep 17 00:00:00 2001 From: Mike McCandless Date: Wed, 3 Feb 2016 16:45:46 -0500 Subject: [PATCH] add nocommit; try to fix false test failure due to concurrent check index running while primary is still closing --- .../test/org/apache/lucene/replicator/nrt/NodeProcess.java | 4 +--- .../org/apache/lucene/replicator/nrt/TestNRTReplication.java | 2 ++ 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lucene/replicator/src/test/org/apache/lucene/replicator/nrt/NodeProcess.java b/lucene/replicator/src/test/org/apache/lucene/replicator/nrt/NodeProcess.java index dcbef87aa1f..be0b3df3336 100644 --- a/lucene/replicator/src/test/org/apache/lucene/replicator/nrt/NodeProcess.java +++ b/lucene/replicator/src/test/org/apache/lucene/replicator/nrt/NodeProcess.java @@ -157,9 +157,7 @@ class NodeProcess implements Closeable { throw new RuntimeException("shutdown failed"); } } catch (Throwable t) { - System.out.println("top: shutdown failed; skipping"); - t.printStackTrace(System.out); - return false; + System.out.println("top: shutdown failed; ignoring"); } try { p.waitFor(); diff --git a/lucene/replicator/src/test/org/apache/lucene/replicator/nrt/TestNRTReplication.java b/lucene/replicator/src/test/org/apache/lucene/replicator/nrt/TestNRTReplication.java index b2240ebc955..510a0759e40 100644 --- a/lucene/replicator/src/test/org/apache/lucene/replicator/nrt/TestNRTReplication.java +++ b/lucene/replicator/src/test/org/apache/lucene/replicator/nrt/TestNRTReplication.java @@ -37,6 +37,8 @@ import org.apache.lucene.util.LuceneTestCase.SuppressSysoutChecks; import com.carrotsearch.randomizedtesting.SeedUtils; +// nocommit make some explicit failure tests + // MockRandom's .sd file has no index header/footer: @SuppressCodecs({"MockRandom", "Memory", "Direct", "SimpleText"}) @SuppressSysoutChecks(bugUrl = "Stuff gets printed, important stuff for debugging a failure")