Apache
/
lucene
mirror of https://github.com/apache/lucene.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

SOLR-12395: Remove SignificantTermsQParserPlugin's deprecated old name ('sigificantTerms') in favour of new 'significantTerms' name

This commit is contained in:
Christine Poerschke 2018-07-04 12:02:01 +01:00
parent 799d2acd88
commit 7b2a2d989c
5 changed files with 0 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
solr/core/src/java/org/apache/solr/search/QParserPlugin.java
View File

@ -80,7 +80,6 @@ public abstract class QParserPlugin implements NamedListInitializedPlugin, SolrI
map.put(GraphTermsQParserPlugin.NAME, new GraphTermsQParserPlugin());
map.put(IGainTermsQParserPlugin.NAME, new IGainTermsQParserPlugin());
map.put(TextLogisticRegressionQParserPlugin.NAME, new TextLogisticRegressionQParserPlugin());
map.put(SignificantTermsQParserPlugin.OLD_NAME, new SignificantTermsQParserPlugin()); // for Solr 7.x backcompat only
map.put(SignificantTermsQParserPlugin.NAME, new SignificantTermsQParserPlugin());
map.put(PayloadScoreQParserPlugin.NAME, new PayloadScoreQParserPlugin());
map.put(PayloadCheckQParserPlugin.NAME, new PayloadCheckQParserPlugin());

3
solr/core/src/java/org/apache/solr/search/SignificantTermsQParserPlugin.java
View File

@ -39,9 +39,6 @@ import org.apache.solr.request.SolrQueryRequest;
public class SignificantTermsQParserPlugin extends QParserPlugin {
@Deprecated
public static final String OLD_NAME = "sigificantTerms";
public static final String NAME = "significantTerms";
@Override

4
solr/core/src/test/org/apache/solr/search/QueryEqualityTest.java
View File

@ -190,10 +190,6 @@ public class QueryEqualityTest extends SolrTestCaseJ4 {
public void testSignificantTermsQuery() throws Exception {
SolrQueryRequest req = req("q", "*:*");
try {
// for Solr 7.x backcompat only
assertQueryEquals(SignificantTermsQParserPlugin.OLD_NAME,
req, "{!"+SignificantTermsQParserPlugin.OLD_NAME+"}");
assertQueryEquals(SignificantTermsQParserPlugin.NAME,
req, "{!"+SignificantTermsQParserPlugin.NAME+"}");
} finally {

5
solr/core/src/test/org/apache/solr/search/SignificantTermsQParserPluginTest.java
View File

@ -28,11 +28,6 @@ public class SignificantTermsQParserPluginTest extends LuceneTestCase {
*/
@Test
public void testQParserBackwardsCompatibility() {
// for Solr 7.x backcompat only
assertEquals("sigificantTerms", SignificantTermsQParserPlugin.OLD_NAME);
assertEquals(SignificantTermsQParserPlugin.class,
QParserPlugin.standardPlugins.get(SignificantTermsQParserPlugin.OLD_NAME).getClass());
assertEquals("significantTerms", SignificantTermsQParserPlugin.NAME);
assertEquals(SignificantTermsQParserPlugin.class,
QParserPlugin.standardPlugins.get(SignificantTermsQParserPlugin.NAME).getClass());

5
solr/core/src/test/org/apache/solr/search/TestStandardQParsers.java
View File

@ -66,11 +66,6 @@ public class TestStandardQParsers extends LuceneTestCase {
}
}
// for Solr 7.x backcompat only
mismatch.remove(SignificantTermsQParserPlugin.OLD_NAME
+ " != " + SignificantTermsQParserPlugin.NAME
+ "(" + SignificantTermsQParserPlugin.class.getName() + ")");
assertTrue("All standard QParsers must have final NAME, broken: " + notFinal,
notFinal.isEmpty());
assertTrue("All standard QParsers must have static NAME, broken: " + notStatic,