Fix container inefficiencies in FieldInfos.java (#13254)

This commit is contained in:
cinsttool 2024-04-02 20:12:17 +08:00 committed by GitHub
parent baecaf556f
commit 7c3ee797a9
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194

View File

@ -24,7 +24,6 @@ import static org.apache.lucene.index.FieldInfo.verifySameStoreTermVectors;
import static org.apache.lucene.index.FieldInfo.verifySameVectorOptions; import static org.apache.lucene.index.FieldInfo.verifySameVectorOptions;
import java.util.ArrayList; import java.util.ArrayList;
import java.util.Arrays;
import java.util.Collection; import java.util.Collection;
import java.util.Collections; import java.util.Collections;
import java.util.HashMap; import java.util.HashMap;
@ -157,7 +156,7 @@ public class FieldInfos implements Iterable<FieldInfo> {
this.softDeletesField = softDeletesField; this.softDeletesField = softDeletesField;
this.parentField = parentField; this.parentField = parentField;
List<FieldInfo> valuesTemp = new ArrayList<>(); List<FieldInfo> valuesTemp = new ArrayList<>(infos.length);
byNumber = new FieldInfo[size]; byNumber = new FieldInfo[size];
for (int i = 0; i < size; i++) { for (int i = 0; i < size; i++) {
byNumber[i] = byNumberTemp[i]; byNumber[i] = byNumberTemp[i];
@ -165,8 +164,7 @@ public class FieldInfos implements Iterable<FieldInfo> {
valuesTemp.add(byNumberTemp[i]); valuesTemp.add(byNumberTemp[i]);
} }
} }
values = values = Collections.unmodifiableCollection(valuesTemp);
Collections.unmodifiableCollection(Arrays.asList(valuesTemp.toArray(new FieldInfo[0])));
} }
/** /**