Apache
/
lucene
mirror of https://github.com/apache/lucene.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

LUCENE-1339: make IndexReader incRef and decRef expert public methods 

git-svn-id: https://svn.apache.org/repos/asf/lucene/java/trunk@678716 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Michael McCandless 2008-07-22 11:14:36 +00:00
parent 7198ead131
commit 7c842e3c34
2 changed files with 24 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
src/java/org/apache/lucene/index/IndexReader.java
View File

@ -102,23 +102,38 @@ public abstract class IndexReader {
} }
/** /**
* Increments the refCount of this IndexReader instance. RefCounts are used to determine * Expert: increments the refCount of this IndexReader
* when a reader can be closed safely, i. e. as soon as no other IndexReader is referencing * instance. RefCounts are used to determine when a
* it anymore. * reader can be closed safely, i.e. as soon as there are
* no more references. Be sure to always call a
* corresponding {@link #decRef}, in a finally clause;
* otherwise the reader may never be closed. Note that
* {@link #close} simply calls decRef(), which means that
* the IndexReader will not really be closed until {@link
* #decRef} has been called for all outstanding
* references.
*
* @see #decRef
*/ */
protected synchronized void incRef() { public synchronized void incRef() {
assert refCount > 0; assert refCount > 0;
ensureOpen();
refCount++; refCount++;
} }
/** /**
* Decreases the refCount of this IndexReader instance. If the refCount drops * Expert: decreases the refCount of this IndexReader
* to 0, then pending changes are committed to the index and this reader is closed. * instance. If the refCount drops to 0, then pending
* changes (if any) are committed to the index and this
* reader is closed.
* *
* @throws IOException in case an IOException occurs in commit() or doClose() * @throws IOException in case an IOException occurs in commit() or doClose()
*
* @see #incRef
*/ */
protected synchronized void decRef() throws IOException { public synchronized void decRef() throws IOException {
assert refCount > 0; assert refCount > 0;
ensureOpen();
if (refCount == 1) { if (refCount == 1) {
commit(); commit();
doClose(); doClose();

4
src/java/org/apache/lucene/index/SegmentReader.java
View File

@ -138,7 +138,7 @@ class SegmentReader extends DirectoryIndexReader {
* Increments the RC of this reader, as well as * Increments the RC of this reader, as well as
* of all norms this reader is using * of all norms this reader is using
*/ */
protected synchronized void incRef() { public synchronized void incRef() {
super.incRef(); super.incRef();
Iterator it = norms.values().iterator(); Iterator it = norms.values().iterator();
while (it.hasNext()) { while (it.hasNext()) {
@ -157,7 +157,7 @@ class SegmentReader extends DirectoryIndexReader {
super.incRef(); super.incRef();
} }
protected synchronized void decRef() throws IOException { public synchronized void decRef() throws IOException {
super.decRef(); super.decRef();
Iterator it = norms.values().iterator(); Iterator it = norms.values().iterator();
while (it.hasNext()) { while (it.hasNext()) {