From 7d5d44a3c42797b312310df8a7f4af910e052124 Mon Sep 17 00:00:00 2001 From: Erick Erickson Date: Fri, 6 Dec 2019 19:10:27 -0500 Subject: [PATCH] SOLR-13988: Harden CreateCollectionCleanupTest. Incorporate Dawid Weiss' suggestion for windows --- .../org/apache/solr/cloud/CreateCollectionCleanupTest.java | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/solr/core/src/test/org/apache/solr/cloud/CreateCollectionCleanupTest.java b/solr/core/src/test/org/apache/solr/cloud/CreateCollectionCleanupTest.java index 3f8326cedcd..b8c5b420da5 100644 --- a/solr/core/src/test/org/apache/solr/cloud/CreateCollectionCleanupTest.java +++ b/solr/core/src/test/org/apache/solr/cloud/CreateCollectionCleanupTest.java @@ -21,6 +21,7 @@ import static org.hamcrest.CoreMatchers.hasItem; import static org.hamcrest.CoreMatchers.is; import static org.hamcrest.CoreMatchers.not; +import java.nio.file.Files; import java.nio.file.Path; import java.util.Properties; import org.apache.solr.client.solrj.impl.BaseHttpSolrClient; @@ -78,7 +79,8 @@ public class CreateCollectionCleanupTest extends SolrCloudTestCase { Properties properties = new Properties(); Path tmpDir = createTempDir(); - tmpDir.toFile().setWritable(false); + tmpDir = tmpDir.resolve("foo"); + Files.createFile(tmpDir); properties.put(CoreAdminParams.DATA_DIR, tmpDir.toString()); create.setProperties(properties); expectThrows(BaseHttpSolrClient.RemoteSolrException.class, () -> { @@ -102,7 +104,8 @@ public class CreateCollectionCleanupTest extends SolrCloudTestCase { Properties properties = new Properties(); Path tmpDir = createTempDir(); - tmpDir.toFile().setWritable(false); + tmpDir = tmpDir.resolve("foo"); + Files.createFile(tmpDir); properties.put(CoreAdminParams.DATA_DIR, tmpDir.toString()); create.setProperties(properties); create.setAsyncId("testAsyncCreateCollectionCleanup");