Apache
/
lucene
mirror of https://github.com/apache/lucene.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

LUCENE-8898: Adjust the assertions - when CompressedOops are in use the estimation is less 

accurate because RamUsageEstimator doesn't know the exact layout of data structures used in the map.
This commit is contained in:
Andrzej Bialecki 2019-07-02 15:34:38 +02:00
parent c478193004
commit 7ec41d13e6
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
lucene/core/src/test/org/apache/lucene/util/TestRamUsageEstimator.java
View File

@ -118,7 +118,7 @@ public class TestRamUsageEstimator extends LuceneTestCase {
assertEquals((double)actual, (double)estimated, (double)actual * 0.1);
}
@AwaitsFix(bugUrl="https://issues.apache.org/jira/browse/LUCENE-8898")
//@AwaitsFix(bugUrl="https://issues.apache.org/jira/browse/LUCENE-8898")
public void testMap() {
Map<String, Object> map = new HashMap<>();
map.put("primitive", 1234L);
@ -126,15 +126,16 @@ public class TestRamUsageEstimator extends LuceneTestCase {
for (int i = 0; i < 100; i++) {
map.put("complex " + i, new Term("foo " + i, "bar " + i));
}
double errorFactor = COMPRESSED_REFS_ENABLED ? 0.2 : 0.3;
long actual = sizeOf(map);
long estimated = RamUsageEstimator.sizeOfObject(map);
assertEquals((double)actual, (double)estimated, (double)actual * 0.2);
assertEquals((double)actual, (double)estimated, (double)actual * errorFactor);
// test recursion
map.put("self", map);
actual = sizeOf(map);
estimated = RamUsageEstimator.sizeOfObject(map);
assertEquals((double)actual, (double)estimated, (double)actual * 0.2);
assertEquals((double)actual, (double)estimated, (double)actual * errorFactor);
}
public void testCollection() {