Apache
/
lucene
mirror of https://github.com/apache/lucene.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Don't throw an exception for byte-encoded vectors in SimpleText codec

This commit is contained in:
Michael Sokolov 2022-08-22 08:29:58 -04:00
parent df67223497
commit 8021c2db4e
2 changed files with 0 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
lucene/codecs/src/java/org/apache/lucene/codecs/simpletext/SimpleTextKnnVectorsWriter.java
View File

@ -28,7 +28,6 @@ import org.apache.lucene.index.BufferingKnnVectorsWriter;
import org.apache.lucene.index.FieldInfo; import org.apache.lucene.index.FieldInfo;
import org.apache.lucene.index.IndexFileNames; import org.apache.lucene.index.IndexFileNames;
import org.apache.lucene.index.SegmentWriteState; import org.apache.lucene.index.SegmentWriteState;
import org.apache.lucene.index.VectorEncoding;
import org.apache.lucene.index.VectorValues; import org.apache.lucene.index.VectorValues;
import org.apache.lucene.store.IndexOutput; import org.apache.lucene.store.IndexOutput;
import org.apache.lucene.util.BytesRef; import org.apache.lucene.util.BytesRef;
@ -77,10 +76,6 @@ public class SimpleTextKnnVectorsWriter extends BufferingKnnVectorsWriter {
public void writeField(FieldInfo fieldInfo, KnnVectorsReader knnVectorsReader, int maxDoc) public void writeField(FieldInfo fieldInfo, KnnVectorsReader knnVectorsReader, int maxDoc)
throws IOException { throws IOException {
VectorValues vectors = knnVectorsReader.getVectorValues(fieldInfo.name); VectorValues vectors = knnVectorsReader.getVectorValues(fieldInfo.name);
if (fieldInfo.getVectorEncoding() != VectorEncoding.FLOAT32) {
throw new IllegalArgumentException(
"SimpleText codec does not support vector encoding: " + fieldInfo.getVectorEncoding());
}
long vectorDataOffset = vectorData.getFilePointer(); long vectorDataOffset = vectorData.getFilePointer();
List<Integer> docIds = new ArrayList<>(); List<Integer> docIds = new ArrayList<>();
int docV; int docV;

15
lucene/codecs/src/test/org/apache/lucene/codecs/simpletext/TestSimpleTextKnnVectorsFormat.java
View File

@ -17,12 +17,7 @@
package org.apache.lucene.codecs.simpletext; package org.apache.lucene.codecs.simpletext;
import org.apache.lucene.codecs.Codec; import org.apache.lucene.codecs.Codec;
import org.apache.lucene.document.Document;
import org.apache.lucene.document.KnnVectorField;
import org.apache.lucene.index.IndexWriter;
import org.apache.lucene.index.VectorEncoding; import org.apache.lucene.index.VectorEncoding;
import org.apache.lucene.index.VectorSimilarityFunction;
import org.apache.lucene.store.Directory;
import org.apache.lucene.tests.index.BaseKnnVectorsFormatTestCase; import org.apache.lucene.tests.index.BaseKnnVectorsFormatTestCase;
public class TestSimpleTextKnnVectorsFormat extends BaseKnnVectorsFormatTestCase { public class TestSimpleTextKnnVectorsFormat extends BaseKnnVectorsFormatTestCase {
@ -37,16 +32,6 @@ public class TestSimpleTextKnnVectorsFormat extends BaseKnnVectorsFormatTestCase
return VectorEncoding.FLOAT32; return VectorEncoding.FLOAT32;
} }
public void testUnsupportedEncoding() throws Exception {
try (Directory dir = newDirectory();
IndexWriter iw = new IndexWriter(dir, newIndexWriterConfig())) {
Document doc = new Document();
doc.add(new KnnVectorField("field", newBytesRef(2), VectorSimilarityFunction.DOT_PRODUCT));
iw.addDocument(doc);
expectThrows(IllegalArgumentException.class, () -> iw.commit());
}
}
@Override @Override
public void testRandomBytes() throws Exception { public void testRandomBytes() throws Exception {
// unimplemented // unimplemented