From 809d15115b4588550a3e3eef4796539d9b413600 Mon Sep 17 00:00:00 2001 From: Timothy Potter Date: Wed, 16 Dec 2020 15:35:30 -0700 Subject: [PATCH] SOLR-15054: Test should not require private methods to be final (#2150) --- .../org/apache/solr/core/ConfigureRecoveryStrategyTest.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/solr/core/src/test/org/apache/solr/core/ConfigureRecoveryStrategyTest.java b/solr/core/src/test/org/apache/solr/core/ConfigureRecoveryStrategyTest.java index 0a988f6e747..246ed981137 100644 --- a/solr/core/src/test/org/apache/solr/core/ConfigureRecoveryStrategyTest.java +++ b/solr/core/src/test/org/apache/solr/core/ConfigureRecoveryStrategyTest.java @@ -66,7 +66,7 @@ public class ConfigureRecoveryStrategyTest extends SolrTestCaseJ4 { public void testAlmostAllMethodsAreFinal() throws Exception { for (Method m : RecoveryStrategy.class.getDeclaredMethods()) { - if (Modifier.isStatic(m.getModifiers())) continue; + if (Modifier.isStatic(m.getModifiers()) || Modifier.isPrivate(m.getModifiers())) continue; final String methodName = m.getName(); if ("getReplicateLeaderUrl".equals(methodName)) { assertFalse(m.toString(), Modifier.isFinal(m.getModifiers()));