From 836873d7799c764ee0e8fe7340ce0e0cdb82123f Mon Sep 17 00:00:00 2001 From: Robert Muir Date: Wed, 1 Dec 2010 12:37:01 +0000 Subject: [PATCH] SOLR-2259: use $tests.luceneMatchVersion in all test files, make this parameter mandatory in trunk git-svn-id: https://svn.apache.org/repos/asf/lucene/dev/trunk@1040982 13f79535-47bb-0310-9956-ffa450edef68 --- .../src/test/resources/solr/conf/solrconfig.xml | 1 + .../resources/solr/conf/dataimport-solrconfig.xml | 1 + .../resources/solr/conf/contentstream-solrconfig.xml | 1 + .../solr/conf/dataimport-nodatasource-solrconfig.xml | 1 + .../resources/solr/conf/dataimport-solrconfig.xml | 1 + .../src/test/resources/solr/conf/schema.xml | 12 ++++++------ .../src/test/resources/solr/conf/solrconfig.xml | 2 +- solr/example/multicore/core0/conf/solrconfig.xml | 2 +- solr/example/multicore/core1/conf/solrconfig.xml | 1 + solr/src/java/org/apache/solr/core/SolrConfig.java | 2 +- .../src/test/test-files/solr/conf/bad_solrconfig.xml | 1 + .../test-files/solr/conf/solrconfig-SOLR-749.xml | 2 +- .../test-files/solr/conf/solrconfig-altdirectory.xml | 1 + .../test-files/solr/conf/solrconfig-delpolicy1.xml | 2 +- .../test-files/solr/conf/solrconfig-delpolicy2.xml | 1 + .../test-files/solr/conf/solrconfig-duh-optimize.xml | 2 +- .../test/test-files/solr/conf/solrconfig-elevate.xml | 2 +- .../test-files/solr/conf/solrconfig-enableplugin.xml | 2 +- .../solr/conf/solrconfig-functionquery.xml | 2 +- .../test-files/solr/conf/solrconfig-highlight.xml | 2 +- .../test/test-files/solr/conf/solrconfig-legacy.xml | 2 +- .../test/test-files/solr/conf/solrconfig-master.xml | 2 +- .../test/test-files/solr/conf/solrconfig-master1.xml | 2 +- .../test/test-files/solr/conf/solrconfig-master2.xml | 2 +- .../test/test-files/solr/conf/solrconfig-nocache.xml | 2 +- .../solr/conf/solrconfig-propinject-indexdefault.xml | 2 +- .../test-files/solr/conf/solrconfig-propinject.xml | 2 +- .../test-files/solr/conf/solrconfig-querysender.xml | 1 + .../test/test-files/solr/conf/solrconfig-slave.xml | 2 +- .../test/test-files/solr/conf/solrconfig-slave1.xml | 2 +- .../solr/conf/solrconfig-solcoreproperties.xml | 2 +- .../solr/conf/solrconfig-spellcheckcomponent.xml | 2 +- .../test-files/solr/conf/solrconfig-spellchecker.xml | 2 +- .../test-files/solr/conf/solrconfig-termindex.xml | 2 +- .../test-files/solr/conf/solrconfig-transformers.xml | 2 +- .../test-files/solr/conf/solrconfig-xinclude.xml | 2 +- solr/src/test/test-files/solr/conf/solrconfig.xml | 2 +- .../test/test-files/solr/conf/solrconfig_perf.xml | 1 + .../test/test-files/solr/crazy-path-to-config.xml | 1 + .../test/test-files/solr/shared/conf/solrconfig.xml | 1 + 40 files changed, 45 insertions(+), 32 deletions(-) diff --git a/solr/contrib/clustering/src/test/resources/solr/conf/solrconfig.xml b/solr/contrib/clustering/src/test/resources/solr/conf/solrconfig.xml index 7690974262f..c59cc9b63fd 100644 --- a/solr/contrib/clustering/src/test/resources/solr/conf/solrconfig.xml +++ b/solr/contrib/clustering/src/test/resources/solr/conf/solrconfig.xml @@ -17,6 +17,7 @@ --> + ${tests.luceneMatchVersion:LUCENE_CURRENT} + ${tests.luceneMatchVersion:LUCENE_CURRENT} + ${tests.luceneMatchVersion:LUCENE_CURRENT} + ${tests.luceneMatchVersion:LUCENE_CURRENT} + ${tests.luceneMatchVersion:LUCENE_CURRENT} - - + + @@ -133,7 +133,7 @@ - + @@ -168,14 +168,14 @@ - - + + - + diff --git a/solr/contrib/extraction/src/test/resources/solr/conf/solrconfig.xml b/solr/contrib/extraction/src/test/resources/solr/conf/solrconfig.xml index 4b18605427e..30401b1a320 100644 --- a/solr/contrib/extraction/src/test/resources/solr/conf/solrconfig.xml +++ b/solr/contrib/extraction/src/test/resources/solr/conf/solrconfig.xml @@ -23,7 +23,7 @@ --> - + ${tests.luceneMatchVersion:LUCENE_CURRENT} - + LUCENE_40 diff --git a/solr/example/multicore/core1/conf/solrconfig.xml b/solr/example/multicore/core1/conf/solrconfig.xml index 11be4843e2d..f92d54e8f9c 100644 --- a/solr/example/multicore/core1/conf/solrconfig.xml +++ b/solr/example/multicore/core1/conf/solrconfig.xml @@ -21,6 +21,7 @@ It is *not* a good example to work from. --> + LUCENE_40 diff --git a/solr/src/java/org/apache/solr/core/SolrConfig.java b/solr/src/java/org/apache/solr/core/SolrConfig.java index 0d5e97439f7..6834026645d 100644 --- a/solr/src/java/org/apache/solr/core/SolrConfig.java +++ b/solr/src/java/org/apache/solr/core/SolrConfig.java @@ -138,7 +138,7 @@ public class SolrConfig extends Config { reopenReaders = getBool("mainIndex/reopenReaders", true); booleanQueryMaxClauseCount = getInt("query/maxBooleanClauses", BooleanQuery.getMaxClauseCount()); - luceneMatchVersion = getLuceneVersion("luceneMatchVersion", Version.LUCENE_30); + luceneMatchVersion = getLuceneVersion("luceneMatchVersion"); log.info("Using Lucene MatchVersion: " + luceneMatchVersion); filtOptEnabled = getBool("query/boolTofilterOptimizer/@enabled", false); diff --git a/solr/src/test/test-files/solr/conf/bad_solrconfig.xml b/solr/src/test/test-files/solr/conf/bad_solrconfig.xml index 6f6213ee5d5..b14aad5af2c 100644 --- a/solr/src/test/test-files/solr/conf/bad_solrconfig.xml +++ b/solr/src/test/test-files/solr/conf/bad_solrconfig.xml @@ -23,6 +23,7 @@ --> + ${tests.luceneMatchVersion:LUCENE_CURRENT} ${unset.sys.property} diff --git a/solr/src/test/test-files/solr/conf/solrconfig-SOLR-749.xml b/solr/src/test/test-files/solr/conf/solrconfig-SOLR-749.xml index 1ede86536bb..87687fe43fa 100644 --- a/solr/src/test/test-files/solr/conf/solrconfig-SOLR-749.xml +++ b/solr/src/test/test-files/solr/conf/solrconfig-SOLR-749.xml @@ -23,7 +23,7 @@ --> - + ${tests.luceneMatchVersion:LUCENE_CURRENT} + ${tests.luceneMatchVersion:LUCENE_CURRENT} diff --git a/solr/src/test/test-files/solr/conf/solrconfig-delpolicy1.xml b/solr/src/test/test-files/solr/conf/solrconfig-delpolicy1.xml index 0ba439003d0..3efbb4ee66d 100644 --- a/solr/src/test/test-files/solr/conf/solrconfig-delpolicy1.xml +++ b/solr/src/test/test-files/solr/conf/solrconfig-delpolicy1.xml @@ -23,7 +23,7 @@ --> - + ${tests.luceneMatchVersion:LUCENE_CURRENT} + ${tests.luceneMatchVersion:LUCENE_CURRENT} value1 diff --git a/solr/src/test/test-files/solr/conf/solrconfig-duh-optimize.xml b/solr/src/test/test-files/solr/conf/solrconfig-duh-optimize.xml index 711d9a20128..cff9b91de45 100644 --- a/solr/src/test/test-files/solr/conf/solrconfig-duh-optimize.xml +++ b/solr/src/test/test-files/solr/conf/solrconfig-duh-optimize.xml @@ -23,7 +23,7 @@ --> - + ${tests.luceneMatchVersion:LUCENE_CURRENT} diff --git a/solr/src/test/test-files/solr/conf/solrconfig-elevate.xml b/solr/src/test/test-files/solr/conf/solrconfig-elevate.xml index f08afc9650f..ad74c86908c 100644 --- a/solr/src/test/test-files/solr/conf/solrconfig-elevate.xml +++ b/solr/src/test/test-files/solr/conf/solrconfig-elevate.xml @@ -23,7 +23,7 @@ --> - + ${tests.luceneMatchVersion:LUCENE_CURRENT} - + ${tests.luceneMatchVersion:LUCENE_CURRENT} ${solr.data.dir:./solr/data} - + ${tests.luceneMatchVersion:LUCENE_CURRENT} diff --git a/solr/src/test/test-files/solr/conf/solrconfig-highlight.xml b/solr/src/test/test-files/solr/conf/solrconfig-highlight.xml index b9ae888d013..aca9aba90df 100644 --- a/solr/src/test/test-files/solr/conf/solrconfig-highlight.xml +++ b/solr/src/test/test-files/solr/conf/solrconfig-highlight.xml @@ -23,7 +23,7 @@ --> - + ${tests.luceneMatchVersion:LUCENE_CURRENT} diff --git a/solr/src/test/test-files/solr/conf/solrconfig-legacy.xml b/solr/src/test/test-files/solr/conf/solrconfig-legacy.xml index 37ae72065d4..4ea3bcb52e2 100644 --- a/solr/src/test/test-files/solr/conf/solrconfig-legacy.xml +++ b/solr/src/test/test-files/solr/conf/solrconfig-legacy.xml @@ -37,7 +37,7 @@ --> - + ${tests.luceneMatchVersion:LUCENE_CURRENT} - 4.0 + ${tests.luceneMatchVersion:LUCENE_CURRENT} ${solr.data.dir:./solr/data} diff --git a/solr/src/test/test-files/solr/conf/solrconfig-master1.xml b/solr/src/test/test-files/solr/conf/solrconfig-master1.xml index c227f6371f6..12e4012817c 100644 --- a/solr/src/test/test-files/solr/conf/solrconfig-master1.xml +++ b/solr/src/test/test-files/solr/conf/solrconfig-master1.xml @@ -23,7 +23,7 @@ --> - + ${tests.luceneMatchVersion:LUCENE_CURRENT} ${solr.data.dir:./solr/data} diff --git a/solr/src/test/test-files/solr/conf/solrconfig-master2.xml b/solr/src/test/test-files/solr/conf/solrconfig-master2.xml index f8e94d246fe..79aae444a29 100644 --- a/solr/src/test/test-files/solr/conf/solrconfig-master2.xml +++ b/solr/src/test/test-files/solr/conf/solrconfig-master2.xml @@ -23,7 +23,7 @@ --> - + ${tests.luceneMatchVersion:LUCENE_CURRENT} ${solr.data.dir:./solr/data} diff --git a/solr/src/test/test-files/solr/conf/solrconfig-nocache.xml b/solr/src/test/test-files/solr/conf/solrconfig-nocache.xml index 78a6e180639..7bb80c6e9e6 100644 --- a/solr/src/test/test-files/solr/conf/solrconfig-nocache.xml +++ b/solr/src/test/test-files/solr/conf/solrconfig-nocache.xml @@ -23,7 +23,7 @@ --> - + ${tests.luceneMatchVersion:LUCENE_CURRENT} diff --git a/solr/src/test/test-files/solr/conf/solrconfig-propinject-indexdefault.xml b/solr/src/test/test-files/solr/conf/solrconfig-propinject-indexdefault.xml index ee223f0f868..7a0baeb1a05 100644 --- a/solr/src/test/test-files/solr/conf/solrconfig-propinject-indexdefault.xml +++ b/solr/src/test/test-files/solr/conf/solrconfig-propinject-indexdefault.xml @@ -37,7 +37,7 @@ --> - + ${tests.luceneMatchVersion:LUCENE_CURRENT} - + ${tests.luceneMatchVersion:LUCENE_CURRENT} + ${tests.luceneMatchVersion:LUCENE_CURRENT} diff --git a/solr/src/test/test-files/solr/conf/solrconfig-slave.xml b/solr/src/test/test-files/solr/conf/solrconfig-slave.xml index 9720e3bfb06..88e8a8cbbec 100644 --- a/solr/src/test/test-files/solr/conf/solrconfig-slave.xml +++ b/solr/src/test/test-files/solr/conf/solrconfig-slave.xml @@ -23,7 +23,7 @@ --> - 4.0 + ${tests.luceneMatchVersion:LUCENE_CURRENT} ${solr.data.dir:./solr/data} diff --git a/solr/src/test/test-files/solr/conf/solrconfig-slave1.xml b/solr/src/test/test-files/solr/conf/solrconfig-slave1.xml index 3b9bd5eb096..004c036cf3c 100644 --- a/solr/src/test/test-files/solr/conf/solrconfig-slave1.xml +++ b/solr/src/test/test-files/solr/conf/solrconfig-slave1.xml @@ -23,7 +23,7 @@ --> - + ${tests.luceneMatchVersion:LUCENE_CURRENT} ${solr.data.dir:./solr/data} diff --git a/solr/src/test/test-files/solr/conf/solrconfig-solcoreproperties.xml b/solr/src/test/test-files/solr/conf/solrconfig-solcoreproperties.xml index 4308cf6af4a..0ddce37bf8a 100644 --- a/solr/src/test/test-files/solr/conf/solrconfig-solcoreproperties.xml +++ b/solr/src/test/test-files/solr/conf/solrconfig-solcoreproperties.xml @@ -23,7 +23,7 @@ --> - + ${tests.luceneMatchVersion:LUCENE_CURRENT} ${solr.data.dir:./solr/data} - + ${tests.luceneMatchVersion:LUCENE_CURRENT} diff --git a/solr/src/test/test-files/solr/conf/solrconfig-spellchecker.xml b/solr/src/test/test-files/solr/conf/solrconfig-spellchecker.xml index ece18d8d7b3..f985ee568d2 100644 --- a/solr/src/test/test-files/solr/conf/solrconfig-spellchecker.xml +++ b/solr/src/test/test-files/solr/conf/solrconfig-spellchecker.xml @@ -22,7 +22,7 @@ solr.RAMDirectoryFactory is memory based and not persistent. --> - 4.0 + ${tests.luceneMatchVersion:LUCENE_CURRENT} false diff --git a/solr/src/test/test-files/solr/conf/solrconfig-termindex.xml b/solr/src/test/test-files/solr/conf/solrconfig-termindex.xml index 5f440277635..59d13566a5b 100644 --- a/solr/src/test/test-files/solr/conf/solrconfig-termindex.xml +++ b/solr/src/test/test-files/solr/conf/solrconfig-termindex.xml @@ -23,7 +23,7 @@ --> - + ${tests.luceneMatchVersion:LUCENE_CURRENT} diff --git a/solr/src/test/test-files/solr/conf/solrconfig-transformers.xml b/solr/src/test/test-files/solr/conf/solrconfig-transformers.xml index 5dbbed94e67..fc44036944e 100644 --- a/solr/src/test/test-files/solr/conf/solrconfig-transformers.xml +++ b/solr/src/test/test-files/solr/conf/solrconfig-transformers.xml @@ -18,7 +18,7 @@ --> - + ${tests.luceneMatchVersion:LUCENE_CURRENT} diff --git a/solr/src/test/test-files/solr/conf/solrconfig-xinclude.xml b/solr/src/test/test-files/solr/conf/solrconfig-xinclude.xml index 1167df89bb8..d99463704d0 100644 --- a/solr/src/test/test-files/solr/conf/solrconfig-xinclude.xml +++ b/solr/src/test/test-files/solr/conf/solrconfig-xinclude.xml @@ -23,7 +23,7 @@ --> - + ${tests.luceneMatchVersion:LUCENE_CURRENT} - 4.0 + ${tests.luceneMatchVersion:LUCENE_CURRENT} + ${tests.luceneMatchVersion:LUCENE_CURRENT} diff --git a/solr/src/test/test-files/solr/crazy-path-to-config.xml b/solr/src/test/test-files/solr/crazy-path-to-config.xml index d9ba0e13093..321008927f9 100644 --- a/solr/src/test/test-files/solr/crazy-path-to-config.xml +++ b/solr/src/test/test-files/solr/crazy-path-to-config.xml @@ -24,6 +24,7 @@ --> + ${tests.luceneMatchVersion:LUCENE_CURRENT} false 10 diff --git a/solr/src/test/test-files/solr/shared/conf/solrconfig.xml b/solr/src/test/test-files/solr/shared/conf/solrconfig.xml index b95eeb36830..031fbb02e5c 100644 --- a/solr/src/test/test-files/solr/shared/conf/solrconfig.xml +++ b/solr/src/test/test-files/solr/shared/conf/solrconfig.xml @@ -21,6 +21,7 @@ It is *not* a good example to work from. --> + ${tests.luceneMatchVersion:LUCENE_CURRENT} ${solr.solr.home}/data/${l10n}-${version}