Apache/lucene
1
0
Fork 0
mirror of https://github.com/apache/lucene.git synced 2025-02-06 10:08:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

LUCENE-3069: add nocommit/TODO

Browse Source 
git-svn-id: https://svn.apache.org/repos/asf/lucene/dev/branches/lucene3069@1493516 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Michael McCandless 2013-06-16 14:40:02 +00:00
parent 3aa280f522
commit 8609b1d2f8
2 changed files with 12 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
lucene/core/src/java/org/apache/lucene/codecs/temp/TempBlockTermsWriter.java
View File

@ -917,6 +917,14 @@ public class TempBlockTermsWriter extends FieldsConsumer {
statsWriter.writeVLong(term.stats.totalTermFreq - term.stats.docFreq); statsWriter.writeVLong(term.stats.totalTermFreq - term.stats.docFreq);
} }
// TODO: now that terms dict "sees" these longs,
// we can explore better column-stride encodings
// to encode all long[0]s for this block at
// once, all long[1]s, etc., e.g. using
// Simple64. Alternatively, we could interleave
// stats + meta ... no reason to have them
// separate anymore:
// Write term meta data // Write term meta data
for (int pos = 0; pos < size; pos++) { for (int pos = 0; pos < size; pos++) {
assert term.longs[pos] >= 0; assert term.longs[pos] >= 0;

4
lucene/core/src/java/org/apache/lucene/codecs/temp/TempPostingsWriter.java
View File

@ -195,6 +195,8 @@ public final class TempPostingsWriter extends TempPostingsWriterBase {
termsOut.writeVInt(BLOCK_SIZE); termsOut.writeVInt(BLOCK_SIZE);
} }
// nocommit better name?
@Override @Override
public void setField(FieldInfo fieldInfo) { public void setField(FieldInfo fieldInfo) {
IndexOptions indexOptions = fieldInfo.getIndexOptions(); IndexOptions indexOptions = fieldInfo.getIndexOptions();
@ -356,6 +358,8 @@ public final class TempPostingsWriter extends TempPostingsWriterBase {
} }
} }
// nocommit explain about the "don't care" values
/** Called when we are done adding docs to this term */ /** Called when we are done adding docs to this term */
@Override @Override
public void finishTerm(long[] longs, DataOutput out, TermStats stats) throws IOException { public void finishTerm(long[] longs, DataOutput out, TermStats stats) throws IOException {