Apache
/
lucene
mirror of https://github.com/apache/lucene.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Like SOLR-360, the solrj XMLInputFactory needs to be thread safe... 

git-svn-id: https://svn.apache.org/repos/asf/lucene/solr/trunk@582349 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Ryan McKinley 2007-10-05 17:11:24 +00:00
parent 88e0370f03
commit 872e407adc
1 changed files with 17 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
client/java/solrj/src/org/apache/solr/client/solrj/impl/XMLResponseParser.java
View File

@ -21,6 +21,7 @@ import java.io.Reader;
import java.util.ArrayList;
import java.util.Date;
import java.util.List;
import java.util.logging.Logger;
import javax.xml.stream.XMLInputFactory;
import javax.xml.stream.XMLStreamConstants;
@ -41,11 +42,27 @@ import org.apache.solr.common.util.NamedList;
*/
public class XMLResponseParser implements ResponseParser
{
public static Logger log = Logger.getLogger(XMLResponseParser.class.getName());
XMLInputFactory factory;
public XMLResponseParser()
{
factory = XMLInputFactory.newInstance();
try {
// The java 1.6 bundled stax parser (sjsxp) does not currently have a thread-safe
// XMLInputFactory, as that implementation tries to cache and reuse the
// XMLStreamReader. Setting the parser-specific "reuse-instance" property to false
// prevents this.
// All other known open-source stax parsers (and the bea ref impl)
// have thread-safe factories.
factory.setProperty("reuse-instance", Boolean.FALSE);
}
catch( IllegalArgumentException ex ) {
// Other implementations will likely throw this exception since "reuse-instance"
// isimplementation specific.
log.fine( "Unable to set the 'reuse-instance' property for the input factory: "+factory );
}
}
public String getWriterType()