Apache
/
lucene
mirror of https://github.com/apache/lucene.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

LUCENE-6921: Remove not necessary doPrivilegedCheck and update docs. 

git-svn-id: https://svn.apache.org/repos/asf/lucene/dev/trunk@1718082 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Uwe Schindler 2015-12-05 14:02:24 +00:00
parent 9d4c415450
commit 889bf7f953
1 changed files with 12 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
lucene/core/src/java/org/apache/lucene/util/SPIClassIterator.java
View File

@ -23,8 +23,6 @@ import java.io.BufferedReader;
import java.io.InputStreamReader;
import java.net.URL;
import java.nio.charset.StandardCharsets;
import java.security.AccessController;
import java.security.PrivilegedAction;
import java.util.ArrayList;
import java.util.Collections;
import java.util.Enumeration;
@ -64,26 +62,22 @@ public final class SPIClassIterator<S> implements Iterator<Class<? extends S>> {
* Utility method to check if some class loader is a (grand-)parent of or the same as another one.
* This means the child will be able to load all classes from the parent, too.
* <p>
* If Lucene's codebase doesn't have enough permissions to do the check, {@code false} is returned.
* If caller's codesource doesn't have enough permissions to do the check, {@code false} is returned
* (this is fine, because if we get a {@code SecurityException} it is for sure no parent).
*/
public static boolean isParentClassLoader(final ClassLoader parent, final ClassLoader child) {
if (parent == child) {
return true; // don't try to use AccessController for performance
}
return AccessController.doPrivileged((PrivilegedAction<Boolean>) () -> {
try {
ClassLoader cl = child;
while (cl != null) {
if (cl == parent) {
return true;
}
cl = cl.getParent();
try {
ClassLoader cl = child;
while (cl != null) {
if (cl == parent) {
return true;
}
return false;
} catch (SecurityException se) {
return false;
cl = cl.getParent();
}
});
return false;
} catch (SecurityException se) {
return false;
}
}
private SPIClassIterator(Class<S> clazz, ClassLoader loader) {