diff --git a/lucene/core/src/java/org/apache/lucene/index/SegmentInfos.java b/lucene/core/src/java/org/apache/lucene/index/SegmentInfos.java index 40f03e8601d..3b95f25d90d 100644 --- a/lucene/core/src/java/org/apache/lucene/index/SegmentInfos.java +++ b/lucene/core/src/java/org/apache/lucene/index/SegmentInfos.java @@ -485,7 +485,7 @@ public final class SegmentInfos implements Cloneable, Iterable refCounts = new HashMap(); private final Directory dir; @@ -50,7 +48,7 @@ class ReplicaFileDeleter { * (can be opened), false if it cannot be opened, and * (unlike Java's File.exists) throws IOException if * there's some unexpected error. */ - static boolean slowFileExists(Directory dir, String fileName) throws IOException { + private static boolean slowFileExists(Directory dir, String fileName) throws IOException { try { dir.openInput(fileName, IOContext.DEFAULT).close(); return true; diff --git a/lucene/replicator/src/java/org/apache/lucene/replicator/nrt/ReplicaNode.java b/lucene/replicator/src/java/org/apache/lucene/replicator/nrt/ReplicaNode.java index 62827e857ec..4caf5cfa639 100644 --- a/lucene/replicator/src/java/org/apache/lucene/replicator/nrt/ReplicaNode.java +++ b/lucene/replicator/src/java/org/apache/lucene/replicator/nrt/ReplicaNode.java @@ -50,7 +50,9 @@ import org.apache.lucene.store.IndexOutput; import org.apache.lucene.store.Lock; import org.apache.lucene.util.IOUtils; -/** Replica node, that pulls index changes from the primary node by copying newly flushed or merged index files */ +/** Replica node, that pulls index changes from the primary node by copying newly flushed or merged index files. + * + * @lucene.experimental */ abstract class ReplicaNode extends Node { diff --git a/lucene/replicator/src/java/org/apache/lucene/replicator/nrt/SegmentInfosSearcherManager.java b/lucene/replicator/src/java/org/apache/lucene/replicator/nrt/SegmentInfosSearcherManager.java index 72ed9213d3c..bae260615fe 100644 --- a/lucene/replicator/src/java/org/apache/lucene/replicator/nrt/SegmentInfosSearcherManager.java +++ b/lucene/replicator/src/java/org/apache/lucene/replicator/nrt/SegmentInfosSearcherManager.java @@ -36,7 +36,9 @@ import org.apache.lucene.store.Directory; import org.apache.lucene.util.ThreadInterruptedException; /** A SearcherManager that refreshes via an externally provided (NRT) SegmentInfos, either from {@link IndexWriter} or via - * nrt replication to another index. */ + * nrt replication to another index. + * + * @lucene.experimental */ class SegmentInfosSearcherManager extends ReferenceManager { private volatile SegmentInfos currentInfos; private final Directory dir; diff --git a/lucene/replicator/src/test/org/apache/lucene/replicator/nrt/TestStressNRTReplication.java b/lucene/replicator/src/test/org/apache/lucene/replicator/nrt/TestStressNRTReplication.java index fff59fa68d1..d9222c0330c 100644 --- a/lucene/replicator/src/test/org/apache/lucene/replicator/nrt/TestStressNRTReplication.java +++ b/lucene/replicator/src/test/org/apache/lucene/replicator/nrt/TestStressNRTReplication.java @@ -58,10 +58,6 @@ import org.apache.lucene.util.ThreadInterruptedException; import com.carrotsearch.randomizedtesting.SeedUtils; -// nocommit why so many "hit SocketException during commit with R0"? - -// nocommit why all these NodeCommunicationExcs? - /* TODO - fangs @@ -1145,7 +1141,9 @@ public class TestStressNRTReplication extends LuceneTestCase { } } catch (IOException se) { // Assume primary crashed - message("top: indexer lost connection to primary"); + if (c != null) { + message("top: indexer lost connection to primary"); + } try { c.close(); } catch (Throwable t) { diff --git a/lucene/test-framework/src/java/org/apache/lucene/store/MockDirectoryWrapper.java b/lucene/test-framework/src/java/org/apache/lucene/store/MockDirectoryWrapper.java index aa892096a92..ef4397f40af 100644 --- a/lucene/test-framework/src/java/org/apache/lucene/store/MockDirectoryWrapper.java +++ b/lucene/test-framework/src/java/org/apache/lucene/store/MockDirectoryWrapper.java @@ -432,7 +432,7 @@ public class MockDirectoryWrapper extends BaseDirectoryWrapper { throw new AssertionError(); } - if (true || LuceneTestCase.VERBOSE) { + if (LuceneTestCase.VERBOSE) { System.out.println("MockDirectoryWrapper: " + action + " unsynced file: " + name); } } diff --git a/solr/core/src/java/org/apache/solr/core/StandardIndexReaderFactory.java b/solr/core/src/java/org/apache/solr/core/StandardIndexReaderFactory.java index 71cb012ae97..9ad40034e96 100644 --- a/solr/core/src/java/org/apache/solr/core/StandardIndexReaderFactory.java +++ b/solr/core/src/java/org/apache/solr/core/StandardIndexReaderFactory.java @@ -26,7 +26,6 @@ import org.apache.lucene.store.Directory; * {@link DirectoryReader}. * * @see DirectoryReader#open(Directory) - * @see DirectoryReader#open(IndexWriter, boolean) */ public class StandardIndexReaderFactory extends IndexReaderFactory {