diff --git a/solr/CHANGES.txt b/solr/CHANGES.txt index 693acb0d611..90e3ff2780c 100644 --- a/solr/CHANGES.txt +++ b/solr/CHANGES.txt @@ -154,10 +154,9 @@ Jetty 9.4.19.v20190610 Upgrade Notes ---------------------- -* Velocity response writer is no longer available to be used through the _default configset. In order - to use it, you would need to manually add it to your configset. Also, the initialization parameters +* Velocity: The initialization parameters "params.resource.loader.enabled" and "solr.resource.loader.enabled" have been removed and replaced by - startup parameters "velocity.resourceloader.params.enabled" and "velocity.resourceloader.solr.enabled" + Java system properties "velocity.resourceloader.params.enabled" and "velocity.resourceloader.solr.enabled" respectively (both turned off by default). Please see SOLR-13971 for more details. Bug Fixes @@ -171,8 +170,8 @@ Bug Fixes * SOLR-13465: CoreContainer.auditloggerPlugin should be volatile (janhoy, hossman) -* SOLR-13971: Velocity response writer's resource loading now possible only through startup parameters. Also, removed velocity - response writer from _default configset. (Ishan Chattopadhyaya) +* SOLR-13971: Velocity response writer's resource loading now possible only through startup parameters. + (Ishan Chattopadhyaya, David Smiley) ================== 8.3.0 ================== diff --git a/solr/contrib/velocity/src/java/org/apache/solr/response/VelocityResponseWriter.java b/solr/contrib/velocity/src/java/org/apache/solr/response/VelocityResponseWriter.java index 75fcd689cf1..b3f022ad48b 100644 --- a/solr/contrib/velocity/src/java/org/apache/solr/response/VelocityResponseWriter.java +++ b/solr/contrib/velocity/src/java/org/apache/solr/response/VelocityResponseWriter.java @@ -108,12 +108,10 @@ public class VelocityResponseWriter implements QueryResponseWriter, SolrCoreAwar } // params resource loader: off by default - Boolean prle = Boolean.getBoolean(PARAMS_RESOURCE_LOADER_ENABLED); - paramsResourceLoaderEnabled = (null == prle ? false : prle); + paramsResourceLoaderEnabled = Boolean.getBoolean(PARAMS_RESOURCE_LOADER_ENABLED); // solr resource loader: off by default - Boolean srle = Boolean.getBoolean(SOLR_RESOURCE_LOADER_ENABLED); - solrResourceLoaderEnabled = (null == srle ? false : srle); + solrResourceLoaderEnabled = Boolean.getBoolean(SOLR_RESOURCE_LOADER_ENABLED); initPropertiesFileName = (String) args.get(PROPERTIES_FILE); diff --git a/solr/core/src/test-files/solr/configsets/_default/conf/solrconfig.xml b/solr/core/src/test-files/solr/configsets/_default/conf/solrconfig.xml index 3af7d76cc58..33b25cd4e18 100644 --- a/solr/core/src/test-files/solr/configsets/_default/conf/solrconfig.xml +++ b/solr/core/src/test-files/solr/configsets/_default/conf/solrconfig.xml @@ -81,6 +81,8 @@ + + - + explicit @@ -1297,6 +1299,15 @@ text/plain; charset=UTF-8 + + + ${velocity.template.base.dir:} + ${velocity.solr.resource.loader.enabled:true} + ${velocity.params.resource.loader.enabled:false} + + - + explicit @@ -1297,6 +1299,15 @@ text/plain; charset=UTF-8 + + + ${velocity.template.base.dir:} + ${velocity.solr.resource.loader.enabled:true} + ${velocity.params.resource.loader.enabled:false} + +