trade one nocommit for another

git-svn-id: https://svn.apache.org/repos/asf/lucene/dev/branches/lucene4547@1440840 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Robert Muir 2013-01-31 04:05:32 +00:00
parent b21ecede84
commit 8c8c906d2b
1 changed files with 4 additions and 4 deletions

View File

@ -253,10 +253,10 @@ final class DocFieldProcessor extends DocConsumer {
rehash();
}
} else {
// nocommit this is wasteful: it's another hash lookup
// by field name; can we just do fp.fieldInfo.update
// directly?
fieldInfos.addOrUpdate(fp.fieldInfo.name, ft);
// nocommit: dangerous: maybe FI.update()/FI ctor()/FIS.addOrUpdate need only take FT
// instead of a thousand parameters? Surely we can make this better... like:
// fp.fieldInfo.update(ft);
fp.fieldInfo.update(ft.indexed(), false, ft.omitNorms(), false, ft.indexOptions());
}
if (thisFieldGen != fp.lastGen) {