Apache
/
lucene
mirror of https://github.com/apache/lucene.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

SOLR-10939: update @SuppressPointFields on TestJoin to note why points are suppressed 

Also update the annotation on TestCloudJSONFacetJoinDomain since SOLR-9989 is resolved but the join problems
still prevent that test from passing with points enabled
This commit is contained in:
Chris Hostetter 2017-06-22 16:05:39 -07:00
parent ae01113472
commit 8d92e08c9c
2 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
solr/core/src/test/org/apache/solr/TestJoin.java
View File

@ -37,7 +37,7 @@ import java.util.List;
import java.util.Map; import java.util.Map;
import java.util.Set; import java.util.Set;
@SuppressPointFields @SuppressPointFields(bugUrl="https://issues.apache.org/jira/browse/SOLR-10939")
public class TestJoin extends SolrTestCaseJ4 { public class TestJoin extends SolrTestCaseJ4 {
private static final Logger log = LoggerFactory.getLogger(MethodHandles.lookup().lookupClass()); private static final Logger log = LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());

6
solr/core/src/test/org/apache/solr/cloud/TestCloudJSONFacetJoinDomain.java
View File

@ -60,7 +60,7 @@ import org.slf4j.LoggerFactory;
* *
* @see TestCloudPivotFacet * @see TestCloudPivotFacet
*/ */
@SuppressPointFields(bugUrl="https://issues.apache.org/jira/browse/SOLR-9989") @SuppressPointFields(bugUrl="https://issues.apache.org/jira/browse/SOLR-10939")
public class TestCloudJSONFacetJoinDomain extends SolrCloudTestCase { public class TestCloudJSONFacetJoinDomain extends SolrCloudTestCase {
private static final Logger log = LoggerFactory.getLogger(MethodHandles.lookup().lookupClass()); private static final Logger log = LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());
@ -82,6 +82,10 @@ public class TestCloudJSONFacetJoinDomain extends SolrCloudTestCase {
/** One client per node */ /** One client per node */
private static ArrayList<HttpSolrClient> CLIENTS = new ArrayList<>(5); private static ArrayList<HttpSolrClient> CLIENTS = new ArrayList<>(5);
public TestCloudJSONFacetJoinDomain() {
// we need DVs on point fields to compute stats & facets
if (Boolean.getBoolean(NUMERIC_POINTS_SYSPROP)) System.setProperty(NUMERIC_DOCVALUES_SYSPROP,"true");
}
@BeforeClass @BeforeClass
private static void createMiniSolrCloudCluster() throws Exception { private static void createMiniSolrCloudCluster() throws Exception {