diff --git a/solr/CHANGES.txt b/solr/CHANGES.txt index 0e4bb42b8b8..4a42f75ffaa 100644 --- a/solr/CHANGES.txt +++ b/solr/CHANGES.txt @@ -505,6 +505,7 @@ Other Changes - SOLR-11105: Randomize PointFields in "cloud-minimal-jmx" and "cloud-minimal-inplace-updates" test configsets (Steve Rowe) - SOLR-11109: Randomize PointFields in "cloud-subdirs" and "configset-2" test configsets (Steve Rowe) - SOLR-11110: Randomize PointFields in "cloud-managed" and "cloud-managed-upgrade" test configsets (Steve Rowe) + - SOLR-11102: Randomize PointFields in schema-rest.xml and all affected tests (hossman) * SOLR-6807: Changed requestDispatcher's handleSelect to default to false, thus ignoring "qt". Simplified configs to not refer to handleSelect or "qt". Switch all tests that assumed true to assume false diff --git a/solr/core/src/test-files/solr/collection1/conf/schema-rest.xml b/solr/core/src/test-files/solr/collection1/conf/schema-rest.xml index 89c2623cbd0..5e2ac212916 100644 --- a/solr/core/src/test-files/solr/collection1/conf/schema-rest.xml +++ b/solr/core/src/test-files/solr/collection1/conf/schema-rest.xml @@ -31,15 +31,15 @@ 1.5: omitNorms defaults to true for primitive field types (int, float, boolean, string...) 1.6: useDocValuesAsStored defaults to true. --> - - - - + + + + - - - - + + + + @@ -96,8 +96,8 @@ - - + + diff --git a/solr/core/src/test/org/apache/solr/rest/schema/TestDynamicFieldResource.java b/solr/core/src/test/org/apache/solr/rest/schema/TestDynamicFieldResource.java index 7ca7953d393..79b1bf06d7c 100644 --- a/solr/core/src/test/org/apache/solr/rest/schema/TestDynamicFieldResource.java +++ b/solr/core/src/test/org/apache/solr/rest/schema/TestDynamicFieldResource.java @@ -21,13 +21,14 @@ import org.junit.Test; public class TestDynamicFieldResource extends SolrRestletTestBase { @Test public void testGetDynamicField() throws Exception { + final boolean expectedDocValues = Boolean.getBoolean(NUMERIC_DOCVALUES_SYSPROP); assertQ("/schema/dynamicfields/*_i?indent=on&wt=xml&showDefaults=on", "count(/response/lst[@name='dynamicField']) = 1", "/response/lst[@name='dynamicField']/str[@name='name'] = '*_i'", "/response/lst[@name='dynamicField']/str[@name='type'] = 'int'", "/response/lst[@name='dynamicField']/bool[@name='indexed'] = 'true'", "/response/lst[@name='dynamicField']/bool[@name='stored'] = 'true'", - "/response/lst[@name='dynamicField']/bool[@name='docValues'] = 'false'", + "/response/lst[@name='dynamicField']/bool[@name='docValues'] = '"+expectedDocValues+"'", "/response/lst[@name='dynamicField']/bool[@name='termVectors'] = 'false'", "/response/lst[@name='dynamicField']/bool[@name='termPositions'] = 'false'", "/response/lst[@name='dynamicField']/bool[@name='termOffsets'] = 'false'", @@ -50,12 +51,13 @@ public class TestDynamicFieldResource extends SolrRestletTestBase { @Test public void testJsonGetDynamicField() throws Exception { + final boolean expectedDocValues = Boolean.getBoolean(NUMERIC_DOCVALUES_SYSPROP); assertJQ("/schema/dynamicfields/*_i?indent=on&showDefaults=on", "/dynamicField/name=='*_i'", "/dynamicField/type=='int'", "/dynamicField/indexed==true", "/dynamicField/stored==true", - "/dynamicField/docValues==false", + "/dynamicField/docValues=="+expectedDocValues, "/dynamicField/termVectors==false", "/dynamicField/termPositions==false", "/dynamicField/termOffsets==false", diff --git a/solr/core/src/test/org/apache/solr/rest/schema/TestFieldTypeResource.java b/solr/core/src/test/org/apache/solr/rest/schema/TestFieldTypeResource.java index b66ffc12083..a1beb99480a 100644 --- a/solr/core/src/test/org/apache/solr/rest/schema/TestFieldTypeResource.java +++ b/solr/core/src/test/org/apache/solr/rest/schema/TestFieldTypeResource.java @@ -22,15 +22,17 @@ import org.junit.Test; public class TestFieldTypeResource extends SolrRestletTestBase { @Test public void testGetFieldType() throws Exception { + final String expectedFloatClass = RANDOMIZED_NUMERIC_FIELDTYPES.get(Float.class); + final boolean expectedDocValues = Boolean.getBoolean(NUMERIC_DOCVALUES_SYSPROP); assertQ("/schema/fieldtypes/float?indent=on&wt=xml&showDefaults=true", "count(/response/lst[@name='fieldType']) = 1", "count(/response/lst[@name='fieldType']/*) = 17", "/response/lst[@name='fieldType']/str[@name='name'] = 'float'", - "/response/lst[@name='fieldType']/str[@name='class'] = 'solr.TrieFloatField'", + "/response/lst[@name='fieldType']/str[@name='class'] = '"+expectedFloatClass+"'", "/response/lst[@name='fieldType']/str[@name='precisionStep'] ='0'", "/response/lst[@name='fieldType']/bool[@name='indexed'] = 'true'", "/response/lst[@name='fieldType']/bool[@name='stored'] = 'true'", - "/response/lst[@name='fieldType']/bool[@name='docValues'] = 'false'", + "/response/lst[@name='fieldType']/bool[@name='docValues'] = '"+expectedDocValues+"'", "/response/lst[@name='fieldType']/bool[@name='termVectors'] = 'false'", "/response/lst[@name='fieldType']/bool[@name='termPositions'] = 'false'", "/response/lst[@name='fieldType']/bool[@name='termOffsets'] = 'false'", @@ -53,13 +55,15 @@ public class TestFieldTypeResource extends SolrRestletTestBase { @Test public void testJsonGetFieldType() throws Exception { + final String expectedFloatClass = RANDOMIZED_NUMERIC_FIELDTYPES.get(Float.class); + final boolean expectedDocValues = Boolean.getBoolean(NUMERIC_DOCVALUES_SYSPROP); assertJQ("/schema/fieldtypes/float?indent=on&showDefaults=on", // assertJQ will add "&wt=json" "/fieldType/name=='float'", - "/fieldType/class=='solr.TrieFloatField'", + "/fieldType/class=='"+expectedFloatClass+"'", "/fieldType/precisionStep=='0'", "/fieldType/indexed==true", "/fieldType/stored==true", - "/fieldType/docValues==false", + "/fieldType/docValues=="+expectedDocValues, "/fieldType/termVectors==false", "/fieldType/termPositions==false", "/fieldType/termOffsets==false",