Turn some "assert false" in switch and switch-like statements into AssertionErrors. If we get into the default block we are wrong and we can also throw Ex, because then there is logic error (e.g. after new enum constant was added)

git-svn-id: https://svn.apache.org/repos/asf/lucene/dev/trunk@1379450 13f79535-47bb-0310-9956-ffa450edef68

lucene/benchmark/src/java/org/apache/lucene/benchmark/byTask/feeds/DocMaker.java

@@ -170,7 +170,7 @@ public class DocMaker implements Closeable {
           f = new DoubleField(name, 0.0, Field.Store.NO);
           break;
         default:
-          assert false;
+          throw new AssertionError("Cannot get here");
         }
         if (reuseFields) {
           numericFields.put(name, f);

lucene/core/src/java/org/apache/lucene/codecs/lucene40/Lucene40StoredFieldsWriter.java

@@ -186,7 +186,7 @@ public final class Lucene40StoredFieldsWriter extends StoredFieldsWriter {
       } else if (number instanceof Double) {
         fieldsStream.writeLong(Double.doubleToLongBits(number.doubleValue()));
       } else {
-        assert false;
+        throw new AssertionError("Cannot get here");
       }
     }
   }

lucene/core/src/java/org/apache/lucene/document/Field.java

@@ -521,7 +521,7 @@ public class Field implements IndexableField {
         nts.setDoubleValue(val.doubleValue());
         break;
       default:
-        assert false : "Should never get here";
+        throw new AssertionError("Should never get here");
       }
       return internalTokenStream;
     }

lucene/core/src/java/org/apache/lucene/index/DocumentsWriter.java

@@ -365,7 +365,7 @@ final class DocumentsWriter {
 
       if (!perThread.isActive()) {
         ensureOpen();
-        assert false: "perThread is not active but we are still open";
+        throw new IllegalStateException("perThread is not active but we are still open");
       }
        
       final DocumentsWriterPerThread dwpt = perThread.dwpt;

lucene/core/src/java/org/apache/lucene/index/DocumentsWriterDeleteQueue.java

@@ -324,7 +324,7 @@ final class DocumentsWriterDeleteQueue {
         .newUpdater(Node.class, Node.class, "next");
 
     void apply(BufferedDeletes bufferedDeletes, int docIDUpto) {
-      assert false : "sentinel item must never be applied";
+      throw new IllegalStateException("sentinel item must never be applied");
     }
 
     boolean casNext(Node<?> cmp, Node<?> val) {

lucene/core/src/java/org/apache/lucene/index/MultiTermsEnum.java

@@ -401,8 +401,8 @@ public final class MultiTermsEnum extends TermsEnum {
         subDocs[upto].slice = entry.subSlice;
         upto++;
       } else {
-        // One of our subs cannot provide a docsenum:
-        assert false;
+        // should this be an error?
+        assert false : "One of our subs cannot provide a docsenum";
       }
     }
 

lucene/core/src/java/org/apache/lucene/store/BufferedIndexInput.java

@@ -362,8 +362,7 @@ public abstract class BufferedIndexInput extends IndexInput {
     case MERGE:
       return MERGE_BUFFER_SIZE;
     default:
-      assert false : "unknown IOContext " + context.context;
-      return BUFFER_SIZE;
+      throw new AssertionError("unknown IOContext " + context.context);
     }
   }
   

lucene/queryparser/src/test/org/apache/lucene/queryparser/flexible/standard/TestNumericQueryParser.java

@@ -223,7 +223,7 @@ public class TestNumericQueryParser extends LuceneTestCase {
         field = new DoubleField(type.name(), 0.0, ft);
         break;
       default:
-        assert false;
+        fail();
         field = null;
       }
       numericFieldMap.put(type.name(), field);