From 908ac35cab70fe63715b08809188c8137c73b5b1 Mon Sep 17 00:00:00 2001
From: Vincent Letard <letardv@lexum.com>
Date: Wed, 27 Mar 2024 23:01:08 -0400
Subject: [PATCH] Added UH extensibility test.

---
 .../TestUnifiedHighlighterExtensibility.java  | 30 +++++++++++++++++++
 1 file changed, 30 insertions(+)

diff --git a/lucene/highlighter/src/test/org/apache/lucene/search/uhighlight/visibility/TestUnifiedHighlighterExtensibility.java b/lucene/highlighter/src/test/org/apache/lucene/search/uhighlight/visibility/TestUnifiedHighlighterExtensibility.java
index d6ce6464d4c..17882a98fac 100644
--- a/lucene/highlighter/src/test/org/apache/lucene/search/uhighlight/visibility/TestUnifiedHighlighterExtensibility.java
+++ b/lucene/highlighter/src/test/org/apache/lucene/search/uhighlight/visibility/TestUnifiedHighlighterExtensibility.java
@@ -27,11 +27,14 @@ import java.util.function.Predicate;
 import org.apache.lucene.analysis.Analyzer;
 import org.apache.lucene.index.LeafReader;
 import org.apache.lucene.index.Term;
+import org.apache.lucene.queries.function.FunctionQuery;
+import org.apache.lucene.queries.function.valuesource.ConstValueSource;
 import org.apache.lucene.queries.spans.SpanQuery;
 import org.apache.lucene.search.DocIdSetIterator;
 import org.apache.lucene.search.IndexSearcher;
 import org.apache.lucene.search.MatchAllDocsQuery;
 import org.apache.lucene.search.Query;
+import org.apache.lucene.search.TermQuery;
 import org.apache.lucene.search.uhighlight.FieldHighlighter;
 import org.apache.lucene.search.uhighlight.FieldOffsetStrategy;
 import org.apache.lucene.search.uhighlight.LabelledCharArrayMatcher;
@@ -90,6 +93,33 @@ public class TestUnifiedHighlighterExtensibility extends LuceneTestCase {
     assertEquals(offsetSource, strategy.getOffsetSource());
   }
 
+  static class TestExtendedUnifiedHighlighter extends UnifiedHighlighter {
+    boolean supportsNewQueryType = false;
+
+    public TestExtendedUnifiedHighlighter(Builder builder) {
+      super(builder);
+    }
+
+    @Override
+    protected boolean isIgnorableQuery(Query q) {
+      return super.isIgnorableQuery(q) || (this.supportsNewQueryType && q instanceof TermQuery);
+    }
+  }
+  ;
+
+  @Test
+  public void testUnifiedHighlighterIgnorableQueryExtensibility() {
+    final UnifiedHighlighter.Builder uhBuilder =
+        new UnifiedHighlighter.Builder(null, new MockAnalyzer(random()));
+    final TestExtendedUnifiedHighlighter uh = new TestExtendedUnifiedHighlighter(uhBuilder);
+
+    assertTrue(uh.isIgnorableQuery(new MatchAllDocsQuery()));
+    assertTrue(uh.isIgnorableQuery(new FunctionQuery(new ConstValueSource(46))));
+    assertFalse(uh.isIgnorableQuery(new TermQuery(new Term("term"))));
+    uh.supportsNewQueryType = true;
+    assertTrue(uh.isIgnorableQuery(new TermQuery(new Term("term"))));
+  }
+
   /**
    * This test is for maintaining the extensibility of the UnifiedHighlighter for customizations out
    * of package.