diff --git a/lucene/facet/src/java/org/apache/lucene/facet/simple/TaxonomyFacetCounts.java b/lucene/facet/src/java/org/apache/lucene/facet/simple/TaxonomyFacetCounts.java index 4f75f002940..b0068a600a3 100644 --- a/lucene/facet/src/java/org/apache/lucene/facet/simple/TaxonomyFacetCounts.java +++ b/lucene/facet/src/java/org/apache/lucene/facet/simple/TaxonomyFacetCounts.java @@ -32,6 +32,7 @@ import org.apache.lucene.index.BinaryDocValues; import org.apache.lucene.util.BytesRef; import org.apache.lucene.util.FixedBitSet; +// nocommit jdoc that this assumes/requires the default encoding public class TaxonomyFacetCounts extends Facets { private final FacetsConfig facetsConfig; private final TaxonomyReader taxoReader; @@ -178,6 +179,8 @@ public class TaxonomyFacetCounts extends Facets { } FacetsConfig.DimConfig ft = facetsConfig.getDimConfig(path.components[0]); + // nocommit shouldn't we verify the indexedFieldName + // matches what was passed to our ctor? if (ft.hierarchical && ft.multiValued) { totCount = counts[dimOrd]; } diff --git a/lucene/facet/src/java/org/apache/lucene/facet/simple/TaxonomyFacetSumValueSource.java b/lucene/facet/src/java/org/apache/lucene/facet/simple/TaxonomyFacetSumValueSource.java index db525775d1c..63e8c8c6b51 100644 --- a/lucene/facet/src/java/org/apache/lucene/facet/simple/TaxonomyFacetSumValueSource.java +++ b/lucene/facet/src/java/org/apache/lucene/facet/simple/TaxonomyFacetSumValueSource.java @@ -39,6 +39,8 @@ import org.apache.lucene.util.FixedBitSet; /** Aggregates sum of values from a {@link ValueSource}, for * each facet label. */ +// nocommit jdoc that this assumes/requires the default encoding + public class TaxonomyFacetSumValueSource extends Facets { private final FacetsConfig facetsConfig; private final TaxonomyReader taxoReader;