Apache
/
lucene
mirror of https://github.com/apache/lucene.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

SOLR-12028: BadApple and AwaitsFix annotations usage

This commit is contained in:
Erick Erickson 2018-08-17 14:40:16 -07:00
parent 52f9cee97b
commit 9f615fbae7
14 changed files with 17 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
solr/core/src/test/org/apache/solr/cloud/DeleteReplicaTest.java
View File

@ -219,6 +219,7 @@ public class DeleteReplicaTest extends SolrCloudTestCase {
@Test @Test
@Slow @Slow
//28-June-2018 @BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // 21-May-2018 //28-June-2018 @BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // 21-May-2018
@BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // added 17-Aug-2018
public void raceConditionOnDeleteAndRegisterReplica() throws Exception { public void raceConditionOnDeleteAndRegisterReplica() throws Exception {
raceConditionOnDeleteAndRegisterReplica("true"); raceConditionOnDeleteAndRegisterReplica("true");
raceConditionOnDeleteAndRegisterReplica("false"); raceConditionOnDeleteAndRegisterReplica("false");

1
solr/core/src/test/org/apache/solr/cloud/LegacyCloudClusterPropTest.java
View File

@ -66,6 +66,7 @@ public class LegacyCloudClusterPropTest extends SolrCloudTestCase {
@Test @Test
//2018-06-18 (commented) @BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") //2018-06-18 (commented) @BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028")
@BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // added 17-Aug-2018
public void testCreateCollectionSwitchLegacyCloud() throws Exception { public void testCreateCollectionSwitchLegacyCloud() throws Exception {
createAndTest("legacyTrue", true); createAndTest("legacyTrue", true);
createAndTest("legacyFalse", false); createAndTest("legacyFalse", false);

1
solr/core/src/test/org/apache/solr/cloud/MoveReplicaHDFSTest.java
View File

@ -67,6 +67,7 @@ public class MoveReplicaHDFSTest extends MoveReplicaTest {
@Test @Test
//2018-06-18 (commented) @BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // 21-May-2018 //2018-06-18 (commented) @BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // 21-May-2018
//commented 9-Aug-2018 @BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // added 20-Jul-2018 //commented 9-Aug-2018 @BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // added 20-Jul-2018
@BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // added 17-Aug-2018
public void testNormalFailedMove() throws Exception { public void testNormalFailedMove() throws Exception {
inPlaceMove = false; inPlaceMove = false;
testFailedMove(); testFailedMove();

3
solr/core/src/test/org/apache/solr/cloud/MoveReplicaTest.java
View File

@ -27,7 +27,6 @@ import java.util.List;
import java.util.Map; import java.util.Map;
import java.util.Set; import java.util.Set;
import org.apache.lucene.util.LuceneTestCase;
import org.apache.solr.client.solrj.SolrClient; import org.apache.solr.client.solrj.SolrClient;
import org.apache.solr.client.solrj.SolrQuery; import org.apache.solr.client.solrj.SolrQuery;
import org.apache.solr.client.solrj.SolrServerException; import org.apache.solr.client.solrj.SolrServerException;
@ -238,7 +237,7 @@ public class MoveReplicaTest extends SolrCloudTestCase {
// @AwaitsFix(bugUrl = "https://issues.apache.org/jira/browse/SOLR-11458") // @AwaitsFix(bugUrl = "https://issues.apache.org/jira/browse/SOLR-11458")
@Test @Test
// 12-Jun-2018 @BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // 17-Mar-2018 This JIRA is fixed, but this test still fails // 12-Jun-2018 @BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // 17-Mar-2018 This JIRA is fixed, but this test still fails
@LuceneTestCase.BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // 2-Aug-2018 //17-Aug-2018 commented @LuceneTestCase.BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // 2-Aug-2018
public void testFailedMove() throws Exception { public void testFailedMove() throws Exception {
String coll = getTestClass().getSimpleName() + "_failed_coll_" + inPlaceMove; String coll = getTestClass().getSimpleName() + "_failed_coll_" + inPlaceMove;
int REPLICATION = 2; int REPLICATION = 2;

1
solr/core/src/test/org/apache/solr/cloud/MultiThreadedOCPTest.java
View File

@ -59,6 +59,7 @@ public class MultiThreadedOCPTest extends AbstractFullDistribZkTestBase {
@Test @Test
// commented 20-July-2018 @BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // commented 20-July-2018 @BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028")
@BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // added 17-Aug-2018
@ShardsFixed(num = 4) @ShardsFixed(num = 4)
public void test() throws Exception { public void test() throws Exception {
testParallelCollectionAPICalls(); testParallelCollectionAPICalls();

2
solr/core/src/test/org/apache/solr/cloud/TestLeaderInitiatedRecoveryThread.java
View File

@ -45,7 +45,7 @@ public class TestLeaderInitiatedRecoveryThread extends AbstractFullDistribZkTest
} }
@Test @Test
@BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // 09-Apr-2018 //17-Aug-2018 commented @BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // 09-Apr-2018
public void testPublishDownState() throws Exception { public void testPublishDownState() throws Exception {
waitForRecoveriesToFinish(true); waitForRecoveriesToFinish(true);

1
solr/core/src/test/org/apache/solr/cloud/autoscaling/AutoScalingHandlerTest.java
View File

@ -676,6 +676,7 @@ public class AutoScalingHandlerTest extends SolrCloudTestCase {
} }
@Test @Test
@BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // added 17-Aug-2018
public void testReadApi() throws Exception { public void testReadApi() throws Exception {
CloudSolrClient solrClient = cluster.getSolrClient(); CloudSolrClient solrClient = cluster.getSolrClient();
// first trigger // first trigger

2
solr/core/src/test/org/apache/solr/cloud/autoscaling/SearchRateTriggerIntegrationTest.java
View File

@ -273,7 +273,7 @@ public class SearchRateTriggerIntegrationTest extends SolrCloudTestCase {
} }
@Test @Test
@BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // 21-May-2018 //17-Aug-2018 commented @BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // 21-May-2018
public void testBelowSearchRate() throws Exception { public void testBelowSearchRate() throws Exception {
CloudSolrClient solrClient = cluster.getSolrClient(); CloudSolrClient solrClient = cluster.getSolrClient();
String COLL1 = "belowRate_collection"; String COLL1 = "belowRate_collection";

3
solr/core/src/test/org/apache/solr/cloud/autoscaling/sim/TestComputePlanAction.java
View File

@ -27,7 +27,6 @@ import java.util.concurrent.TimeUnit;
import java.util.concurrent.atomic.AtomicBoolean; import java.util.concurrent.atomic.AtomicBoolean;
import java.util.concurrent.atomic.AtomicReference; import java.util.concurrent.atomic.AtomicReference;
import org.apache.lucene.util.LuceneTestCase;
import org.apache.solr.client.solrj.SolrClient; import org.apache.solr.client.solrj.SolrClient;
import org.apache.solr.client.solrj.SolrRequest; import org.apache.solr.client.solrj.SolrRequest;
import org.apache.solr.client.solrj.SolrResponse; import org.apache.solr.client.solrj.SolrResponse;
@ -254,7 +253,7 @@ public class TestComputePlanAction extends SimSolrCloudTestCase {
} }
@Test @Test
@LuceneTestCase.BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // 28-June-2018 //17-Aug-2018 commented @LuceneTestCase.BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // 28-June-2018
public void testNodeAdded() throws Exception { public void testNodeAdded() throws Exception {
AssertingTriggerAction.expectedNode = null; AssertingTriggerAction.expectedNode = null;
SolrClient solrClient = cluster.simGetSolrClient(); SolrClient solrClient = cluster.simGetSolrClient();

2
solr/core/src/test/org/apache/solr/cloud/hdfs/HdfsBasicDistributedZk2Test.java
View File

@ -19,6 +19,7 @@ package org.apache.solr.cloud.hdfs;
import java.io.IOException; import java.io.IOException;
import org.apache.hadoop.hdfs.MiniDFSCluster; import org.apache.hadoop.hdfs.MiniDFSCluster;
import org.apache.lucene.util.LuceneTestCase;
import org.apache.lucene.util.LuceneTestCase.Slow; import org.apache.lucene.util.LuceneTestCase.Slow;
import org.apache.solr.cloud.BasicDistributedZk2Test; import org.apache.solr.cloud.BasicDistributedZk2Test;
import org.apache.solr.util.BadHdfsThreadsFilter; import org.apache.solr.util.BadHdfsThreadsFilter;
@ -34,6 +35,7 @@ import com.carrotsearch.randomizedtesting.annotations.ThreadLeakFilters;
BadHdfsThreadsFilter.class // hdfs currently leaks thread(s) BadHdfsThreadsFilter.class // hdfs currently leaks thread(s)
}) })
// commented 20-July-2018 @LuceneTestCase.BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // 26-Mar-2018 // commented 20-July-2018 @LuceneTestCase.BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // 26-Mar-2018
@LuceneTestCase.BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // added 17-Aug-2018
public class HdfsBasicDistributedZk2Test extends BasicDistributedZk2Test { public class HdfsBasicDistributedZk2Test extends BasicDistributedZk2Test {
private static MiniDFSCluster dfsCluster; private static MiniDFSCluster dfsCluster;

2
solr/core/src/test/org/apache/solr/core/TestDynamicLoading.java
View File

@ -46,7 +46,7 @@ public class TestDynamicLoading extends AbstractFullDistribZkTestBase {
@Test @Test
// 12-Jun-2018 @BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // 12-Jun-2018 @BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028")
@BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // added 20-Jul-2018 //17-Aug-2018 commented @BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // added 20-Jul-2018
public void testDynamicLoading() throws Exception { public void testDynamicLoading() throws Exception {
System.setProperty("enable.runtime.lib", "true"); System.setProperty("enable.runtime.lib", "true");
setupRestTestHarnesses(); setupRestTestHarnesses();

1
solr/core/src/test/org/apache/solr/handler/TestReplicationHandler.java
View File

@ -830,6 +830,7 @@ public class TestReplicationHandler extends SolrTestCaseJ4 {
@Test @Test
@BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // added 17-Aug-2018
public void doTestStressReplication() throws Exception { public void doTestStressReplication() throws Exception {
// change solrconfig on slave // change solrconfig on slave
// this has no entry for pollinginterval // this has no entry for pollinginterval

2
solr/core/src/test/org/apache/solr/update/processor/TestNamedUpdateProcessors.java
View File

@ -44,7 +44,7 @@ import org.junit.Test;
public class TestNamedUpdateProcessors extends AbstractFullDistribZkTestBase { public class TestNamedUpdateProcessors extends AbstractFullDistribZkTestBase {
@Test @Test
@BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // added 20-Jul-2018 //17-Aug-2018 commented @BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // added 20-Jul-2018
public void test() throws Exception { public void test() throws Exception {
System.setProperty("enable.runtime.lib", "true"); System.setProperty("enable.runtime.lib", "true");
setupRestTestHarnesses(); setupRestTestHarnesses();

2
solr/solrj/src/test/org/apache/solr/common/cloud/TestCloudCollectionsListeners.java
View File

@ -67,6 +67,7 @@ public class TestCloudCollectionsListeners extends SolrCloudTestCase {
} }
@Test @Test
@BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // added 17-Aug-2018
public void testSimpleCloudCollectionsListener() throws Exception { public void testSimpleCloudCollectionsListener() throws Exception {
CloudSolrClient client = cluster.getSolrClient(); CloudSolrClient client = cluster.getSolrClient();
@ -194,6 +195,7 @@ public class TestCloudCollectionsListeners extends SolrCloudTestCase {
} }
@Test @Test
@BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028") // added 17-Aug-2018
public void testWatchesWorkForBothStateFormats() throws Exception { public void testWatchesWorkForBothStateFormats() throws Exception {
CloudSolrClient client = cluster.getSolrClient(); CloudSolrClient client = cluster.getSolrClient();