Apache
/
lucene
mirror of https://github.com/apache/lucene.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

LUCENE-10047: Fix value de-duping check in LongValueFacetCounts and RangeFacetCounts (#237)

This commit is contained in:
Greg Miller 2021-08-07 10:20:49 -07:00 committed by GitHub
parent e937e739f3
commit a11457b4e6
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 9 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
lucene/CHANGES.txt
View File

@ -281,6 +281,9 @@ Bug fixes
* LUCENE-9823: Prevent unsafe rewrites for SynonymQuery and CombinedFieldQuery. Before, rewriting
could slightly change the scoring when weights were specified. (Naoto Minami via Julie Tibshirani)
* LUCENE-10047: Fix a value de-duping bug in LongValueFacetCounts and RangeFacetCounts
(Greg Miller)
Changes in Backwards Compatibility Policy
* LUCENE-9904: regenerated UAX29URLEmailTokenizer and the corresponding analyzer with up-to-date top

8
lucene/facet/src/java/org/apache/lucene/facet/LongValueFacetCounts.java
View File

@ -162,11 +162,11 @@ public class LongValueFacetCounts extends Facets {
if (limit > 0) {
totCount++;
}
long previousValue = -1;
long previousValue = 0;
for (int i = 0; i < limit; i++) {
long value = multiValues.nextValue();
// do not increment the count for duplicate values
if (value != previousValue) {
if (i == 0 || value != previousValue) {
increment(value);
previousValue = value;
}
@ -214,11 +214,11 @@ public class LongValueFacetCounts extends Facets {
if (limit > 0) {
totCount++;
}
long previousValue = -1;
long previousValue = 0;
for (int i = 0; i < limit; i++) {
long value = multiValues.nextValue();
// do not increment the count for duplicate values
if (value != previousValue) {
if (i == 0 || value != previousValue) {
increment(value);
previousValue = value;
}

4
lucene/facet/src/java/org/apache/lucene/facet/range/RangeFacetCounts.java
View File

@ -193,10 +193,10 @@ abstract class RangeFacetCounts extends Facets {
totCount++;
} else {
counter.startMultiValuedDoc();
long previous = -1;
long previous = 0;
for (int j = 0; j < limit; j++) {
long val = mapDocValue(multiValues.nextValue());
if (val != previous) {
if (j == 0 || val != previous) {
counter.addMultiValued(val);
previous = val;
}