Steve: this should be a better solution than @Ignore? Maven won't run abstract classes and this seems more consistent with the declared class purpose...

git-svn-id: https://svn.apache.org/repos/asf/lucene/dev/trunk@1298287 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Dawid Weiss 2012-03-08 07:57:51 +00:00
parent abaf382836
commit a42943db90
2 changed files with 2 additions and 19 deletions

View File

@ -170,7 +170,7 @@
<property name="junit.output.dir.backwards" location="${build.dir.backwards}/test"/>
<property name="junit.reports" location="${build.dir}/test/reports"/>
<property name="junit.reports.backwards" location="${build.dir.backwards}/test/reports"/>
<property name="junit.excludes" value=""/>
<property name="junit.excludes" value="**/Abstract*"/>
<condition property="junit.details.formatter"
value="org.apache.tools.ant.taskdefs.optional.junit.BriefJUnitResultFormatter"
else="org.apache.lucene.util.LuceneJUnitResultFormatter">

View File

@ -17,30 +17,14 @@ package org.apache.lucene.search.grouping;
* limitations under the License.
*/
import org.apache.lucene.document.Field;
import org.apache.lucene.document.FieldType;
import org.apache.lucene.search.Sort;
import org.apache.lucene.search.SortField;
import org.apache.lucene.util.BytesRef;
import org.apache.lucene.util.LuceneTestCase;
import org.apache.lucene.util._TestUtil;
import org.junit.Ignore;
import java.util.ArrayList;
import java.util.Comparator;
import java.util.List;
import java.util.Random;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.fail;
/**
* Base class for grouping related tests.
*/
// TODO (MvG) : The grouping tests contain a lot of code duplication. Try to move the common code to this class..
@Ignore("Maven Surefire will attempt to run this test suite without an @Ignore annotation.")
public class AbstractGroupingTestCase extends LuceneTestCase {
public abstract class AbstractGroupingTestCase extends LuceneTestCase {
protected String generateRandomNonEmptyString() {
String randomValue;
do {
@ -50,5 +34,4 @@ public class AbstractGroupingTestCase extends LuceneTestCase {
} while ("".equals(randomValue));
return randomValue;
}
}