Apache
/
lucene
mirror of https://github.com/apache/lucene.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

LUCENE-5207: More strict checks for invalid method signatures (currently only double is accepted as parameter or return type). The method must be static, too. 

git-svn-id: https://svn.apache.org/repos/asf/lucene/dev/branches/lucene5207@1522813 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Uwe Schindler 2013-09-13 08:37:10 +00:00
parent 75382a1444
commit a62a5ce2ad
1 changed files with 17 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
lucene/expressions/src/java/org/apache/lucene/expressions/js/JavascriptFunction.java
View File

@ -19,6 +19,7 @@ package org.apache.lucene.expressions.js;
import java.util.HashMap; import java.util.HashMap;
import java.util.Map; import java.util.Map;
import java.lang.reflect.Method; import java.lang.reflect.Method;
import java.lang.reflect.Modifier;
import org.apache.lucene.util.MathUtil; import org.apache.lucene.util.MathUtil;
import org.objectweb.asm.Type; import org.objectweb.asm.Type;
@ -86,8 +87,23 @@ class JavascriptFunction {
public final String signature; public final String signature;
private JavascriptFunction(String call, Method method) { private JavascriptFunction(String call, Method method) {
// do some checks if the signature is "compatible":
if (!Modifier.isStatic(method.getModifiers())) {
throw new Error(method + " is not static.");
}
if (method.getReturnType() != double.class) {
throw new Error(method + " does not return a double.");
}
final Class<?>[] paramTypes = method.getParameterTypes();
for (final Class<?> paramType : paramTypes) {
if (paramType != double.class) {
throw new Error(method + " may only take parameters of type 'double'.");
}
}
this.call = call; this.call = call;
this.arguments = method.getParameterTypes().length; this.arguments = paramTypes.length;
this.klass = Type.getInternalName(method.getDeclaringClass()); this.klass = Type.getInternalName(method.getDeclaringClass());
this.method = method.getName(); this.method = method.getName();
this.signature = Type.getMethodDescriptor(method); this.signature = Type.getMethodDescriptor(method);