Apache
/
lucene
mirror of https://github.com/apache/lucene.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

SOLR-12028: BadApple and AwaitsFix annotations usage

This commit is contained in:
Erick 2018-03-03 21:42:14 -08:00
parent 78f11d05ac
commit ad7e94afb2
40 changed files with 51 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
lucene/analysis/common/src/test/org/apache/lucene/analysis/core/TestRandomChains.java
View File

@ -843,6 +843,7 @@ public class TestRandomChains extends BaseTokenStreamTestCase {
String toString;
}
@BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028")
public void testRandomChains() throws Throwable {
int numIterations = TEST_NIGHTLY ? atLeast(20) : 3;
Random random = random();

1
lucene/analysis/kuromoji/src/test/org/apache/lucene/analysis/ja/TestJapaneseIterationMarkCharFilter.java
View File

@ -28,6 +28,7 @@ import java.io.IOException;
import java.io.Reader;
import java.io.StringReader;
// See: https://issues.apache.org/jira/browse/SOLR-12028 Tests cannot remove files on Windows machines occasionally
public class TestJapaneseIterationMarkCharFilter extends BaseTokenStreamTestCase {
private Analyzer keywordAnalyzer, japaneseAnalyzer;

1
lucene/backward-codecs/src/test/org/apache/lucene/index/TestBackwardsCompatibility.java
View File

@ -87,6 +87,7 @@ import org.junit.BeforeClass;
Verify we can read previous versions' indexes, do searches
against them, and add documents to them.
*/
// See: https://issues.apache.org/jira/browse/SOLR-12028 Tests cannot remove files on Windows machines occasionally
public class TestBackwardsCompatibility extends LuceneTestCase {
// Backcompat index generation, described below, is mostly automated in:

2
lucene/core/src/test/org/apache/lucene/index/TestDemoParallelLeafReader.java
View File

@ -82,7 +82,7 @@ import org.apache.lucene.util.Version;
* since they will just be regnerated (at a cost though). */
// @SuppressSysoutChecks(bugUrl="we print stuff")
// See: https://issues.apache.org/jira/browse/SOLR-12028 Tests cannot remove files on Windows machines occasionally
public class TestDemoParallelLeafReader extends LuceneTestCase {
static final boolean DEBUG = false;

3
lucene/core/src/test/org/apache/lucene/search/TestLRUQueryCache.java
View File

@ -62,6 +62,7 @@ import org.apache.lucene.util.IOUtils;
import org.apache.lucene.util.LuceneTestCase;
import org.apache.lucene.util.RamUsageTester;
import org.apache.lucene.util.TestUtil;
import org.junit.Test;
public class TestLRUQueryCache extends LuceneTestCase {
@ -1467,6 +1468,8 @@ public class TestLRUQueryCache extends LuceneTestCase {
}
}
@Test
@BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028")
public void testDocValuesUpdatesDontBreakCache() throws IOException {
Directory dir = newDirectory();
IndexWriterConfig iwc = newIndexWriterConfig().setMergePolicy(NoMergePolicy.INSTANCE);

1
lucene/core/src/test/org/apache/lucene/search/TestLongRangeFieldQueries.java
View File

@ -28,6 +28,7 @@ import org.apache.lucene.util.TestUtil;
/**
* Random testing for LongRange Queries.
*/
// See: https://issues.apache.org/jira/browse/SOLR-12028 Tests cannot remove files on Windows machines occasionally
public class TestLongRangeFieldQueries extends BaseRangeFieldQueryTestCase {
private static final String FIELD_NAME = "longRangeField";

1
lucene/core/src/test/org/apache/lucene/store/TestFileSwitchDirectory.java
View File

@ -33,6 +33,7 @@ import org.apache.lucene.index.IndexWriterConfig;
import org.apache.lucene.index.TestIndexWriterReader;
import org.apache.lucene.util.TestUtil;
// See: https://issues.apache.org/jira/browse/SOLR-12028 Tests cannot remove files on Windows machines occasionally
public class TestFileSwitchDirectory extends BaseDirectoryTestCase {
/**

1
lucene/core/src/test/org/apache/lucene/store/TestMmapDirectory.java
View File

@ -27,6 +27,7 @@ import org.junit.Ignore;
/**
* Tests MMapDirectory
*/
// See: https://issues.apache.org/jira/browse/SOLR-12028 Tests cannot remove files on Windows machines occasionally
public class TestMmapDirectory extends BaseDirectoryTestCase {
@Override

1
lucene/misc/src/test/org/apache/lucene/store/TestHardLinkCopyDirectoryWrapper.java
View File

@ -26,6 +26,7 @@ import java.util.Collections;
import org.apache.lucene.codecs.CodecUtil;
import org.apache.lucene.util.IOUtils;
// See: https://issues.apache.org/jira/browse/SOLR-12028 Tests cannot remove files on Windows machines occasionally
public class TestHardLinkCopyDirectoryWrapper extends BaseDirectoryTestCase {
@Override

1
lucene/misc/src/test/org/apache/lucene/store/TestRAFDirectory.java
View File

@ -22,6 +22,7 @@ import java.nio.file.Path;
/**
* Tests RAFDirectory
*/
// See: https://issues.apache.org/jira/browse/SOLR-12028 Tests cannot remove files on Windows machines occasionally
public class TestRAFDirectory extends BaseDirectoryTestCase {
@Override

1
lucene/suggest/src/test/org/apache/lucene/search/suggest/DocumentDictionaryTest.java
View File

@ -47,6 +47,7 @@ import org.apache.lucene.util.IOUtils;
import org.apache.lucene.util.LuceneTestCase;
import org.junit.Test;
// See: https://issues.apache.org/jira/browse/SOLR-12028 Tests cannot remove files on Windows machines occasionally
public class DocumentDictionaryTest extends LuceneTestCase {
static final String FIELD_NAME = "f1";

1
lucene/test-framework/src/test/org/apache/lucene/store/TestMockDirectoryWrapper.java
View File

@ -25,6 +25,7 @@ import java.nio.file.Path;
import org.apache.lucene.document.Document;
import org.apache.lucene.index.RandomIndexWriter;
// See: https://issues.apache.org/jira/browse/SOLR-12028 Tests cannot remove files on Windows machines occasionally
public class TestMockDirectoryWrapper extends BaseDirectoryTestCase {
@Override

1
solr/contrib/analysis-extras/src/test/org/apache/solr/analysis/TestFoldingMultitermExtrasQuery.java
View File

@ -23,6 +23,7 @@ import org.apache.solr.SolrTestCaseJ4;
import org.junit.BeforeClass;
import org.junit.Test;
// See: https://issues.apache.org/jira/browse/SOLR-12028 Tests cannot remove files on Windows machines occasionally
public class TestFoldingMultitermExtrasQuery extends SolrTestCaseJ4 {
public String getCoreName() {

1
solr/contrib/dataimporthandler/src/test/org/apache/solr/handler/dataimport/TestDocBuilder.java
View File

@ -33,6 +33,7 @@ import java.util.*;
*
* @since solr 1.3
*/
// See: https://issues.apache.org/jira/browse/SOLR-12028 Tests cannot remove files on Windows machines occasionally
public class TestDocBuilder extends AbstractDataImportHandlerTestCase {
@Override

1
solr/core/src/test/org/apache/solr/DistributedIntervalFacetingTest.java
View File

@ -30,6 +30,7 @@ import org.junit.Test;
@Slow
@SuppressSSL(bugUrl="https://issues.apache.org/jira/browse/SOLR-9182 - causes OOM")
// See: https://issues.apache.org/jira/browse/SOLR-12028 Tests cannot remove files on Windows machines occasionally
public class DistributedIntervalFacetingTest extends
BaseDistributedSearchTestCase {

3
solr/core/src/test/org/apache/solr/cloud/AliasIntegrationTest.java
View File

@ -93,6 +93,7 @@ public class AliasIntegrationTest extends SolrCloudTestCase {
}
@Test
@BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028")
public void testMetadata() throws Exception {
CollectionAdminRequest.createCollection("collection1meta", "conf", 2, 1).process(cluster.getSolrClient());
CollectionAdminRequest.createCollection("collection2meta", "conf", 1, 1).process(cluster.getSolrClient());
@ -251,6 +252,8 @@ public class AliasIntegrationTest extends SolrCloudTestCase {
checkFooAndBarMeta(aliasName, zkStateReader);
}
@Test
@BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028")
public void testModifyMetadataCAR() throws Exception {
// note we don't use TZ in this test, thus it's UTC
final String aliasName = getTestName();

1
solr/core/src/test/org/apache/solr/cloud/ChaosMonkeySafeLeaderTest.java
View File

@ -81,6 +81,7 @@ public class ChaosMonkeySafeLeaderTest extends AbstractFullDistribZkTestBase {
}
@Test
@BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028")
public void test() throws Exception {
handle.clear();

1
solr/core/src/test/org/apache/solr/cloud/ChaosMonkeySafeLeaderWithPullReplicasTest.java
View File

@ -112,6 +112,7 @@ public class ChaosMonkeySafeLeaderWithPullReplicasTest extends AbstractFullDistr
}
@Test
@BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028")
public void test() throws Exception {
DocCollection docCollection = cloudClient.getZkStateReader().getClusterState().getCollection(DEFAULT_COLLECTION);
assertEquals(this.sliceCount, docCollection.getSlices().size());

1
solr/core/src/test/org/apache/solr/cloud/ForceLeaderTest.java
View File

@ -76,6 +76,7 @@ public class ForceLeaderTest extends HttpPartitionTest {
*/
@Test
@Slow
@BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028")
public void testReplicasInLowerTerms() throws Exception {
handle.put("maxScore", SKIPVAL);
handle.put("timestamp", SKIPVAL);

1
solr/core/src/test/org/apache/solr/cloud/LegacyCloudClusterPropTest.java
View File

@ -65,6 +65,7 @@ public class LegacyCloudClusterPropTest extends SolrCloudTestCase {
};
@Test
@BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028")
public void testCreateCollectionSwitchLegacyCloud() throws Exception {
createAndTest("legacyTrue", true);
createAndTest("legacyFalse", false);

1
solr/core/src/test/org/apache/solr/cloud/MissingSegmentRecoveryTest.java
View File

@ -89,6 +89,7 @@ public class MissingSegmentRecoveryTest extends SolrCloudTestCase {
}
@Test
@BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028")
public void testLeaderRecovery() throws Exception {
System.setProperty("CoreInitFailedAction", "fromleader");

1
solr/core/src/test/org/apache/solr/cloud/MultiThreadedOCPTest.java
View File

@ -58,6 +58,7 @@ public class MultiThreadedOCPTest extends AbstractFullDistribZkTestBase {
}
@Test
@BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028")
@ShardsFixed(num = 4)
public void test() throws Exception {
testParallelCollectionAPICalls();

2
solr/core/src/test/org/apache/solr/cloud/TestStressCloudBlindAtomicUpdates.java
View File

@ -185,6 +185,8 @@ public class TestStressCloudBlindAtomicUpdates extends SolrCloudTestCase {
}
@Test
@BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028")
public void test_dv() throws Exception {
String field = "long_dv";
checkExpectedSchemaField(map("name", field,

2
solr/core/src/test/org/apache/solr/cloud/ZkShardTermsTest.java
View File

@ -51,6 +51,8 @@ public class ZkShardTermsTest extends SolrCloudTestCase {
.configure();
}
@Test
@BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028")
public void testParticipationOfReplicas() throws IOException, SolrServerException, InterruptedException {
String collection = "collection1";
try (ZkShardTerms zkShardTerms = new ZkShardTerms(collection, "shard2", cluster.getZkClient())) {

2
solr/core/src/test/org/apache/solr/cloud/api/collections/CollectionsAPIDistributedZkTest.java
View File

@ -420,6 +420,8 @@ public class CollectionsAPIDistributedZkTest extends SolrCloudTestCase {
}
@Test
@BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028")
// See: https://issues.apache.org/jira/browse/SOLR-12028 Tests cannot remove files on Windows machines occasionally
public void testCollectionsAPI() throws Exception {
// create new collections rapid fire

2
solr/core/src/test/org/apache/solr/cloud/api/collections/ShardSplitTest.java
View File

@ -258,6 +258,7 @@ public class ShardSplitTest extends BasicDistributedZkTest {
* See SOLR-9439
*/
@Test
@BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028")
public void testSplitAfterFailedSplit() throws Exception {
waitForThingsToLevelOut(15);
@ -304,6 +305,7 @@ public class ShardSplitTest extends BasicDistributedZkTest {
}
@Test
@BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028")
public void testSplitWithChaosMonkey() throws Exception {
waitForThingsToLevelOut(15);

1
solr/core/src/test/org/apache/solr/cloud/api/collections/TestCollectionsAPIViaSolrCloudCluster.java
View File

@ -94,6 +94,7 @@ public class TestCollectionsAPIViaSolrCloudCluster extends SolrCloudTestCase {
}
@Test
@BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028")
public void testCollectionCreateSearchDelete() throws Exception {
final CloudSolrClient client = cluster.getSolrClient();
final String collectionName = "testcollection";

1
solr/core/src/test/org/apache/solr/cloud/autoscaling/AutoAddReplicasPlanActionTest.java
View File

@ -54,6 +54,7 @@ public class AutoAddReplicasPlanActionTest extends SolrCloudTestCase{
}
@Test
@BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028")
public void testSimple() throws Exception {
JettySolrRunner jetty1 = cluster.getJettySolrRunner(0);
JettySolrRunner jetty2 = cluster.getJettySolrRunner(1);

1
solr/core/src/test/org/apache/solr/cloud/autoscaling/ScheduledTriggerTest.java
View File

@ -57,6 +57,7 @@ public class ScheduledTriggerTest extends SolrCloudTestCase {
}
@Test
@BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028")
public void testTrigger() throws Exception {
CoreContainer container = cluster.getJettySolrRunners().get(0).getCoreContainer();

2
solr/core/src/test/org/apache/solr/cloud/autoscaling/sim/TestTriggerIntegration.java
View File

@ -255,6 +255,7 @@ public class TestTriggerIntegration extends SimSolrCloudTestCase {
}
@Test
@BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028")
public void testNodeLostTriggerRestoreState() throws Exception {
// for this test we want to update the trigger so we must assert that the actions were created twice
TestTriggerIntegration.actionInitCalled = new CountDownLatch(2);
@ -756,6 +757,7 @@ public class TestTriggerIntegration extends SimSolrCloudTestCase {
}
@Test
@BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028")
public void testNodeMarkersRegistration() throws Exception {
// for this test we want to create two triggers so we must assert that the actions were created twice
actionInitCalled = new CountDownLatch(2);

1
solr/core/src/test/org/apache/solr/core/TestConfigSetImmutable.java
View File

@ -36,6 +36,7 @@ import org.noggit.ObjectBuilder;
* Test that a ConfigSet marked as immutable cannot be modified via
* the known APIs, i.e. SolrConfigHandler and SchemaHandler.
*/
// See: https://issues.apache.org/jira/browse/SOLR-12028 Tests cannot remove files on Windows machines occasionally
public class TestConfigSetImmutable extends RestTestBase {
private static final String collection = "collection1";

1
solr/core/src/test/org/apache/solr/core/TestDynamicLoading.java
View File

@ -45,6 +45,7 @@ public class TestDynamicLoading extends AbstractFullDistribZkTestBase {
}
@Test
@BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028")
public void testDynamicLoading() throws Exception {
System.setProperty("enable.runtime.lib", "true");
setupRestTestHarnesses();

1
solr/core/src/test/org/apache/solr/core/TestSolrIndexConfig.java
View File

@ -27,6 +27,7 @@ import org.apache.solr.util.RandomMergePolicy;
import org.apache.solr.update.LoggingInfoStream;
import org.junit.BeforeClass;
// See: https://issues.apache.org/jira/browse/SOLR-12028 Tests cannot remove files on Windows machines occasionally
public class TestSolrIndexConfig extends SolrTestCaseJ4 {
@BeforeClass

1
solr/core/src/test/org/apache/solr/handler/component/DistributedQueryElevationComponentTest.java
View File

@ -35,6 +35,7 @@ import org.junit.Test;
/**
*
*/
// See: https://issues.apache.org/jira/browse/SOLR-12028 Tests cannot remove files on Windows machines occasionally
public class DistributedQueryElevationComponentTest extends BaseDistributedSearchTestCase {
@BeforeClass

1
solr/core/src/test/org/apache/solr/rest/schema/analysis/TestManagedSynonymGraphFilterFactory.java
View File

@ -36,6 +36,7 @@ import org.junit.Test;
import org.noggit.JSONUtil;
import org.restlet.ext.servlet.ServerServlet;
// See: https://issues.apache.org/jira/browse/SOLR-12028 Tests cannot remove files on Windows machines occasionally
public class TestManagedSynonymGraphFilterFactory extends RestTestBase {
private static File tmpSolrHome;

1
solr/core/src/test/org/apache/solr/schema/TestCloudSchemaless.java
View File

@ -44,6 +44,7 @@ import java.util.function.UnaryOperator;
* Tests a schemaless collection configuration with SolrCloud
*/
@SuppressSSL(bugUrl = "https://issues.apache.org/jira/browse/SOLR-5776")
// See: https://issues.apache.org/jira/browse/SOLR-12028 Tests cannot remove files on Windows machines occasionally
public class TestCloudSchemaless extends AbstractFullDistribZkTestBase {
private static final Logger log = LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());
private static final String SUCCESS_XPATH = "/response/lst[@name='responseHeader']/int[@name='status'][.='0']";

1
solr/core/src/test/org/apache/solr/schema/TestUseDocValuesAsStored2.java
View File

@ -32,6 +32,7 @@ import org.noggit.ObjectBuilder;
/**
* Tests the useDocValuesAsStored functionality.
*/
// See: https://issues.apache.org/jira/browse/SOLR-12028 Tests cannot remove files on Windows machines occasionally
public class TestUseDocValuesAsStored2 extends RestTestBase {
@Before

1
solr/core/src/test/org/apache/solr/search/stats/TestDefaultStatsCache.java
View File

@ -23,6 +23,7 @@ import org.apache.solr.common.SolrDocumentList;
import org.apache.solr.common.params.ModifiableSolrParams;
import org.junit.Test;
// See: https://issues.apache.org/jira/browse/SOLR-12028 Tests cannot remove files on Windows machines occasionally
public class TestDefaultStatsCache extends BaseDistributedSearchTestCase {
private int docId = 0;

1
solr/core/src/test/org/apache/solr/update/SolrCmdDistributorTest.java
View File

@ -56,6 +56,7 @@ import org.junit.BeforeClass;
import org.junit.Test;
import org.xml.sax.SAXException;
// See: https://issues.apache.org/jira/browse/SOLR-12028 Tests cannot remove files on Windows machines occasionally
public class SolrCmdDistributorTest extends BaseDistributedSearchTestCase {
private AtomicInteger id = new AtomicInteger();

2
solr/solrj/src/test/org/apache/solr/client/solrj/request/TestV2Request.java
View File

@ -56,6 +56,7 @@ public class TestV2Request extends SolrCloudTestCase {
}
@Test
@BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028")
public void testHttpSolrClient() throws Exception {
HttpSolrClient solrClient = new HttpSolrClient.Builder(
cluster.getJettySolrRunner(0).getBaseUrl().toString()).build();
@ -64,6 +65,7 @@ public class TestV2Request extends SolrCloudTestCase {
}
@Test
@BadApple(bugUrl="https://issues.apache.org/jira/browse/SOLR-12028")
public void testCloudSolrClient() throws Exception {
doTest(cluster.getSolrClient());
}