Apache
/
lucene
mirror of https://github.com/apache/lucene.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

workaround for J9 1.7.0, probably JIT, bug 

git-svn-id: https://svn.apache.org/repos/asf/lucene/dev/trunk@1437340 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Shai Erera 2013-01-23 11:03:06 +00:00
parent 883e3501de
commit af97b15f10
1 changed files with 20 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/CategoryPath.java
View File

@ -1,5 +1,7 @@
package org.apache.lucene.facet.taxonomy; package org.apache.lucene.facet.taxonomy;
import org.apache.lucene.util.Constants;
/* /*
* Licensed to the Apache Software Foundation (ASF) under one or more * Licensed to the Apache Software Foundation (ASF) under one or more
@ -26,6 +28,10 @@ package org.apache.lucene.facet.taxonomy;
*/ */
public class CategoryPath implements Comparable<CategoryPath> { public class CategoryPath implements Comparable<CategoryPath> {
// TODO: revisit when IBM releases Java 7 newer than SR3 (with a fix)
// to validate, run e.g. TestAssociationExample with -Dtests.iters=1000
private static final boolean IS_J9_JAVA7 = Constants.JRE_IS_MINIMUM_JAVA7 && Constants.JVM_VENDOR.contains("IBM");
/** An empty {@link CategoryPath} */ /** An empty {@link CategoryPath} */
public static final CategoryPath EMPTY = new CategoryPath(); public static final CategoryPath EMPTY = new CategoryPath();
@ -47,7 +53,7 @@ public class CategoryPath implements Comparable<CategoryPath> {
} }
// Used by subpath // Used by subpath
private CategoryPath(CategoryPath copyFrom, int prefixLen) { private CategoryPath(final CategoryPath copyFrom, final int prefixLen) {
// while the code which calls this method is safe, at some point a test // while the code which calls this method is safe, at some point a test
// tripped on AIOOBE in toString, but we failed to reproduce. adding the // tripped on AIOOBE in toString, but we failed to reproduce. adding the
// assert as a safety check. // assert as a safety check.
@ -59,14 +65,23 @@ public class CategoryPath implements Comparable<CategoryPath> {
} }
/** Construct from the given path components. */ /** Construct from the given path components. */
public CategoryPath(String... components) { public CategoryPath(final String... components) {
assert components.length > 0 : "use CategoryPath.EMPTY to create an empty path"; assert components.length > 0 : "use CategoryPath.EMPTY to create an empty path";
this.components = components; if (IS_J9_JAVA7) {
// On IBM J9 Java 1.7.0, if we do 'this.components = components', then
// at some point its length becomes 0 ... quite unexpectedly. If JIT is
// disabled, it doesn't happen. This bypasses the bug by copying the
// array (note, Arrays.copyOf did not help either!).
this.components = new String[components.length];
System.arraycopy(components, 0, this.components, 0, components.length);
} else {
this.components = components;
}
length = components.length; length = components.length;
} }
/** Construct from a given path, separating path components with {@code delimiter}. */ /** Construct from a given path, separating path components with {@code delimiter}. */
public CategoryPath(String pathString, char delimiter) { public CategoryPath(final String pathString, final char delimiter) {
String[] comps = pathString.split(Character.toString(delimiter)); String[] comps = pathString.split(Character.toString(delimiter));
if (comps.length == 1 && comps[0].isEmpty()) { if (comps.length == 1 && comps[0].isEmpty()) {
components = EMPTY.components; components = EMPTY.components;
@ -186,7 +201,7 @@ public class CategoryPath implements Comparable<CategoryPath> {
} }
/** Returns a sub-path of this path up to {@code length} components. */ /** Returns a sub-path of this path up to {@code length} components. */
public CategoryPath subpath(int length) { public CategoryPath subpath(final int length) {
if (length >= this.length || length < 0) { if (length >= this.length || length < 0) {
return this; return this;
} else if (length == 0) { } else if (length == 0) {