Apache
/
lucene
mirror of https://github.com/apache/lucene.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

LUCENE-7080: Sort files to corrupt to prevent HashSet iteration order issues across JVMs

This commit is contained in:
Simon Willnauer 2016-03-09 10:56:13 +01:00
parent 885ad49105
commit b4eb4fb32c
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
lucene/test-framework/src/java/org/apache/lucene/store/MockDirectoryWrapper.java
View File

@ -45,6 +45,7 @@ import org.apache.lucene.index.IndexWriter;
import org.apache.lucene.index.IndexWriterConfig; import org.apache.lucene.index.IndexWriterConfig;
import org.apache.lucene.index.NoDeletionPolicy; import org.apache.lucene.index.NoDeletionPolicy;
import org.apache.lucene.index.SegmentInfos; import org.apache.lucene.index.SegmentInfos;
import org.apache.lucene.util.CollectionUtil;
import org.apache.lucene.util.IOUtils; import org.apache.lucene.util.IOUtils;
import org.apache.lucene.util.LuceneTestCase; import org.apache.lucene.util.LuceneTestCase;
import org.apache.lucene.util.TestUtil; import org.apache.lucene.util.TestUtil;
@ -296,7 +297,11 @@ public class MockDirectoryWrapper extends BaseDirectoryWrapper {
public synchronized void corruptFiles(Collection<String> files) throws IOException { public synchronized void corruptFiles(Collection<String> files) throws IOException {
// Must make a copy because we change the incoming unsyncedFiles // Must make a copy because we change the incoming unsyncedFiles
// when we create temp files, delete, etc., below: // when we create temp files, delete, etc., below:
for(String name : new ArrayList<>(files)) { final List<String> filesToCorrupt = new ArrayList<>(files);
// sort the files otherwise we have reproducibility issues
// across JVMs if the incoming collection is a hashSet etc.
CollectionUtil.timSort(filesToCorrupt);
for(String name : filesToCorrupt) {
int damage = randomState.nextInt(6); int damage = randomState.nextInt(6);
String action = null; String action = null;