Apache
/
lucene
mirror of https://github.com/apache/lucene.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

LUCENE-5207: check the class too 

git-svn-id: https://svn.apache.org/repos/asf/lucene/dev/branches/lucene5207@1523301 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Robert Muir 2013-09-14 19:40:20 +00:00
parent 591a3b1ca1
commit b56c58884f
2 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
lucene/expressions/src/java/org/apache/lucene/expressions/js/JavascriptCompiler.java
View File

@ -715,6 +715,9 @@ public class JavascriptCompiler {
if (!Modifier.isPublic(method.getModifiers())) { if (!Modifier.isPublic(method.getModifiers())) {
throw new IllegalArgumentException(method + " is not public."); throw new IllegalArgumentException(method + " is not public.");
} }
if (!Modifier.isPublic(method.getDeclaringClass().getModifiers())) {
throw new IllegalArgumentException(method.getDeclaringClass().getName() + " is not public.");
}
for (Class<?> clazz : method.getParameterTypes()) { for (Class<?> clazz : method.getParameterTypes()) {
if (!clazz.equals(double.class)) { if (!clazz.equals(double.class)) {
throw new IllegalArgumentException(method + " must take only double parameters"); throw new IllegalArgumentException(method + " must take only double parameters");

15
lucene/expressions/src/test/org/apache/lucene/expressions/js/TestCustomFunctions.java
View File

@ -141,4 +141,19 @@ public class TestCustomFunctions extends LuceneTestCase {
assertTrue(e.getMessage().contains("is not public")); assertTrue(e.getMessage().contains("is not public"));
} }
} }
static class NestedNotPublic {
public static double method() { return 0; }
}
/** wrong class modifiers: class containing method is not public */
public void testWrongNestedNotPublic() throws Exception {
Map<String,Method> functions = new HashMap<String,Method>();
functions.put("foo", NestedNotPublic.class.getMethod("method"));
try {
JavascriptCompiler.compile("foo()", functions, getClass().getClassLoader());
} catch (IllegalArgumentException e) {
assertTrue(e.getMessage().contains("is not public"));
}
}
} }