Apache
/
lucene
mirror of https://github.com/apache/lucene.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix nocommits 

git-svn-id: https://svn.apache.org/repos/asf/lucene/dev/branches/lucene4547@1438568 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Michael McCandless 2013-01-25 16:01:34 +00:00
parent 12cfd1f840
commit b7bcad0360
3 changed files with 7 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lucene/core/src/java/org/apache/lucene/codecs/DocValuesConsumer.java
View File

@ -77,7 +77,7 @@ public abstract class DocValuesConsumer implements Closeable {
} }
assert nextIsSet; assert nextIsSet;
nextIsSet = false; nextIsSet = false;
// nocommit make a mutable number // TODO: make a mutable number
return nextValue; return nextValue;
} }
@ -146,7 +146,7 @@ public abstract class DocValuesConsumer implements Closeable {
} }
assert nextIsSet; assert nextIsSet;
nextIsSet = false; nextIsSet = false;
// nocommit make a mutable number // TODO: make a mutable number
return nextValue; return nextValue;
} }

5
lucene/core/src/java/org/apache/lucene/index/DocValuesProcessor.java
View File

@ -30,8 +30,9 @@ import org.apache.lucene.util.IOUtils;
final class DocValuesProcessor extends StoredFieldsConsumer { final class DocValuesProcessor extends StoredFieldsConsumer {
// nocommit wasteful we also keep a map ... double the // TODO: somewhat wasteful we also keep a map here; would
// hash lookups ... would be better if DFP had "the one map"? // be more efficient if we could "reuse" the map/hash
// lookup DocFieldProcessor already did "above"
private final Map<String,DocValuesWriter> writers = new HashMap<String,DocValuesWriter>(); private final Map<String,DocValuesWriter> writers = new HashMap<String,DocValuesWriter>();
private final Counter bytesUsed; private final Counter bytesUsed;

9
lucene/core/src/java/org/apache/lucene/index/TwoStoredFieldsConsumers.java
View File

@ -62,12 +62,7 @@ class TwoStoredFieldsConsumers extends StoredFieldsConsumer {
@Override @Override
void finishDocument() throws IOException { void finishDocument() throws IOException {
// nocommit must this be a try/finally...? i'd prefer first.finishDocument();
// not ... second.finishDocument();
try {
first.finishDocument();
} finally {
second.finishDocument();
}
} }
} }