From bd3f30b9a90654c2e34e5cda5f3056c234f8bec3 Mon Sep 17 00:00:00 2001 From: Erick Date: Fri, 23 Feb 2018 12:49:26 -0800 Subject: [PATCH] SOLR-12017: Remove BadApple and AwaitsFix annotations that link to closed JIRAs --- solr/CHANGES.txt | 2 ++ solr/core/src/test/org/apache/solr/cloud/MoveReplicaTest.java | 4 ++-- .../apache/solr/cloud/TestSolrCloudWithDelegationTokens.java | 3 ++- .../apache/solr/cloud/autoscaling/TriggerIntegrationTest.java | 1 + .../solr/security/hadoop/TestDelegationWithHadoopAuth.java | 3 ++- 5 files changed, 9 insertions(+), 4 deletions(-) diff --git a/solr/CHANGES.txt b/solr/CHANGES.txt index df7db59b977..f6f7454d7a1 100644 --- a/solr/CHANGES.txt +++ b/solr/CHANGES.txt @@ -314,6 +314,8 @@ Other Changes * SOLR-11897: Add toggle to disable auto-refresh of Logging page in the UI (Tommy Marshment-Howell via Cassandra Targett) +* SOLR-12017: Remove BadApple and AwaitsFix annotations that link to closed JIRAs (Erick Erickson) + ================== 7.2.1 ================== Consult the LUCENE_CHANGES.txt file for additional, low level, changes in this release. diff --git a/solr/core/src/test/org/apache/solr/cloud/MoveReplicaTest.java b/solr/core/src/test/org/apache/solr/cloud/MoveReplicaTest.java index 631d94992a0..b43268ce6bb 100644 --- a/solr/core/src/test/org/apache/solr/cloud/MoveReplicaTest.java +++ b/solr/core/src/test/org/apache/solr/cloud/MoveReplicaTest.java @@ -248,8 +248,8 @@ public class MoveReplicaTest extends SolrCloudTestCase { assertEquals(100, cluster.getSolrClient().query(coll, new SolrQuery("*:*")).getResults().getNumFound()); } - - // @AwaitsFix(bugUrl = "https://issues.apache.org/jira/browse/SOLR-11458") + //Commented out 5-Dec-2017 + // @AwaitsFix(bugUrl = "https://issues.apache.org/jira/browse/SOLR-11458") @Test public void testFailedMove() throws Exception { String coll = getTestClass().getSimpleName() + "_failed_coll_" + inPlaceMove; diff --git a/solr/core/src/test/org/apache/solr/cloud/TestSolrCloudWithDelegationTokens.java b/solr/core/src/test/org/apache/solr/cloud/TestSolrCloudWithDelegationTokens.java index ddbbb649f72..8addff2b020 100644 --- a/solr/core/src/test/org/apache/solr/cloud/TestSolrCloudWithDelegationTokens.java +++ b/solr/core/src/test/org/apache/solr/cloud/TestSolrCloudWithDelegationTokens.java @@ -282,7 +282,8 @@ public class TestSolrCloudWithDelegationTokens extends SolrTestCaseJ4 { } @Test - @AwaitsFix(bugUrl="https://issues.apache.org/jira/browse/HADOOP-14044") + // Commented out 22-Feb-2018 + //@AwaitsFix(bugUrl="https://issues.apache.org/jira/browse/HADOOP-14044") public void testDelegationTokenCancelFail() throws Exception { // cancel a bogus token cancelDelegationToken("BOGUS", ErrorCode.NOT_FOUND.code, solrClientPrimary); diff --git a/solr/core/src/test/org/apache/solr/cloud/autoscaling/TriggerIntegrationTest.java b/solr/core/src/test/org/apache/solr/cloud/autoscaling/TriggerIntegrationTest.java index 2540606f851..79fb96949df 100644 --- a/solr/core/src/test/org/apache/solr/cloud/autoscaling/TriggerIntegrationTest.java +++ b/solr/core/src/test/org/apache/solr/cloud/autoscaling/TriggerIntegrationTest.java @@ -1402,6 +1402,7 @@ public class TriggerIntegrationTest extends SolrCloudTestCase { } @Test + //Commented out 24-Jan-2018 //@AwaitsFix(bugUrl = "https://issues.apache.org/jira/browse/SOLR-11714") public void testSearchRate() throws Exception { // start a few more jetty-s diff --git a/solr/core/src/test/org/apache/solr/security/hadoop/TestDelegationWithHadoopAuth.java b/solr/core/src/test/org/apache/solr/security/hadoop/TestDelegationWithHadoopAuth.java index 37d9cdf1a9c..cbe13ba32b1 100644 --- a/solr/core/src/test/org/apache/solr/security/hadoop/TestDelegationWithHadoopAuth.java +++ b/solr/core/src/test/org/apache/solr/security/hadoop/TestDelegationWithHadoopAuth.java @@ -268,7 +268,8 @@ public class TestDelegationWithHadoopAuth extends SolrCloudTestCase { } @Test - @AwaitsFix(bugUrl="https://issues.apache.org/jira/browse/HADOOP-14044") + // Commented out 22-Feb-2018 + // @AwaitsFix(bugUrl="https://issues.apache.org/jira/browse/HADOOP-14044") public void testDelegationTokenCancelFail() throws Exception { // cancel a bogus token cancelDelegationToken("BOGUS", ErrorCode.NOT_FOUND.code, primarySolrClient);