SOLR-3141: Warn in logs when expensive optimize calls are made

This commit is contained in:
Jan Høydahl 2016-02-09 15:37:25 +01:00
parent e9c90037aa
commit be807919b6
2 changed files with 8 additions and 0 deletions

View File

@ -668,6 +668,8 @@ Other Changes
* SOLR-8308: Core gets inaccessible after RENAME operation with special characters
(Erik Hatcher, Erick Erickson)
* SOLR-3141: Warn in logs when expensive optimize calls are made (yonik, janhoy)
================== 5.4.1 ==================
Bug Fixes

View File

@ -594,8 +594,14 @@ public class DirectUpdateHandler2 extends UpdateHandler implements SolrCoreState
try {
IndexWriter writer = iw.get();
if (cmd.optimize) {
if (cmd.maxOptimizeSegments == 1) {
log.warn("Starting optimize... Reading and rewriting the entire index! Use with care.");
} else {
log.warn("Starting optimize... Reading and rewriting a potentially large percent of the entire index, reducing to " + cmd.maxOptimizeSegments + " segments");
}
writer.forceMerge(cmd.maxOptimizeSegments);
} else if (cmd.expungeDeletes) {
log.warn("Starting expungeDeletes... Reading and rewriting segments with enough deletes, potentially the entire index");
writer.forceMergeDeletes();
}