Apache
/
lucene
mirror of https://github.com/apache/lucene.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

LUCENE-8709: Set pointWriter to null when size of the HeapPointWriter is 0

This commit is contained in:
iverase 2019-03-01 10:44:07 +01:00
parent 748d483e67
commit beda852fc2
2 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lucene/core/src/java/org/apache/lucene/util/bkd/HeapPointReader.java
View File

@ -41,7 +41,7 @@ public final class HeapPointReader implements PointReader {
this.pointValue = new HeapPointValue(block, packedBytesLength); this.pointValue = new HeapPointValue(block, packedBytesLength);
} else { } else {
//no values //no values
this.pointValue = new HeapPointValue(block, 0); this.pointValue = null;
} }
} }

10
lucene/core/src/java/org/apache/lucene/util/bkd/HeapPointWriter.java
View File

@ -32,7 +32,7 @@ public final class HeapPointWriter implements PointWriter {
private int nextWrite; private int nextWrite;
private boolean closed; private boolean closed;
private HeapPointReader.HeapPointValue offlinePointValue; private HeapPointReader.HeapPointValue pointValue;
public HeapPointWriter(int size, int packedBytesLength) { public HeapPointWriter(int size, int packedBytesLength) {
@ -42,18 +42,18 @@ public final class HeapPointWriter implements PointWriter {
this.packedBytesLength = packedBytesLength; this.packedBytesLength = packedBytesLength;
this.scratch = new byte[packedBytesLength]; this.scratch = new byte[packedBytesLength];
if (size > 0) { if (size > 0) {
offlinePointValue = new HeapPointReader.HeapPointValue(block, packedBytesLength); pointValue = new HeapPointReader.HeapPointValue(block, packedBytesLength);
} else { } else {
//no values //no values
offlinePointValue = new HeapPointReader.HeapPointValue(block, 0); pointValue = null;
} }
} }
/** Returns a reference, in <code>result</code>, to the byte[] slice holding this value */ /** Returns a reference, in <code>result</code>, to the byte[] slice holding this value */
public PointValue getPackedValueSlice(int index) { public PointValue getPackedValueSlice(int index) {
assert index < nextWrite : "nextWrite=" + (nextWrite) + " vs index=" + index; assert index < nextWrite : "nextWrite=" + (nextWrite) + " vs index=" + index;
offlinePointValue.setValue(index * packedBytesLength, docIDs[index]); pointValue.setValue(index * packedBytesLength, docIDs[index]);
return offlinePointValue; return pointValue;
} }
@Override @Override