Apache
/
lucene
mirror of https://github.com/apache/lucene.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

LUCENE-8575: Improve toString() in SegmentInfo 

Signed-off-by: Namgyu Kim <kng0828@gmail.com>
Signed-off-by: Adrien Grand <jpountz@gmail.com>
This commit is contained in:
Namgyu Kim 2018-11-28 23:56:30 +09:00 committed by Adrien Grand
parent c074b97e79
commit c2ab04775d
3 changed files with 67 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
lucene/CHANGES.txt
View File

@ -231,6 +231,9 @@ Improvements
* LUCENE-8529: TopSuggestDocsCollector will now use the completion key to tiebreak completion
suggestion with identical scores. (Jim Ferenczi)
* LUCENE-8575: SegmentInfos#toString now includes attributes and diagnostics.
(Namgyu Kim via Adrien Grand)
Optimizations
* LUCENE-8552: FieldInfos.getMergedFieldInfos no longer does any merging if there is <= 1 segment.

12
lucene/core/src/java/org/apache/lucene/index/SegmentInfo.java
View File

@ -211,7 +211,17 @@ public final class SegmentInfo {
s.append(']');
}
// TODO: we could append toString of attributes() here?
if (!diagnostics.isEmpty()) {
s.append(":[diagnostics=");
s.append(diagnostics.toString());
s.append(']');
}
if (!attributes.isEmpty()) {
s.append(":[attributes=");
s.append(attributes.toString());
s.append(']');
}
return s.toString();
}

53
lucene/core/src/test/org/apache/lucene/index/TestSegmentInfos.java
View File

@ -18,7 +18,9 @@ package org.apache.lucene.index;
import org.apache.lucene.codecs.Codec;
import org.apache.lucene.search.Sort;
import org.apache.lucene.store.BaseDirectoryWrapper;
import org.apache.lucene.store.Directory;
import org.apache.lucene.store.IOContext;
import org.apache.lucene.util.LuceneTestCase;
import org.apache.lucene.util.StringHelper;
@ -26,6 +28,9 @@ import org.apache.lucene.util.Version;
import java.io.IOException;
import java.util.Collections;
import java.util.HashMap;
import java.util.LinkedHashMap;
import java.util.Map;
public class TestSegmentInfos extends LuceneTestCase {
@ -98,5 +103,53 @@ public class TestSegmentInfos extends LuceneTestCase {
assertEquals(Version.LATEST, sis.getCommitLuceneVersion());
dir.close();
}
/** Test toString method */
public void testToString() throws Throwable{
SegmentInfo si;
final Directory dir = newDirectory();
Codec codec = Codec.getDefault();
// diagnostics map
Map<String, String> diagnostics = new LinkedHashMap<>();
diagnostics.put("key1", "value1");
diagnostics.put("key2", "value2");
// attributes map
Map<String,String> attributes = new LinkedHashMap<>();
attributes.put("key1", "value1");
attributes.put("key2", "value2");
// diagnostics X, attributes X
si = new SegmentInfo(dir, Version.LATEST, Version.LATEST, "TEST", 10000, false, codec, Collections.emptyMap(), StringHelper.randomId(), new HashMap<>(), Sort.INDEXORDER);
assertEquals("TEST(" + Version.LATEST.toString() + ")" +
":C10000" +
":[indexSort=<doc>]", si.toString());
// diagnostics O, attributes X
si = new SegmentInfo(dir, Version.LATEST, Version.LATEST, "TEST", 10000, false, codec, diagnostics, StringHelper.randomId(), new HashMap<>(), Sort.INDEXORDER);
assertEquals("TEST(" + Version.LATEST.toString() + ")" +
":C10000" +
":[indexSort=<doc>]" +
":[diagnostics={key1=value1, key2=value2}]", si.toString());
// diagnostics X, attributes O
si = new SegmentInfo(dir, Version.LATEST, Version.LATEST, "TEST", 10000, false, codec, Collections.emptyMap(), StringHelper.randomId(), attributes, Sort.INDEXORDER);
assertEquals("TEST(" + Version.LATEST.toString() + ")" +
":C10000" +
":[indexSort=<doc>]" +
":[attributes={key1=value1, key2=value2}]", si.toString());
// diagnostics O, attributes O
si = new SegmentInfo(dir, Version.LATEST, Version.LATEST, "TEST", 10000, false, codec, diagnostics, StringHelper.randomId(), attributes, Sort.INDEXORDER);
System.out.println(si.toString());
assertEquals("TEST(" + Version.LATEST.toString() + ")" +
":C10000" +
":[indexSort=<doc>]" +
":[diagnostics={key1=value1, key2=value2}]" +
":[attributes={key1=value1, key2=value2}]", si.toString());
dir.close();
}
}