Apache
/
lucene
mirror of https://github.com/apache/lucene.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

SOLR-5314: Shard split action should use soft commits instead of hard commits to make sub shard data visible 

git-svn-id: https://svn.apache.org/repos/asf/lucene/dev/trunk@1530267 13f79535-47bb-0310-9956-ffa450edef68
This commit is contained in:
Shalin Shekhar Mangar 2013-10-08 13:21:54 +00:00
parent 11a5fb960c
commit c98fa19d33
2 changed files with 9 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
solr/CHANGES.txt
View File

@ -115,6 +115,9 @@ Bug Fixes
* SOLR-5305: Admin UI - Reloading System-Information on Dashboard does not work * SOLR-5305: Admin UI - Reloading System-Information on Dashboard does not work
anymore (steffkes) anymore (steffkes)
* SOLR-5314: Shard split action should use soft commits instead of hard commits
to make sub shard data visible. (Kalle Aaltonen, shalin)
Security Security
---------------------- ----------------------

12
solr/core/src/java/org/apache/solr/cloud/OverseerCollectionProcessor.java
View File

@ -699,16 +699,17 @@ public class OverseerCollectionProcessor implements Runnable, ClosableThread {
collectShardResponses(results, true, collectShardResponses(results, true,
"SPLTSHARD failed to create subshard replicas or timed out waiting for them to come up"); "SPLTSHARD failed to create subshard replicas or timed out waiting for them to come up");
log.info("Calling soft commit to make sub shard updates visible");
String coreUrl = new ZkCoreNodeProps(parentShardLeader).getCoreUrl(); String coreUrl = new ZkCoreNodeProps(parentShardLeader).getCoreUrl();
// HttpShardHandler is hard coded to send a QueryRequest hence we go direct // HttpShardHandler is hard coded to send a QueryRequest hence we go direct
// and we force open a searcher so that we have documents to show upon switching states // and we force open a searcher so that we have documents to show upon switching states
UpdateResponse updateResponse = null; UpdateResponse updateResponse = null;
try { try {
updateResponse = commit(coreUrl, true); updateResponse = softCommit(coreUrl);
processResponse(results, null, coreUrl, updateResponse, slice); processResponse(results, null, coreUrl, updateResponse, slice);
} catch (Exception e) { } catch (Exception e) {
processResponse(results, e, coreUrl, updateResponse, slice); processResponse(results, e, coreUrl, updateResponse, slice);
throw new SolrException(ErrorCode.SERVER_ERROR, "Unable to call distrib commit on: " + coreUrl, e); throw new SolrException(ErrorCode.SERVER_ERROR, "Unable to call distrib softCommit on: " + coreUrl, e);
} }
log.info("Successfully created all replica shards for all sub-slices " log.info("Successfully created all replica shards for all sub-slices "
@ -735,16 +736,15 @@ public class OverseerCollectionProcessor implements Runnable, ClosableThread {
} }
} }
static UpdateResponse commit(String url, boolean openSearcher) throws SolrServerException, IOException { static UpdateResponse softCommit(String url) throws SolrServerException, IOException {
HttpSolrServer server = null; HttpSolrServer server = null;
try { try {
server = new HttpSolrServer(url); server = new HttpSolrServer(url);
server.setConnectionTimeout(30000); server.setConnectionTimeout(30000);
server.setSoTimeout(60000); server.setSoTimeout(120000);
UpdateRequest ureq = new UpdateRequest(); UpdateRequest ureq = new UpdateRequest();
ureq.setParams(new ModifiableSolrParams()); ureq.setParams(new ModifiableSolrParams());
ureq.getParams().set(UpdateParams.OPEN_SEARCHER, openSearcher); ureq.setAction(AbstractUpdateRequest.ACTION.COMMIT, false, true, true);
ureq.setAction(AbstractUpdateRequest.ACTION.COMMIT, false, true);
return ureq.process(server); return ureq.process(server);
} finally { } finally {
if (server != null) { if (server != null) {