Apache
/
lucene
mirror of https://github.com/apache/lucene.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Rollback the tmp storage of BytesRefHash to -1 after sort (#13014)

This commit is contained in:
gf2121 2024-01-25 10:48:11 +08:00 committed by GitHub
parent 3a205feb27
commit d0098f8489
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 12 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
lucene/core/src/java/org/apache/lucene/util/BytesRefHash.java
View File

@ -214,6 +214,7 @@ public final class BytesRefHash implements Accountable {
pool.fillBytesRef(result, bytesStart[compact[i]]);
}
}.sort(0, count);
Arrays.fill(compact, tmpOffset, compact.length, -1);
return compact;
}

18
lucene/core/src/test/org/apache/lucene/util/TestBytesRefHash.java
View File

@ -176,13 +176,17 @@ public class TestBytesRefHash extends LuceneTestCase {
hash.add(ref.get());
strings.add(str);
}
int[] sort = hash.sort();
assertTrue(strings.size() < sort.length);
int i = 0;
BytesRef scratch = new BytesRef();
for (String string : strings) {
ref.copyChars(string);
assertEquals(ref.get(), hash.get(sort[i++], scratch));
for (int iter = 0; iter < 3; iter++) {
// Test duplicate sort on a BytesRefHash instance work well. This makes no sense but some
// users need that.
int[] sort = hash.sort();
assertTrue(strings.size() < sort.length);
int i = 0;
BytesRef scratch = new BytesRef();
for (String string : strings) {
ref.copyChars(string);
assertEquals(ref.get(), hash.get(sort[i++], scratch));
}
}
hash.clear();
assertEquals(0, hash.size());